Product attributes generate errors

I am getting the same message:

warning: preg_match() expects parameter 2 to be string, array given in xxx\includes\bootstrap.inc on line 771.

I have narrowed this issue to UC Node Checkout. It is not handling attributes correctly. I don't see any problems until the order is completed. Once order is completed, whenever I view a node created by uc node checkout that has been purchased, I get the message above.

Attributes are handled a little differently now that checkboxes have been included in ubercart attributes. UC Node Checkout needs updating so it will know how to handle attributes correctly. Patch is not likely from me. Would love to get some help on this.

I think I figured out where the problem lies. In uc_node_checkout.module on line 734 the $options variable turns out to be an array. So I added a foreach loop to cycle through the items in the array.

Before:

foreach ($product->data['attributes'] as $attribute => $option) {
  $option_rows[] = t('@attribute: @option', array('@attribute' => $attribute, '@option' => $option));
}

After:

foreach ($product->data['attributes'] as $attribute => $option) {
  $row_data = t('@attribute: ', array('@attribute' => $attribute));
  foreach ($option as $item) {
    $row_data .= t('@item', array('@item' => $item));
    if (next($option))
      $row_data .= ", ";
  }
  $option_rows[] = $row_data;
}

Thank you for this solution, wesoccer2003! I can confirm that it solves the problem.

This fixed the problem for me too. Thanks heaps.

Fixed it for me too, although a note for those searching, on drupal 6.15 the error is line 777 of bootstrap.inc

Just another "me too" with a thanks for wesoccer2003 for the working solution at #4.

As I wrote in #7 I applied the override successfully (in template.php), but I think an issue I have is related, and hoping this fix can be adjusted.

The ul class product-description prints out to the order record + customer email, with one list item for my one option, plus an empty list item. For a product that has no options, it outputs an empty list item. It prints the bullet followed by the colon that would come between the attribute name and the option.

It seems this is produced from function theme_uc_product_attributes, in uc_attribute.admin.inc, but since what I'm seeing is not reported elsewhere, I'm wondering if the code from #4 is causing this. Is anyone who has applied this seeing an empty list item in ul class product-description (in the order record + customer email)?

A list appears correctly with no extra empty bullet on cart, cart/checkout, cart/checkout/review or the cart block.

Hi,

I just bumped into this bug, too, and made my own patch before noticing that there was already an open issue. For what it's worth, here's my fix.

Jeff

I tested #10 instead of #4 and no errors, except I still get the same as I described in my #9 post, the extra empty bullet and colon. Viewing the order, the empty bullet proceeds the real attribute: option, and on the invoice, it's after it. Is anyone else getting this, to help debug if this is about uc_node_checkout or unique to something else I'm doing?

same issue, but #10 fixed mine perfectly. thanks!

I figured out my issue in #9 and #11, and is unrelated to the patches offered. It was caused by deleting the defaults in the fields of the last item in uc_node_checkout settings, even though checkbox "Add to the default node cart teaser using these settings" is unchecked. I think this is a bug, I'll open its own issue.

Patch #10 fixed the described problem on my install also (Drupal 6.16, UC Node Checkout 6.x-2.0-beta4, IIS 7).

Thanks!

Phil.

Confirmed this is a bug.

#10 patch just works fine.

Applied patch in #10.
And Alleluia brothers & sisters! :-)
This one has been nagging me for months.

Nodes created by uc_node_checkout were showing "Original product attributes" as empty.
The attribute is back & properly displayed.

Bravo!

I have also tested #10 (manually updated my module file as not in position to run a patch from where I am currently) and it worked.

This also fixes my issues #851084: Product attributes cause errors and #900336: htmlspecialchars error (which I will now close).

When will this be added to a new version (-dev or otherwise)?

#10 removed warning "html special character ..." and in addition attribute options are showing up now on node view -thank you jeffam

Fixed in http://drupal.org/sandbox/aidan/1114812

Fixed: Commit 46f89cc on 6.x-2.x