CVS edit link for jasonrsavino

I am a front-end developer and have been for over a decade. I have been using Drupal for a year and have fallen in love with it. The part I find lacking is the look and feel. I want to help by creating simple, yet beautiful themes. I have a theme that I developed after much nudging from rob_feature and mattfarina I have decided to contribute it. I am working on a few other themes that I would like to contribute in the future. To see the theme in use please visit my site: http://jasonrsavino.com

Thank you in advance for the consideration.
Cheers,
Jason

CommentFileSizeAuthor
#4 nifty50.zip38.95 KBjasonsavino
#2 nifty50.zip42.91 KBjasonsavino

Comments

ultimateboy’s picture

Please upload the code so that we can evaluate the theme itself.

jasonsavino’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new42.91 KB
AjK’s picture

Issue tags: +Theme review

Add tag

jasonsavino’s picture

StatusFileSize
new38.95 KB

I removed some extra, unneeded files that were not removed in the last upload.

avpaderno’s picture

Status: Needs review » Needs work
  1. print $front_page

    Always use the semicolon as line terminator.

  2. if (!empty($header)){print 'grid_3 ';}else{print 'grid_11 omega';}

    Use the spaces when needed.

  3. The two points I reported before are two of points reported in coding standards; in the case of a theme, I would also suggest to read CSS coding standards
  4. <?php if(!$is_admin){ ?>
    	<div id="shadow-container">
    		<div class="shadow1">
    			<div class="shadow2">
    				<div class="shadow3">
    <?php } ?>
    

    Use the alternative syntax for the IF-statement, as you already used it.

avpaderno’s picture

  1. print $front_page

    Always use the semicolon as line terminator.

  2. if (!empty($header)){print 'grid_3 ';}else{print 'grid_11 omega';}

    Use the spaces when needed.

  3. The two points I reported before are two of points reported in coding standards; in the case of a theme, I would also suggest to read CSS coding standards
  4. <?php if(!$is_admin){ ?>
    	<div id="shadow-container">
    		<div class="shadow1">
    			<div class="shadow2">
    				<div class="shadow3">
    <?php } ?>
    

    Use the alternative syntax for the IF-statement, as you already used it.

mfer’s picture

@KiamLaLuno This is a request for a CVS account. If you'd like to help lets get him CVS access, get the theme uploaded, and work it form there. If we wait to long or make it too difficult to get access he may be alienated and go away.

@AjK what else do we need to get Jason access?

mfer’s picture

I'd like to +1 the account and theme.

AjK’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.