Patch adds a setting to browscap to allow user to determine how often browscap should check for new data. User can set the interval to any number of days, 7 days is still the default. Setting the number of days to 0 turns off updating.


jcruz’s picture


greggles’s picture

Can you explain the motivation for this? It feels like useless UI cruft to me, but I've just started using the module.

timhill’s picture

It's a little crufty, I'll admit. My main motivation with the patch was to add the ability to turn off auto-updating. This is useful for situations where a server cannot "phone out" and for users who would like more direct control and would prefer to update the browscap file manually. I decided to make the patch able to set the update interval just in case someone still wanted auto-update but didn't want to "phone out" so often.

greggles’s picture

I wanted to test this and had to re-roll it. I also tweaked the spacing on the multiplication. It seems good to me - can you confirm that it still works for you? If so then we could commit it.

timhill’s picture

Sorry for the delay, the patch looks good, works in version 1.1

klonos’s picture

It would be nice to have this in the official and dev builds.

greggles’s picture

@klonos - rather than stating a preference, it would be useful if you could review the patch.

Devin Carlson’s picture

Version: 6.x-1.0 » 7.x-1.x-dev
Assigned: Unassigned » Devin Carlson
4.44 KB

Moving to 7.x and backporting.

The attached patch adds a configurable update interval as in #4 but includes a small number of improvements including improved spelling, more specific error messages and bring back the return of system_settings_form.

Devin Carlson’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)
Issue tags: +Needs backport to 6.x

Committed to 7.x-1.x.

Devin Carlson’s picture

Status: Patch (to be ported) » Needs review
4.63 KB

Backport of #8.

Devin Carlson’s picture

Status: Needs review » Fixed

Committed to 6.x-1.x.

Status: Fixed » Closed (fixed)
Issue tags: -Needs backport to 6.x

Automatically closed -- issue fixed for 2 weeks with no activity.