So the existing dashboard just goes to /admin but that doesn't really conform with the mockups:

http://www.d7ux.org/category/projectframework/dashboard/

This patch provides a new tiny module called dashboard, it's basically a menu hook and a function callback that returns an empty string. This menu hook provides us the ability to build up a page-admin-dashboard.tpl.php file in the seven theme that provides the proper layout for the dashboard module. Everything else is basically just css to make it look the same as the mockups.

A couple things worth mentioning at this point.

1.) You'll need to drop the database and reinstall because of the way the dashboard menu items are handled. Since this is currently in the .install file, and there's no schema to uninstall, you can't actually "uninstall" toolbar module, just disable it, so the menu items for it won't be rebuilt, thus you need to drop the database to get at this properly.

2.) I think the page-admin-dashboard.tpl.php is currently misplaced, probably needs to be in the actual dashboard module, but for the moment I took the quick answer to get some feedback on this.

3.) what's the general consensus on returning a blank string?

Eclipse

Files: 
CommentFileSizeAuthor
#200 dashboard-wrapper-2.patch10.28 KBseutje
Passed: 13438 passes, 0 fails, 0 exceptions View
#198 dashboard-wrapper.patch8.92 KBseutje
Passed: 13455 passes, 0 fails, 0 exceptions View
#197 dashboard-cleanup.patch6.99 KBDavid_Rothstein
Passed: 13454 passes, 0 fails, 0 exceptions View
#173 fix_dashboard.patch986 bytesDavid_Rothstein
Failed: Failed to apply patch. View
#169 dashboard.mov1.46 MBJacobSingh
#167 dashboard-165.patch27.76 KBJacobSingh
Failed: Failed to install HEAD. View
#163 dashboard-162.patch26.54 KBJacobSingh
Failed: Failed to install HEAD. View
#157 blocks-administration.png60.78 KBDavid_Rothstein
#157 individual-block-configuration.png75.12 KBDavid_Rothstein
#143 dashboard-143.patch27.21 KBpaul.lovvik
Failed: Failed to install HEAD. View
#141 dashboard-141.patch25.7 KBJacobSingh
Failed: Failed to install HEAD. View
#140 dashboard-blocks-140.patch26.7 KBGábor Hojtsy
Failed: Failed to apply patch. View
#140 NewBlock.png115.69 KBGábor Hojtsy
#137 dashboard-blocks-136.patch26.11 KBGábor Hojtsy
Failed: Failed to apply patch. View
#134 DashboardTitlesB.png73.54 KBGábor Hojtsy
#134 dashboard-blocks-134.patch26.12 KBGábor Hojtsy
Failed: Failed to apply patch. View
#131 NoTitleNoContent.png77.91 KBGábor Hojtsy
#131 dashboard-blocks-131.patch25.48 KBGábor Hojtsy
Failed: Invalid PHP syntax in modules/dashboard/dashboard.css. View
#116 withoutnowrap1.jpg81.11 KBseutje
#115 withoutnowrap2.jpg54.16 KBseutje
#115 withoutnowrap1.jpg77.37 KBseutje
#115 withnowrap2.jpg55.17 KBseutje
#115 withnowrap1.jpg77.37 KBseutje
#115 after2.jpg117.88 KBseutje
#115 after1.jpg122.57 KBseutje
#115 before2.jpg126.27 KBseutje
#115 before1.jpg115.49 KBseutje
#113 dashboard-blocks-109.patch22.53 KBseutje
Failed: Failed to apply patch. View
#109 BlockList.png33.64 KBGábor Hojtsy
#109 BlockListWrap.png38.44 KBGábor Hojtsy
#109 dashboard-blocks-108.patch24.08 KBGábor Hojtsy
Failed: Failed to apply patch. View
#108 dashboard.jpg304.79 KByoroy
#100 dashboard-cursorat-top.patch22.27 KBseutje
Failed: Failed to apply patch. View
#96 dashboard-blocks-96.patch23.85 KBGábor Hojtsy
Failed: Failed to apply patch. View
#76 AdminHome.png29.26 KBGábor Hojtsy
#76 CustomizeAction.png15.45 KBGábor Hojtsy
#76 Drawer.png48.97 KBGábor Hojtsy
#76 DrawerLayout.png33.68 KBGábor Hojtsy
#76 dashboard-blocks-yoroyfix.patch26.47 KBGábor Hojtsy
Failed: Failed to apply patch. View
#75 dashboard-blocks-xx.patch25.81 KBGábor Hojtsy
Failed: Failed to apply patch. View
#65 dashboard.png34.46 KBDavid_Rothstein
#57 dashboard-blocks-57.patch23.71 KBksenzee
Failed: Failed to apply patch. View
#54 dashboard2.tar_.gz.txt4.96 KBseutje
#53 dashboard.tar_.gz.txt4.95 KBseutje
#47 dashboard-blocks-47.patch22.68 KBksenzee
Failed: Failed to apply patch. View
#46 dashboard.css_.txt1.09 KBseutje
#44 dashboard-blocks.patch8.24 KBseutje
Failed: Failed to install HEAD. View
#40 dashboard-blocks-40.patch24.36 KBDavid_Rothstein
Failed: Failed to apply patch. View
#39 Screenshot.png.jpg129.61 KBseutje
#37 dashboard-blocks-37.patch21.45 KBksenzee
Failed: Failed to apply patch. View
#35 dashboard-blocks-35.patch18.49 KBDavid_Rothstein
Failed: Failed to apply patch. View
#34 dashboard-blocks-34.patch18.67 KBDavid_Rothstein
Failed: Failed to apply patch. View
#27 dashboard-blocks-27.patch13.46 KBksenzee
Failed: Failed to apply patch. View
#23 dashboard-blocks-23.patch13.64 KBksenzee
Failed: 12641 passes, 1 fail, 0 exceptions View
#14 dashboard-blocks-3.patch9.24 KBDavid_Rothstein
Failed: Invalid PHP syntax in modules/dashboard/dashboard.module. View
#12 dragme.jpg37.69 KBseutje
#11 page-admin-dashboard.tpl_.php.txt1.87 KBGábor Hojtsy
#8 Customize.png8.25 KBGábor Hojtsy
#8 DashboardMove.png54 KBGábor Hojtsy
#8 dashboard-blocks.patch6.35 KBGábor Hojtsy
Failed: Failed to apply patch. View
#4 dashboard-blocks.patch3.62 KBGábor Hojtsy
Failed: Invalid PHP syntax in modules/toolbar/toolbar.install. View
#4 Dashboard.png42.21 KBGábor Hojtsy
dashboard.patch6.12 KBEclipseGc
Failed: Failed to apply patch. View

Comments

yoroy’s picture

We're working towards something like this (click for larger):

EclipseGc: as I read it you're mainly providing a blank slate code wise, or is there a screenshot to be made? Thanks for starting this. For now, I don't have a very explicit opinion on wether to return a blank string ;-)

yoroy’s picture

Status: Needs review » Closed (duplicate)

And the rest we will discuss in #376103: Make /admin into a REAL dashboard. ! :-)

Gábor Hojtsy’s picture

I'm not entirely sure #376103: Make /admin into a REAL dashboard. has a better approach, duplicating all the blocks logic might not be the right way to build this dashboard. If we were to go with blocks, I'd add dashboard specific regions (think Dashboard left and Dashboard right). There are some issues with blocks however:

- they will show up as stuff to place into the site theme - possibly not our goal
- Drupal's block system still generates all blocks for all regions on all pages, and does not know that a region would not be displayed on a page, so dashboard blocks will be generated for all admin pages => major waste of energy

So neither is the ideal world ;) Maybe making blocks more intelligent and finally implementing block regions in some kind of pull method instead of the current push one.

Gábor Hojtsy’s picture

Status: Closed (duplicate) » Needs review
FileSize
42.21 KB
3.62 KB
Failed: Invalid PHP syntax in modules/toolbar/toolbar.install. View

Well, let's try this one :) Here is a quick reroll of EclipseGc's patch. It keeps the dashboard module. The roal of the module can be manyfold:

- include a hook_block_list_alter() to overcome the two regions generated for other pages, where these regions are not displayed - fixing the performance problem
- add JS helpers to add a close icon to blocks to disable them, etc.
- add a bit more weighty JS helpers to let drop and drop blocks here (which would also require a listing of disabled blocks to be displayed in a graggable way) -- I did this in multiple projects before and it is not hard at all with jQuery UI in core now -- in that case we should hide these regions on the blocks admin UI

This is how it looks now, blocks can be managed on the normal blocks UI ATM by dragging items into the "Dashboard thick" and "Dashboard thin" regions. Blocks just show up as designed on the above mockup. The rest of the content depends on the blocks.

This is how it looks:

Gábor Hojtsy’s picture

Title: Dashboard Module » D7UX dashboard module
Issue tags: +Usability, +D7UX

Tagging up. The reason this dashboard would be highly useful is that it provides a way to set up your own overview and quick jump screen, saving you lots of clicks deep inside the Drupal interface to get a good overview. Core itself can ship with a few useful blocks and other modules can add more. Site builders could add more with Views easily.

seutje’s picture

after applying the patch, clicking the link took me to admin/dashboard which showed me a 404

/**
 * Implement hook_menu().
 */
function dashboard_menu() {
  $items['admin/dashboard'] = array(
    'title' => 'Dashboard',
    'page callback' => 'dashboard_admin',
    'access arguments' => array('access toolbar'),
    'type' => MENU_CALLBACK,
  );
  return $items;
}

function dashboard_admin() {
  return '';
}

huh? o.O

Gábor Hojtsy’s picture

@seutje: rebuild your menu?

Gábor Hojtsy’s picture

FileSize
6.35 KB
Failed: Failed to apply patch. View
54 KB
8.25 KB

Here is a quick update, and this is probably the extent I can devote to this patch today (given more important priorities).

This one adds a JS file which adds a Customize button on top of the dashboard. That displays a list of disabled blocks (which I'd suppose would be draggable to the block regions). It also sets up the block regions for drag and drop, so blocks among the two regions can already be dragged and dropped. Thanks to jQuery UI, this only takes about 10 lines of code :)

This is obviously a proof of concept.

The customize button:

Moving dashboard items:

Gábor Hojtsy’s picture

Oh, and this previous patch also fixes performance concerns by unsetting dashboard blocks on non-dashboard pages.

seutje’s picture

hmm, turns out I have to enable the module, but the dashboard link shows up regardless

also, my dashboard page is entirely empty, aside from the customize button and when I click that, I get another empty page with just "Drag and drop blocks to their place"

it isn't untill the blocks page form for seven (/admin/structure/block/list/seven) is submitted that this query will have results:

 $result = db_query("SELECT * FROM {block} WHERE theme = :theme AND status = 0", array(':theme' => $theme_key));

simply because upon installing drupal, there's only 6 blocks or so in that table, and they're all status = 1

so after submitting that form, the admin/dashboard is still empty, but when I click on customize, I can see some disabled-block divs, but these are not draggable/sortable

I tried throwing some blocks in dashboard-thin and dashboard-thick, but these did not show up on the dashboard, and after checking it looks like the conditional in dashboard_block_list_alter is not what's causing it, it looks like the regions are just not getting printed

I added a print_r(block_get_blocks_by_region('dashboard_thin')); in seven's page.tpl.php just to check and after removing the stuff from dashboard_block_list_alter it actually did print the blocks that I put in there, but only on pages other than admin/dashboard

also this kinda has me worried:

$('#content').load(Drupal.settings.dashboard.customize);

wouldn't that remove anything that is already inside the main content div? (not sure maybe this is desired, but atm it doesn't make that much sense to me)
for instance, if I add a block to the help region and one to the content region, they will show up at the dashboard page, but once I click customize, they will disappear
so maybe prepend/append would be more desirable here, I dunno

Gábor Hojtsy’s picture

Oh, yes, I forgot to add the page-admin-dashboard.tpl.php file to the patch :) It to be under Seven's theme dir currently.

seutje’s picture

FileSize
37.69 KB

o wow, and I was thinking it was something I was screwing up... bah :P

but yea after adding that, I do see blocks on the dashboard page and they don't disappear as they aren't in $('#content')

I take it that dragging from one region to the other doesn't work yet, and neither does dragging an inactive block into a region?

also, I find it a bit weird acting... I expected the title to be the grabbing point for the drag, but I guess since not all blocks have a title, we can't rly do that...

perhaps we should add something that's obviously for dragging the block? or at least make the cursor change when hovering over it because it's rly confusing right now

attaching screenshot of possible hover state where the "drag me" label would be the thing u grab, instead of the block content
Drag label proposal

Gábor Hojtsy’s picture

Dragging from thick to thin and backwards as well as reordering in the regions should work (but not saving that reordering yet). Dragging from the list of disabled modules will not yet work.

David_Rothstein’s picture

FileSize
9.24 KB
Failed: Invalid PHP syntax in modules/dashboard/dashboard.module. View

Here's a rerolled version of the patch that "works" out of the box: (a) the missing file is included, (b) the Dashboard module is preinstalled, and (c) the blocks are automatically loaded so that you don't have to submit the admin/structure/block/list/seven form before seeing the disabled blocks on the dashboard configuration page.

I tried to find a way to do (c) cleanly, but failed - or perhaps it was the block module's code that failed me, so for now, we're doing it in kind of an ugly way.

Anyway, this looks pretty good in general. In the long run we obviously don't want to tie it to the Seven theme, and it would be really nice to have a per-user dashboard rather than a single administrative one, but if it's all we can do at this point, it's still a good start.

Note that because Drupal does not support having the same block in multiple regions in the same theme, I think that means that this feature would be less useful (and a bit more confusing) if it's used on a site that does not have a separate admin theme enabled. Because then, any block that you put on your admin dashboard cannot appear anywhere else on your site.

Dries’s picture

Issue tags: +Favorite-of-Dries

I think the dashboard has great potential for power-users that want faster navigation.

It is also something that can evolve a lot of time to become something really compelling.

Last but not least, it would be great for use on Drupal.org, so it feels like we'd be able to leverage some of this work.

int’s picture

I really liked..

Not only good por power-users but for all users.
To, in one page can have all stats information about the site. Is great..

catch’s picture

Assigned: EclipseGc » Unassigned

Subscribing.

mcrittenden’s picture

Subscribe.

Status: Needs review » Needs work

The last submitted patch failed testing.

ksenzee’s picture

Assigned: Unassigned » ksenzee
Status: Needs work » Needs review

I am actively working on this and hope to have a patch I can post sometime tonight.

ksenzee’s picture

Status: Needs review » Needs work

project.module seems to think I have that patch already...

yoroy’s picture

Go ksenzee! :-)

ksenzee’s picture

Status: Needs work » Needs review
FileSize
13.64 KB
Failed: 12641 passes, 1 fail, 0 exceptions View
35.69 KB

Ok, that took 24 hours longer than I thought. :) I'm marking this to needs review, because it does, but it's still missing what I consider to be an important piece. When you drag a block from the "disabled" section into the dashboard, it should expand to show the block content. That's not there because I can't figure out how to render a block in D7. I would love to be enlightened.

Even without that piece, though, this is a functional patch. Drag and drop is fully working, and it saves the dashboard state to the server. I'd very much like people's opinion on whether this is worth pursuing over the next couple of days, or if we should step back and make the dashboard into a contrib module.

Remaining TODOs:
* Expand disabled block content on drag, as I mentioned above.
* Better design for the customize mode.
* Some way to get out of customize mode and back to normal dashboard view. (Whatever UI control we use for that can just trigger a page refresh.)
* Quit assuming we're in the Seven theme.

Screenshot:

Status: Needs review » Needs work

The last submitted patch failed testing.

jeffschuler’s picture

Status: Needs work » Needs review

Dashboard customizations aren't being saved for me.

ksenzee mentioned on IRC that they should be auto-saved, but on refresh or clicking Dashboard again the blocks and regions are no longer visible -- only the Customize button.
I'd also like it to be more apparent that they are [supposedly] being auto-saved. I was looking all over for a Save button.

Maybe "Some way to get out of customize mode and back to normal dashboard view" (your TODO) could be to leave the Customize button in place, but toggle it into an On state when customizing... clicked again it would go back to normal mode. Or... use the old Edit / View buttons like on nodes.

I wonder if a "Save Dashboard" button would make more sense than Autosave, though, as that's how most other admin screens work.

Also, I'd probably call the unused blocks "Available blocks" instead of "Disabled blocks". "Disabled" made me think, at first, that they were the blocks not being used on the main Blocks admin page.

jeffschuler’s picture

Status: Needs review » Needs work

started editing my last comment before testbot changed status...

ksenzee’s picture

Status: Needs work » Needs review
FileSize
13.46 KB
Failed: Failed to apply patch. View

Changed "disabled blocks" to "available blocks," and moved the help text out of hook_help() for testbot's benefit. It didn't like the fact that we were providing help on admin/dashboard, but then hiding it until the customize button was clicked. I think it was actually cleaner the other way, but this will do.

I can't reproduce the problem jeffschuler reported where blocks aren't being saved. It would be helpful to get some more reviews.

ronald_istos’s picture

Tried this - looks good to start with.

Should say for anyone wanting to try it quickly - you need to:

a. activate module (btw, where did the go to module list link go to in Seven)

b. visit admin/dashboard (the dashboard link from the toolbar does not take you to the dashboard this patch creates)

As for the actual functionality:

1. This is something cool to have in Drupal - it scores lots of easy points straight away and can provide a launchpad/motivation for building lots of dashboard services

2. Regarding the actual interface the Customize page is clear enough but there does need to be some visual indication that once you move block around they are actually saved in that position as #25 above. Customize could change to Save once you are in customize mode.

3. Changes were saved for me (against latest head)

4. This from #14 is a bit of an issue: "Because then, any block that you put on your admin dashboard cannot appear anywhere else on your site.". I can think of blocks I want in my dashboard but also on the site and it would just be confusing as my mental model of a dashboard is as something adminy and separate from how I setup the rest of the website

Still worth exploring further and hope to pick this up again. I should also add that given the "wow" appeal it would be good to have this with the standard Drupal profile (i.e. activated by default) rather than a contrib module.

seutje’s picture

so should we support multiple instances of the same block in core (contrib already does) or should we go at this some other way?

catch’s picture

We should, but there's no way we can do block instances in one day. Also this will only be an issue when not using an admin theme separate from the main site theme, so I don't think it's enough of an issue to hold this up.

David_Rothstein’s picture

I reviewed this patch and have the following feedback (in no particular order):

  1. I, too, experienced the problem where auto-saving did not work. This is due to the following line of code:
    +      console.log(Drupal.settings.dashboard.blockContent + '/' + module + '/' + delta);
    

    Removing it fixes the problem :)

  2. +files[] = dashboard.info
    

    You don't need that one, I believe.

  3. +      item.attr('class', itemClass.replace(/\bdisabled-block\b/, ''));
    

    Not positive... but isn't it possible to use removeClass() here?

  4. +    'access arguments' => array('access toolbar'),
    

    I think this module should have its own permissions. Also, for customizing the dashboard (as opposed to just seeing it), I'd tend to think "administer blocks" might be appropriate, given the power it gives you over the whole blocks system.

  5. +    'type' => MENU_CALLBACK,
    

    Similarly, it would be nice if this were a regular menu item (so that it did not have to rely on the toolbar to show links to it).

    On the other hand, the "admin/dashboard" URL means that it would automatically be promoted to the top of the toolbar if you made this a visible menu item. This is exactly the kind of thing I was worried about during my various complaints at #508458: Config and modules page a while ago. But, I think we're going to have to discuss that whole issue again after code freeze anyway, so we can deal with it later, I guess... a workaround for now might be to make the URLs admin/config/dashboard or something, but I'd personally rather highlight the problem than work around it :)

  6. +  $items['admin/dashboard/block-content'] = array(
    +    'page callback' => 'dashboard_show_block_content',
    +    'page arguments' => array(3, 4),
    

    Don't we need "%/%" at the end of the URL in order for the page arguments to work correctly? (I guess it might work without it, but seems like we probably should unless there's something I'm missing.)

  7. +  if ($_GET['q'] != 'admin/dashboard') {
    

    Ugh :) On the other hand, I can't think of anything a whole lot better. I think it would be slightly preferred to use menu_get_item() and then check the "page callback" to see if it matches the function you want.

  8. +;hidden_regions[] = dashboard_thick
    +;hidden_regions[] = dashboard_thin
    

    In or out of the patch? :) I think "out" is correct.

  9. In terms of a strategy for getting this out of the Seven theme, would it be possible to use hook_system_info_alter() to add the dashboard regions to any theme? I think that might work.
  10. "Dashboard thick" and "Dashboard thin" seem like somewhat awkward names. Maybe something like "Dashboard highlights" and "Dashboard sidebar"?
  11. If JavaScript is disabled, do we need some kind of fallback behavior? Maybe just a link to the blocks administration page?

Overall feedback (on the big question of what should happen with this patch): I think it should be in core, although the question is whether one day is enough to do something with it or get a code freeze exception, or what.... I like it because although it has some limitations, putting it in core encourages module authors to build for it. For example, maybe some would start providing two versions of their blocks, with one geared mainly towards site admins on a dashboard page, etc. It's a really powerful tool.

The one thing I feel like might really make it super-core-worthy is if the drag and drop block placement code is reusable by other modules that want to make their own dashboards (with different regions, etc). I think to a large extent this patch is reusable; although it only provides two dashboard regions of its own, there's an interesting line of code:

+      if (strpos($block->region, 'dashboard') === 0) {

which at first I thought was kind of ugly, but then realized might actually be neat because it applies to any "dashboard-like" region regardless of who defines it.

So I wonder a bit, what would it take to make the Javascript (especially) and HTML-generating-code (maybe) reusable for more than the two specific dashboard regions defined by this module? Is that realistic, or too hard?

catch’s picture

This should go at admin rather than admin/dashboard, so we can remove http://api.drupal.org/api/function/system_main_admin_page/7 - which is currently duplicated by system_admin_config_page() - there's no need for that page to exist any more. Modules which might want to replace this in contrib can do so by adding themselves at /admin too.

Gábor Hojtsy’s picture

@David: on those regions, the patch only seems to mention them a little in the JS and then in the theme .info file. The JS just generates these two known regions if they are not there. I'd say the PHP of the template should be "fixed" to always generate the markup for the regions, which then make the JS part superfluous. Then theoretically, the dashboard code could support any number of regions named "dashboard...." given the generic code elsewhere.

@catch: I'm not so sure about that page going away. I've seen many people in the issues queues like Moshe vouching for it to stay, even if under a different URL. If its bugs are fixed, it provides a good glance of the admin screen, which might not have been testing well, but works for many people. It does not need to be in the face obviously.

David_Rothstein’s picture

FileSize
18.67 KB
Failed: Failed to apply patch. View

Here is a version of the patch that fixes the auto-saving problem mentioned above, and also removes some of the dependency on the Seven theme (the dashboard module now takes care of defining the dashboard regions itself, via hook_system_info_alter). This required fixing a bug or two in order to actually get working.

Next up will be to try removing all dependency on the Seven theme (i.e., the page template).

Note: If you're testing out this patch, the first block you typically see in the list of "disabled blocks" on the dashboard page is the Recent Comments block, so instinctively that is likely to be the one you start testing the patch with. However, if you drag that block into a dashboard region, the auto-save will appear to be broken. Actually, it isn't -- everything is working fine, but it's just that the block doesn't actually display on the page, due to #565642: "Recent comments" block is completely hidden when no comments are available. I don't even think I want to admit how much time I wasted trying to debug that "bug" in the Dashboard module before I realized what was actually causing it :)

David_Rothstein’s picture

FileSize
18.49 KB
Failed: Failed to apply patch. View

New version:

  • Works with any theme (looks a bit clunky in Garland, but works).
  • Works with an arbitrary number of dashboard regions (the patch still only provides two, but it's easy to add others and theme them however you want.
David_Rothstein’s picture

Some more issues to fix later that I noticed:

  • When you customize the dashboard, all your disabled blocks get marked as enabled in the database, preventing them from showing up on the blocks administration pages (looks like an easy fix).
  • Some text is not wrapped in t().
  • Currently, when you switch themes, your dashboard does not carry over to the new theme (or another way of saying this is that you have multiple dashboards, one for each theme). Hard to say if this is a bug or a feature.
ksenzee’s picture

FileSize
21.45 KB
Failed: Failed to apply patch. View

More fixes:

- When you drag a block in from the disabled area, its content loads.
- You can now exit "customize mode" by clicking a button.
- We're now using menu_get_item() to avoid checking $_GET['q'] directly, per David's suggestion in #31.
- Changed the dashboard region names to dashboard_main and dashboard_sidebar.
- Made sure there are docblocks for everything.
- The dashboard module exposes its own permissions, and requires 'administer blocks' permission to customize (again per #31).
- The first bullet point under #36 is fixed.
- I think all the non-t() text is now properly t()'d (second bullet point under #36).

The third bullet point under #36 is either a bug or a feature. If we decide it's a bug, we can fix it later. As David said, it may be a feature. I'm not sure. But certainly it's a core attribute of blocks in Drupal that block placements are theme-specific.

I think all the showstoppers are now eliminated. And hey, we've still got an hour and a half left before code freeze. Anybody? :)

mikeytown2’s picture

+1 looks good on XAMMP/XP

seutje’s picture

FileSize
129.61 KB

The functionality seems to work like it should on FF3.5 (aside from all blocks disappearing when any empty block is moved, even if it's just reordering the available blocks, not even dragging it into an active region)

but this thing is going to need a lot of theming love, for instance:

  • when there's a lot of available blocks, they don't always seem to wrap to the next line, but when they do, they stick against the row above that, they don't seem to wrap if I drag a block from an active area to the very end of the available blocks, in one occurrence the padding (and rounded corners) was on one line and the rest was on the other line (see screenshot)
  • dashboard main has a width of 65%, and the sidebar is 30%, which leaves a 5% gap, which was probably added to allow the margin to put on the 2 divs, but you should just add an extra wrapper around it, put the width on the outer wrapper and the margin on the inner one, coz right now the available bit is bigger than the dashboard_main and sidebar combined

also had some weird experiences with the line wrapping where one of my available blocks was pushing all the following ones to the next line, but I couldn't recreate the weirdness the second try and I don't really know what triggered it

EDIT: FF3.0 not 3.5 sry (updating right now :P)

David_Rothstein’s picture

FileSize
24.36 KB
Failed: Failed to apply patch. View

New version:

  1. Fixed an issue with hook_permission(), and also made it so that the "Customize" button doesn't show up for users who don't have the permission to use it.
  2. Added a dashboard_is_visible() function to consolidate code for determining if the dashboard will be displayed.
  3. Added a theme function for the disabled blocks region.
  4. Put a notice telling the user that their changes on the customization page will automatically be saved.
  5. Fixed most remaining issues from #31. This includes making the dashboard a normal menu item, so it may show up in the wrong place, but at least it shows up somewhere within the menu system :)
  6. Added a few more code comments.

Still not done:

  1. The issues raised in #39 (I've seen some of that too).
  2. No fallback behavior for users not using JavaScript (although as mentioned above, this should be pretty simple - instead of a customize button, we can probably just put a link to the block administration pages).
  3. I'm not sure what's up with this CSS - it was missed because it didn't match my find/replace when converting the CSS from being Seven-specific. Do we need it?
    +body.page-admin-dashboard.one-sidebar div#content div.block {
    +  margin-right:20px;
    +}
    
David_Rothstein’s picture

Hm, I also just noticed that the dashboard blocks are showing up on the "access denied" page (when you view admin/dashboard without proper permissions).

Ideally, that's not what we want to happen :)

mcrittenden’s picture

Just a nitpick: can we rename "Return to regular dashboard view" to something shorter which has to do with saving changes? Something like "Save and Close" or just "Save Changes"? "Return to regular dashboard view" is too long and could be (mis)construed to mean that changes are discarded.

int’s picture

Issue tags: +Exception code freeze

add tag

seutje’s picture

FileSize
8.24 KB
Failed: Failed to install HEAD. View

changed the CSS a bit to put the margin on the inner container and set the width for the sidebar to 35% to the total ends up at 100% and the top and the regions are the same width

EDIT: o dear, ignore this patch, it's pretty borked

Status: Needs review » Needs work

The last submitted patch failed testing.

seutje’s picture

FileSize
1.09 KB

I really can't seem to figure out how to add a new folder trough a patch with read-only rights, so I'll just add the modified dashboard.css file

ksenzee’s picture

Status: Needs work » Needs review
FileSize
22.68 KB
Failed: Failed to apply patch. View

Changes:

- Added seutje's new lovely dashboard.css.
- Removed the chunk of CSS David called out. We're not outputting anything that it would apply to, so it shouldn't be there.
- Added a no-js fallback link to the blocks admin page.

@mcrittenden: Agreed the button text is not great. I'm not sure saying "Save" makes any sense, though, since we're autosaving changes. It would imply you can cancel without saving. I've changed it to "Close," which I don't particularly like either. Other suggestions welcome.

I'm currently struggling with how to provide contextual help -- whether it should be through the help system or outside it. The help system would make the most sense, but I don't think it's currently flexible enough to handle contextual help on a heavily ajaxified page, in a situation where the help only applies to people with certain permissions. Again, suggestions welcome.

mcrittenden’s picture

ksenzee: "Close" is definitely better than the previous. I went for "Save and Close" since it seemed to work for Google Docs which also autosaves, but I agree that it implies that it's possible to close without saving, which is definitely a problem.

attiks’s picture

I had a quick look, I like the functionality, but is there a reason why the dashboard isn't shared amongst themes? I think it's better to not tie it to a theme.

Bojhan’s picture

#569190: D7UX: Dashboard contents To discuss the actual contents of this dashboard.

jenlampton’s picture

Keeping in mind that I've never seen this dashboard before, here are my first reactions.

1. There is already an item in the gray navigation called "dashboard" which goes to /admin. By enabling the dashboard module, there's now a second link in the black navigation, called "dashboard". This is confusing. Why is /admin called dashboard? (maybe that's a separate issue...)

2. customize button makes sense, but can we move it somewhere other than the top-left of the page? especially once we have already configured the page. It doesn't need to be the first thing you see anymore. how about top right? or inside #branding? or closer to the page-title?

3. the list of available blocks is too wide for the space provided. we need to account for different screen sizes with wrap where necessary. Can we display inline?

4. I also don't think "close" is the right language for that button, it implies no saving. what about "Done" ?

jenlampton’s picture

Re # 49

I think it would be better to have some way for modules to provide information that will be available on the dashboard that can circumvent the usual block system. Maybe an API change to block that lets us pass a parameter to specify a block type? Maybe a hook_dash?

Here's why I feel that the dashboard doesn't fit the block model...
- block system is theme specific, but dashboard shouldn't be.
- block system is designed to be site-wide, not just for one page with a custom layout
- putting dashboard-only regions on the admin/structure/block page seems greedy, but...
- we don't need these blocks on the admin/structure/block page if our dashboard has it's own configuration!

What do others think?

Jen

seutje’s picture

FileSize
4.95 KB

gave it some more theming love

  • the disabled blocks were display:inline which cause the weird wrapping behavior, changed those to float left
  • changed the clearfix class from the outer wrapper to the inner wrapper
  • added js to allow the following:
    • while dragging an active block, you were also dragging the content, for big blocks, that's annoying as hell, so I tried to fix that by hiding it, making it look more like an inactive block. but it still retains the width and I haven't found a sensible solution for blocks that don't show a title and when u use the content area to drag, it's just weird coz the thing u grabbed is invisible and the title bar is floating above it
    • the placeholder thingy for where u are dropping the block was whitespace, and when dragging an active block that placeholder had the same size as the block u were dragging, and due to the wrapping fix, it would bump all the block in a tiny corner in the right, so I set a custom class for the placeholder and added some CSS to make it look somewhat reasonable without bumping all the other blocks away

@jenlampton: we do need these blocks on the admin/structure/block page coz how else will non-js users configure it? And the dashboard needs to be user specific, which the block system allows

made a tarball of the entire folder this time (sry, but I really need some1 to take some time to explain me how to make a proper patch for core, coz adding files and folders isn't that straight-forward)

seutje’s picture

FileSize
4.96 KB

some more theming love

the placeholder will now have the proper height in the active regions

alexanderpas’s picture

subscribe (will review later)

sun’s picture

ksenzee’s picture

FileSize
23.71 KB
Failed: Failed to apply patch. View

Reroll including seutje's changes and jenlampton's "Done" button text suggestion.

@seutje - Adding files and folders to a patch is a lot easier if you use git (or I presume bzr, although I've never used it). Catch me in #drupal and I'll show you how in three easy steps! :)

@jenlampton, re #51/2 - The customize button is just a placeholder really, until we have this working with the overlay. Take a look at the mockup in #1. I think the overlay is almost RTBC, so I should probably check this with the overlay patch.

Next up on my list is making sure blocks in customize mode always have a title.

ksenzee’s picture

Oh, and we need to add the little configuration icons in the top right-hand corner of each block, which I assume should lead to the block config page.

Another thing from the mockup that we should be looking at is how to add the text to the right of the block titles. I had written that off as not achievable before the original code freeze, but now that we have an extension we can maybe do it.

David_Rothstein’s picture

Oh, and we need to add the little configuration icons in the top right-hand corner of each block, which I assume should lead to the block config page.

No reason to do that here, I think; it should hopefully come automatically from #473268: D7UX: Put edit links on everything?

Gábor Hojtsy’s picture

Agreed with David on the config icons. Same was also echoed by Dries before.

eigentor’s picture

Can whe have a screenshot of what this is looks like - if the changes are visible?

seutje’s picture

@ksenzee thx a lot for rolling this back in a proper patch, I didn't know I could use git for this, I'll check it out myself before bugging you on IRC

The block title/content problem is pretty high on my list as well, we should use the block description instead of the title, like we do on the block config page, but only in the edit-mode
the config buttons should come automatically with the other patch indeed, as it's done in the theming (isn't it?)

also, I'm still experiencing some weirdness concerning the attaching point, like the point in the dragging element that snaps to a region. When dragging a big active block the snap-point seems to be the very middle of the original size of the dragged element. It seems more desirable to make this snap-point be the location of the mouse, but I'm not that familiar with UI sortable and how to override default behavior

@eigentor I'll try to get around making a lil movie of the current state later tonight

also, a lil question for whoever knows the answer: why are we using underscores in ID's? (#dashboard_sidebar for instance) I've been looking for other occurrences of this in core for a couple days now and I can't find any (not a grep hero, so doing it manually) and personally, I don't think this is best html/css practise
it's also been annoying me coz all the other ID's and classes use dashes (.dashboard-region for instance) so I keep wondering why $('#dashboard-sidebar') isn't returning anything
I have however seen reports of older browsers (and I really mean OLD, we're talking CSS1 here) to have difficulties with underscores in selectors -> http://devedge-temp.mozilla.org/viewsource/2001/css-underscores/

I would also like to get rid of all element specific selectors, none of them are necessary and they only make the selector stronger, making it harder to override, and a div#dashboard_main selector is rather silly, coz they tend to be less performant than just #dashboard_main and since you're using an ID, it's pointless to specify the element... if an ID can occur on several elements, even if not at the same time, you are doing something wrong

yoroy’s picture

after enabling the module, find it at /admin/dashboard:

- The empty state is quite, ehm, empty. We might want to look into enabling some block here from the start. One of the d7ux objectives is to provide sensible defaults. Even if what we enable by default does *not* match what a user might want, it would still be (more?) clear that this can be changed. Make it do *something* from scratch, a blank canvas is harder to start with for users that changing some predefined settings.
- Haven't read the full thread here yet. Is the top level link an intermediate measure?

Ok, let's click that button then (click image for full pic):

Dashboard | d7

- Need to distinguish between the 'drawer' and the 2 columns that actually make up the page (no dashes around the drawer but a bg color?)
- Give the empty regions a bit more height by default, make it easier and clearer that this is where you drop stuff into
- I expected the drawer to be on the bottom, dragging things *up* into the regions, but that might just be personal preference
- Move the 'Done' button to bottom of page.

Clicking 'Done':

Dashboard | d7

Not sure if the button should be a button. If it should, then position it under the dashboard itself. If it's an action link, then it can stay at the top. Not sure yet which one it should be, but leaning towards action link.

Overall: looking really nice already! Main points ux wise would be:
- enable some blocks by default
- visually seperate the box with available blocks from the actual regions

yoroy’s picture

Status: Needs review » Needs work

status

David_Rothstein’s picture

FileSize
34.46 KB

@yoroy: I think you may need to apply the patch before installing Drupal? The default install profile should be automatically installing the module and populating the Dashboard with a couple initial blocks. See the attached screenshot for what it looks like to me after installation.

I think we could probably use better defaults though. I think the search box might look decent in the left hand column, for example (although that would prevent you from using it anywhere else in your admin theme)...?

Regarding the double Dashboard link in the toolbar, see point 5 of comment #31 - I'd consider it a separate bug. Although Gábor at http://drupal.org/node/508458#comment-1992928 points out that maybe the Dashboard belongs in the upper menu after all anyway...

seutje’s picture

quality is a bit choppy, audio is horrible and out of sync, but I added a few annotations with the important stuff

the part at the end isn't rly "current state" but more like an option to utilize this on every page to get a on-page block editing everywhere

http://www.youtube.com/watch?v=BqKU2OCX_FA

yoroy’s picture

#65: thanks David, I indeed did not re-install, just applied the patch. Other comments still stand though :-)

eigentor’s picture

@seutje:

Wow, crazy! This is even getting near what blocks admin page might look like in D8 (dream...)

seutje’s picture

@eigentor:

I was actually thinking we could implement this on every page so we have a proper in-page block editing functionality where one can edit blocks right on the very page they want it on, but considering how much work there is left towards that goal, I agree on the D8 dream ;)

Gábor Hojtsy’s picture

@seutje/eigentor: let's keep focused on the dashboard and not come up with major changes for the blocks UI itself.

Tested with the overlay and none of the dashboard blocks show up in the overlay. This is probably due to how the overlay whitelists certain regions. This needs to be fixed in some way. Otherwise it works well in my testing.

seutje’s picture

@ksenzee: thx for the GIT 101

@Gábor: pft, fine :P

    . '

'.(!empty($block['title']) ? $block['title'] : $block['info']).'

'

is it just me or is $block['title'] always empty?

I was trying to reuse function dashboard_show_block_content($module, $delta) to grab only the info at the moment enterCustomizeMode for the active blocks that don't have a title, and in that way force those blocks to have some sort of title label so even empty blocks with no content or title would be somewhat visible but I noticed that the following query (from dashboard_show_block_content($module, $delta)) didn't provide me with anything usefull for this

  $block_object = db_query("SELECT * FROM {block} WHERE theme = :theme AND module = :module AND delta = :delta", array(
    ":theme" => $theme_key,
    ":module" => $module,
    ":delta" => $delta,
    ))
    ->fetchObject();

as this is what it returned for the powered-by $block_object:

stdClass Object
(
    [bid] => 16
    [module] => system
    [delta] => powered-by
    [theme] => seven
    [status] => 0
    [weight] => 12
    [region] => 
    [custom] => 0
    [visibility] => 0
    [pages] => 
    [title] => 
    [cache] => -1
    [page_match] => 1
    [enabled] => 1
    [subject] => 
)

so is there a way to load a single block's info better than this?

$module_blocks = module_invoke($block_object->module, 'block_info');
$block_info = $module_blocks[$block_object->delta]['info'];

or should we just fall back on delta in cases like this (I imagine this can be very unpretty in some cases)

ksenzee’s picture

Assigned: ksenzee » Unassigned

so is there a way to load a single block's info better than this?

No, I'm not aware of a way other than invoking hook_block_info(). The only other option I can think of is to change the database schema to store a copy of the description, which would be pointless IMO.

I'm unassigning myself so no one else will hesitate to work on this. I think we're close, in terms of a minimally committable feature. Obviously it would be nice to have a per-user or per-role dashboard, but that seems like a separate feature.

ksenzee’s picture

Oh yeah -- I forgot. Yes, Gábor, the overlay incompatibility is because the overlay patch blows everything away but its own happy little regions, obliterating the poor dashboard regions entirely. <sob> The simplest fix is to whitelist dashboard_* regions as well. That introduces what seems like unnecessary coupling, but without some kind of region tagging scheme, I can't think of a better approach.

seutje’s picture

so should I expose another path and make a callback that does the block_info stuff, or should I add a parameter like function dashboard_show_block_content($module, $delta, $info = FALSE)?
and then

if ($info) {
  $module_blocks = module_invoke($block_object->module, 'block_info');
  $block_info = $module_blocks[$block_object->delta]['info'];
  print $block_info;
  exit();
}

after the DB query

imo that would introduce a big WTF :(

Gábor Hojtsy’s picture

FileSize
25.81 KB
Failed: Failed to apply patch. View

Rerolled the latest patch with latest HEAD, since there were some significant (and numerous) deltas when applied. Also, added three lines to make the dashboard play nice with the overlay. The latest overlay patch includes an overlay_regions[] info file key possibility, where themes could define what regions should be displayed in the overlay. This is altered by the overlay module and here too to add the required regions to make our code work. Now works well with the overlay. Tested customization, saving, etc. It all resizes and everything, so looks to be a nice combo.

@yoroy: on the top level dashboard link, it might stay there but move to the left end. People repeatedly expected something on the left end to "go home", and the dashboard is supposed to be a king of home page for the admins.

Gábor Hojtsy’s picture

FileSize
26.47 KB
Failed: Failed to apply patch. View
33.68 KB
48.97 KB
15.45 KB
29.26 KB

Worked on solving yoroy's concerns:

- moved dashboard to the start of the top level IA (it became the "admin home" as discussed above):

- made the customize button an action link instead (not so sure about this, since it does not behave at all like other action links)

- used taller placeholders for the disabled blocks, removed the useless header on the drawer now that we have help text too and used a different background instead of the same dashed borders; also moved in the Done button (and kept it a button) to the top right of the drawer

Note that the current layout is slightly odd/faulty when you have more placeholders then the width of the screen. We can solve this by more margin below the Done button or some other way. Before working that in, I'd look for more feedback on this improved drawer though.

Also note that due to how the drawer is now a whole, the mechanics with the Done button were moved into the finish callback of the Ajax load(), so it was renamed to setupDrawer().

Finally, not sure why the testbox missed the previous patch, but lets hope it will pick this one up.

Feedback as always is welcome.

yoroy’s picture

Status: Needs work » Needs review

bot?

jolos’s picture

Just a minor remark: when you change the administration theme, your blocks seem to disappear. ( When you change back to seven, they appear again ).
This is unexpected to me. I know this is due to the way blocks work, when not used on the dashboard you do want blocks to depend on the theme.
I don't think this is solvable in an easy way. Luckily It's not annoying, just unexpected, but still I thought it would be worth mentioning.

te-brian’s picture

First of all, this is looking great. I've installed with the latest patch and played around with it and I'm really excited about what this could mean for my clients. I haven't had a chance to dig in a see how it works yet, but I have a quick question.

What is the mechanism, if any, for filtering which blocks are available as dashboard blocks?

SeanBannister’s picture

sub

Dries’s picture

Status: Needs review » Reviewed & tested by the community

I tried this patch and it looks great. It works well, and looks great.

It would obviously be great to have some useful blocks installed by default but we can do that in follow-up patches.

I'm marking this RTBC, and will proceed to commit this. Once committed, I suspect we'll have people follow-up with refinements.

yoroy’s picture

Status: Reviewed & tested by the community » Needs work

This works quite well indeed. One thing that is not good enough imo is removing blocks from the dashboard. You have to find a small hotspot to the right of the list of available blocks in the dark bar (tray) above to be able to remove a block from the dashboard. Can it be made to remove blocks by just drag-releasing outside of the two regions or does it have to be dropped back into the tray?

I agree other refinements can be handled in followups.

Bojhan’s picture

How can this be committed? I am sorry for beign late here but I thought we where just getting started. We said follow ups on shortcuts, we said it on the admin theme and we said it on cck ui. Its not happening to a sufficient UX quality and the most critical part of this page - is not the technical ability to make a dashboard. Its the actual widgets themself.

Even if you take somewhat of a objective look, you can see this is far from something we can present to our users.

1. No widgets are designed.
2. You drag a block into place, I still have to click done? Do people get that? In the context of block administration its meaning something completely diffrent.
3. What do these dotty lines mean? I can´t drag blocks in my blocks administration.
4. The interaction does not scale? I can easily have 15/20 blocks here.
5. Customize? Is it that important? Probally is now, but wouldn´t be for a normal users.
6. What user problem are we solving? What is the user goal?
7. How do we create consistency among widgets?

I think personalisation is the worst thing we can do if its not thought trough enough. You can see it clearly with wordpress, where they worked inmensly on their dashboard - the ammount of custimzation real users do is minimal. Right now, we are basicly forcing every user to customize his dashboard? That is not what I want to be confronted with the fist time I turn my head into the administer area. This is diffrent from the toolbar or the theme, this is adding actual new functionality that is critical to a given workflow.

I am really making a stand here, because I think this is ridiclious. Its untested, its far from done, and the UX is wonky at all places.

ksenzee’s picture

I agree that the dashboard itself could still use some work, but I thought #569190: D7UX: Dashboard contents was for hashing out the actual widgets. We can't come up with smart defaults until we have smart widgets to default to. And having the dashboard structure committed might help motivate people to work on the widgets.

I'm not sure I agree that the interaction needs to scale better. The more widgets you add, the more difficult the customization gets, but to me that's a feature, not a bug. Nobody should have 40 dashboard widgets anyway. Maybe I'm not seeing your point though.

Re the dotty lines: those were "designed" by developers. Suggestions very much welcome. :)

Dries’s picture

@Bojhan, not all of these issues need to be tackled before this patch can be committed. I tried the patch, it provided real value to me and it was intuitive to me. I think you're exaggerating.

Bojhan’s picture

Why would I be exaggerating? This is the first time, I call something out - I didn´t do it on CCK UI or anything that has gone in so far - UI wise half broken. I spend 6 months last year working on Dashboards, finding the good KPI´s and other material - comming up with good widgets is not an easy job, saying thats follow up stuff, not to important to fix now? Then your missing the whole point of having a dashboard.

I fundamentally disagree that a Dashboard that requires customization to work for you, is a good direction. I understand power users love this, but normal users will not care.

@Dries Sorry, but that it is intuitive for you - is not my worry. Whether it is intuitive for normal users is - thats why I am involved in Drupal right? I do not think this will be intuitive for users, and I do not think - that turning the actual contents of this page into a followup will be a worthwhile strategy.

@ksenzee I hope so, we said that for CCK UI and it didn´t happen. This is I believe even a thougher job then the CCK UI. I think you are seeing my point, you should not have 40 widgets. But sure as hell many modules, will add a widget to that list. But since we don´t know the actual contents fo this page, its a hard case to make. There have only been 5 comments on the actual widgets, I dont think its really living.

yoroy’s picture

Typical example of framework vs. product. Should core only (wait to) commit changes to the framework that have a good enough implementation in the default CMS product? (I can't tell if the code is framework-worthy of course).

I would agree with Bojhan that the current implementation is far from ready, especially to take it's place at /admin.

The widgets that could live on this should have been part of this discussion earlier and more foccussed on, but making them part of this actual patch is an even less feasible approach. It's not like we've had much succes with monster UI patches so far. I'm thinking about how to move forward a bit more.

SeanBannister’s picture

I noticed on the dashboard page it says "Drag and drop dashboard widgets to their place", from a consistency perspective I feel this should read ""Drag and drop dashboard blocks to their place". Otherwise we're introducing a new concept called "Widgets" which will further confuse the end user when they actually learn about blocks. The reason I bring this up is the last few posts all refer to the blocks as widgets.

RobLoach’s picture

In the past, I've used Panels to create an administration dashboards for my users. Could we get this up and running on the Dashboard project page so that we could branch off a bunch of this issue queue into separate discussion threads? It might make the workflow a bit easier considering all that this patch is adding.

Bojhan’s picture

@yoroy I agree, its not neccairly a way to move forward - maybe thats the whole point. We are ignoring the big ass elephant in the room - just putting the problem to tomorrow. It is indeed just not ready for /admin yet, if we should fix that in this issue or in the other it doesn´t matter - but the user problem/goal should be adressed, not a piece of functionality. I think we have learned enough from last years, that introducing untested, not worked out features late in the process - creates an inconsistent and unusable interface (and remember, this is one of the first thing a user will see - it is that first impression)

catch’s picture

Category: feature » bug
Priority: Normal » Critical

I agree with sean on blocks vs. widgets - let's not repeat 'categories' here.

I haven't seen any issues about which blocks will be put into this interface at all - or at least not apart from a couple of d7ux microproject ones with no recent activity. So I fully agree with Bojhan that committing an empty interface with absolutely no idea what should go in it is a bad idea. However it's not going to be practical to create any new blocks here either - each one will take some discussion in and of itself.

So if it doesn't exist already somewhere, let's open a meta issue for dashboard blocks (which could probably handle patches adding certain ones by default too), and then open sub-issues for any blocks which don't exist yet - just re-opened #337947: Correct whitespace issue for 'recent content block' in dashboard since the block itself would be a useful one to have available. Note I haven't tested the patch here yet though or reviewed the code recently, but while I think followup issues are OK still, we're definitely at a point where they need to be mapped out very, very clearly. As far as I'm concerned this issue itself is a 'followup issue' since it's a massive gaping hole in the current toolbar and admin/config IA. Also changing category and priority, since this is the only current proposal we have to replace the horrible and confusing mess of /admin vs. /admin/config at the moment

yoroy’s picture

yoroy’s picture

Issue tags: +dashboard

tag

Gábor Hojtsy’s picture

@Rob Loach:

In the past, I've used Panels to create an administration dashboards for my users.

Erm, I have not seen a simple user focused interface for panels which would be applicable. If you consider power users then it might work for them, but probably still not easy for a simple thing like a dashboard.

Could we get this up and running on the Dashboard project page so that we could branch off a bunch of this issue queue into separate discussion threads? It might make the workflow a bit easier considering all that this patch is adding.

That dashboard project is a *user customized* dashboard with *custom widgets*, while this patch is a *globally/site customized* dashboard with *blocks as widgets*. Not much to do with each other.

@yoroy/@Bojhan/@catch: I share concerns about the list of blocks possibly being too long and creating usability problems. Ideas would be welcome to limit the blocks shown for dashboard placement.

@Bojhan: one of the reasons that the dashboard is being worked on is to augment the new IA and provide a clear solution for people who consider that having a plain summary/"menu" of items they care about is better then going into deep areas of the IA one by one. Mark called the dashboard a "big shortcut bar" previously, analogous to the toolbar's shortcut bar in that it would help cherry pick items from the complex maze of a Drupal administration tree.

amc’s picture

I don't know the intricacies of the dashboard, but if the contents (blocks/widgets) are interchangeable, that is, if dashboard widgets can be used as blocks for the main site and blocks can be put as-is on the dashboard, then I see no reason to introduce another concept like "widget". If, however, they can only be used in one place or the other, then perhaps having a different name for each might make the distinction clearer.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
23.85 KB
Failed: Failed to apply patch. View

Updated patch attached:

- removed system.module and system.api.php hunks which did not apply anymore due to the same fix being applied via some other patch (yay)
- renamed widget to block (there was only that one single mention of the widget word in the whole patch)

SeanBannister’s picture

It's interesting that it only took one mention of "Widgets" in the UI to influence our terminology.

I was just thinking about how we could limit the suggested blocks the user sees when clicking "customize". What would happen if it was a region called dashboard_suggestions. Then effectively the user is dragging a block from dashboard_suggestions and dropping it in either dashboard_main or dashboard_sidebar. We can then place suggested Dashboard Blocks in dashboard_suggestions and Contrib Modules can also do the same.

Gábor Hojtsy’s picture

@SeanBannister: that would require some thinking as to how a custom block is added to the available dashboard blocks. Let's say you'd like to embed a google analytics stat or a map or just add plain instructions. What is the user workflow of adding a custom block to the dashboard then? Currently, you create the block and it is available. (You still need to know that just creating a block makes it available, but clearing up the terminology probably helps there).

SeanBannister’s picture

@Gábor: Good point, I original forgot about the end user who might want to create a new block or add an additional block (such as a View) to the Dashboard.

So I'm thinking, once the user clicks "Customize" and dashboard_suggestions is displaying lets display a "More" link in the bottom right hand corner. When clicked it would display all Disabled blocks, this makes it easy to add any block to the Dashboard (such as a View) but keeps them out the way so it's not to confusing for the end user.

If a user wanted to create their own block the simplest workflow is:

  1. Create block
  2. On the Blocks page drag the block to dashboard_main or dashboard_sidebar

Or the less likely workflow (but one you might follow if setting up a list of suggested blocks for a client):

  1. Create block
  2. On the Blocks page drag the block to dashboard_suggestions
  3. On the Dashboard click Customize and select the block
seutje’s picture

FileSize
22.27 KB
Failed: Failed to apply patch. View

replaced this line (in dashboard.js), which doesn't do anything (filing a patch to jquery UI docs as well) cursorAt: 'left', to this cursorAt: {top:0},, which causes the item being dragged to snap to the cursor

not sure if this is the proper way to do this, as the jquery ui docs could use a polish

Dries’s picture

Is the dashboard useless without good blocks? Yes.

The current patch does not come with blocks, which is on purpose. This is a chicken and egg problem. We need to have a starting point before we can effectively start to define useful blocks. This patch provides an initial framework. Hopefully we can have a couple of solid blocks in core, but better yet, hopefully we see a whole slew of contributed modules that introduce dashboard blocks.

When I put on my short term thinking hat, I agree that this patch isn't ready because it doesn't provide you a true dashboard experience.

When I put my long term thinking hat on, I think this patch could already be an enabler because it will lead to a dashboard experience. It might take several months, or even several years, but eventually it will.

For now, the Dashboard could only be accessible from the toolbar or somewhere else. It shouldn't be the default ?q=admin yet. Would that make you feel more comfortable?

Bojhan’s picture

@Dries So if its not good, we pull it out? Who defines "not good" ? In my long-term thinking hat, this patch provides a initial framework - but nothing more. The whole user experience is again, less important then bringing a new feature in for possibilities sake. We are here to guard the user experience, by saying - the good UX will come out over a few years, sounds very visionary but you can probably understand that kills a little bit of me every time. Because as soon as it goes in any improvement we can make to its UX will take years as well (because everyone grown accustom to it's broken UX).

I don't know why I am fighting so much for keeping this out, but if this was a Database restructuring, a scheme change - anything, it would be far more thought trough. Why is it always, for UX we try to fix it after - even while we never did fix it after?

Anyways, lets see if we can adress the issues raised.

Dries’s picture

Bohjan, I'm open for alternatives but I don't see any emerge or anyone stepping up to do the work. Not having the feature seems worse to me.

As for the database restructuring, fields API, filter system rewrite, etc -- all of these came together in a series of patches. Not a single one of them was accomplished in 'big bang'-style. In all cases, there was a significant initial commit, but it always took x more patches to get it right.

sun’s picture

1) I agree with Bojhan's reasoning. This patch, as is, is like adding DBTNG without adding it.

2) I agree with Dries' reasoning. It's ready when it's ready.

3) I expect this patch along with some other UX patches to be committed slightly before or directly on Oct 15. The entire Drupal core development will mainly focus on usability and performance afterwards. And I expect that we will see quite a couple of further "usability exceptions" in that phase.

Mind you, core is basically *locked* for usability and performance patches then. That makes a difference.

catch’s picture

Maybe we don't make this the default for /admin in the initial patch, but we need something there fast, otherwise we're left with reverting admin/config.

Dries’s picture

We have so much proof that the old ?q=admin is bad usability, that they only path, is a path forward.

I'll continue to listen to people's input but soon, I'll have to make a decision. Right now, I think that the "header + shortcut bar + configurable dashboard" is better than ?q=admin, and will continue to become a lot better over time. The old ?q=admin is a death end so we need to backtrack and start with a new foundation.

The current best path forward is this patch (in combination with some of the other UX work). There might be a much better path forward, but that hasn't emerged yet. We can only wait for that to emerge so long. In absence of a better path forward, we'll go with what we have and iterate on it.

Hopefully, together, we can make some decent progress on this the next couple of weeks.

Gábor Hojtsy’s picture

@SeanBannister: simply displaying a "More..." link which would load the rest of the disable blocks came to my mind as well. The problem is that it can be very possible that the block you just added will not show up there in the first items. Ideally we'd also have a link to add a block to the dashboard directly on the dashboard, so the user could jump to add a block and then back to position it on the dashboard, to short circuit the customization possibilities. That might be as simple as a link in the description on how the customization is done.

Any other architecture issues found besides missing more useful default blocks?

yoroy’s picture

FileSize
304.79 KB

talked a bit more in IRC with Gabor about two things:

1. Do we want to limit the blocks that are available for dashboard placement? Seems like we do. I understand there's acces control issues there, but the high-level stupid easy answer would be to have a checkbox somewhere on a block's config page that says 'make available for dashboard'.

2. How to set up the UI to handle a possible very long list of available blocks.
Attached sketch considers a 1 column, scrollable box with draggable blocklets to the right side. Has a 'Add blocks' link underneath that takes you to the blocks page, where you could configure a block to become available (or be removed from) the dashboard through a checkbox.

(what would be really nice is that you could make the 'add to dashboard' selection on the block listing page itself. What if the blocks page knew it was requested by the dashboard config screen and show checkboxes next to each block in the list? Bulk operation style…)

Ask if you have questions or suggestions about the sketch!

Gábor Hojtsy’s picture

FileSize
24.08 KB
Failed: Failed to apply patch. View
38.44 KB
33.64 KB

In reference to @yoroy, worked off of @seutje's patch to try and make up a scrolling list of available blocks first. I did not move it to the right side, as it would make the dashboard width jump from actual use to editing. Let's discuss that.

Also, added a 100px margin on the right end, so the list of available blocks do not go into the Done button.

Comfortable block listing with enough space:

Do not have enough space, so it goes scrolling:

Let's discuss whether it is a good idea to make it scrolling this way. Should it be a high palette instead?

BTW I've also added an add new block link. That unfortunately points to a Garland themed page (which is related to the fun of theme switching on the blocks page, which is discussed to be removed at #581118: Blocks admin user interface should not do theme switching).

yoroy’s picture

Related note: I propose a minimal list of must-have blocks for a useful default dashboard here: http://drupal.org/node/569190#comment-2103146

Gábor Hojtsy’s picture

Also noticed that no-content blocks cause some problems. I dragged in the recent comments block, but I have no comments. Now when I click Done and/or go back to customize the dashboard, this block is not anymore visible in any of the UI. We should display a "closed state" for these blocks I guess.

amc’s picture

What about a carousel (like at http://sorgalla.com/projects/jcarousel/examples/static_simple.html) for the block list?

seutje’s picture

FileSize
22.53 KB
Failed: Failed to apply patch. View

CSS tweaks:

  • removed all margins around the Done button, aside from the left margin to make it seem less offset, but since we're trying to put the top of the button on the same line as the top of the <p>, I'm affraid it'll still look offset, as the text "Done" is a lot lower than the text inside the <p>
  • removed top and bottom margin from #dashboard #disabled-blocks .section and put it on #dashboard #disabled-blocks as padding, because #dashboard #disabled-blocks .section has a fixed height, which will bork with some browser's (non-existent) box-model
  • changed the margin-right on #dashboard #disabled-blocks .section to an em value to account for text-only zooming
  • changed #dashboard .disabled-blocks.ui-sortable to #dashboard #disabled-blocks .ui-sortable as not all browsers support double class selectors
  • removed redundant .block-placeholder margin definition as it got overriden a few lines down anyway
  • removed !important from #dashboard div.dragging as it kills kittens and makes themers go bald

also, what's the reason for this?

#dashboard #disabled-blocks h2 {
  white-space: nowrap;
}

this will lead to a horizontal scrollbar if the content of a disabled block is too wide, if we remove that, it won't cause a horizontal scrollbar, but the "block" will be a lot bigger in height, not sure which would be the best way to handle this, if we were to trim the length of the block title, the nowrap would make a lot more sense to me (or is there already a limit on that?)

I know I suck at explaining stuff in plaintext like this, so I'll try to add some screenshots later tonight

Gábor Hojtsy’s picture

@seutje: the reason for the no-wrap is exactly to get the blocks to display the same regardless of their length. Otherwise when the block appears on end of line in the drawer, it would wrap into two lines, so you'd drag a two-part block. Not nice. It did not seem to be an issue given that the block titles will not be as wide to not fit to the screen width (at least not in my mind :).

seutje’s picture

FileSize
115.49 KB
126.27 KB
122.57 KB
117.88 KB
77.37 KB
55.17 KB
77.37 KB
54.16 KB

screenshots
@Gábor: see nowrap screenshots, but that's outside the scope of this issue

-> #570780: Curtail Seven widths ?

seutje’s picture

FileSize
81.11 KB

wrong withoutnowrap1, but the point is that in that case it doesn't wrap, it only wraps without nowrap when there isn't enough room for the entire block

SeanBannister’s picture

@yoroy #108: I like the idea of having a checkbox that says "make available on dashboard" on the block configuration page. But the reason I prefer a region that contains the suggested blocks is it makes it so much easier to add and remove multiple blocks from the suggested Dashboard blocks. This would be the case if you've just created a site for a client and you want to customize the suggested list you could be moving a lot of blocks. I do however realise it seems a little less intuitive.

Dries’s picture

I recommend that we start with the MV (minimum viable) and that we add extra bells and whistles (e.g. a checkbox on the configuration page) as follow-up patches.

amc’s picture

Checkbox is a good idea. Hopefully modules will be able to specify dashboard availability (or not) when they set up blocks. Minor point: I recommend we use "Make available for dashboard" because using "on" makes it unclear whether checking the box adds it to displayed blocks or simply adds it to the dashboard pool.

David_Rothstein’s picture

Having worked on this patch earlier, I've been following this issue silently for a while, but here are some thoughts:

  1. I don't understand how a "make available for dashboard" checkbox would really work - wouldn't it conflict with the region selector that is already on the block configuration page? (In other words, what does it mean to make a block available for the dashboard if that block is already being used in a different region and therefore isn't available for the dashboard?) Overall, I think this kind of extra step could get very confusing in some situations.

    I also think we are solving the wrong problem here. It isn't the number of blocks available on the dashboard that is the problem (we have to design for the possibility of a large number either way), but rather the ordering. When I do a search on Google, I can get 18 million results, but that isn't a problem because the most relevant ones are presented first. Same thing here. I think we should look at using block weights (which are already user configurable) or other simple forms of ordering/grouping to provide a sensible order for the disabled blocks that puts the most potentially interesting ones for the dashboard at the top of the list, where the user will see them first.

    I also agree with Dries that it doesn't seem critical to solve all of this right now.

  2. What I do think is critical to solve now is some kind of strategy or recommendation for how contributed modules should design blocks for the dashboard. Regardless of what blocks get added to core, contributed modules are going to provide the really neat ones that make this feature shine. Looking at the mockup in comment #1 at the top of this issue, there is an interesting issue - it shows a recent comments block that is nicely designed for an admin dashboard, but different from the recent comments block core already provides. What's the best way to handle something like that? Two different blocks, or a single block with a configuration option that controls how it is displayed? I think contributed modules will likely face similar issues, and for the sake of consistency it would be good if we could give them some guidance on best practices.
  3. Can we push all discussion of ?q=admin to a separate issue? It doesn't seem related to this patch, but deserves its own issue (if it doesn't have one already).
  4. Gábor in #111: See #565642: "Recent comments" block is completely hidden when no comments are available for the problem with the empty recent comments block, although I suppose the larger issue is that any empty block will do the same thing. I agreed that some kind of "empty block" state with an appropriate message makes sense for when the dashboard is being configured.
Gábor Hojtsy’s picture

@seutje: Yes, maybe the markup for the disabled blocks changed enough that it does not wrap into two lines when on the end of line. It used to wrap like this without nowrap:

Recent comment | Administration
links | Who's online

Where "Administration links" was one disabled blocks. So you could drag it from the end of the first line or the beginning of the second. Not nice. Looks like this does not happen anymore with the current markup.

@David_Rothstein: On (1), blocks can only have one weight per theme, which is initialized by the weight set in the block info hook as far as I know / remember. Are you sure that weight as in relation to the dashboard is then fine as default weight as in relation to the live site? On 2, 3 and 4, we agree :)

Gábor Hojtsy’s picture

The blocks page theme switching WTF which caused problems with the "add new block" link on the dashboard now has a patch at http://drupal.org/node/581118#comment-2106588

Dries’s picture

I haven't verified this yet, but David's comment in #120 suggest that if a block is already on a theme region, it can no longer be on the dashboard -- and vice versa. That sounds like a bug to me and suggests to me that the dashboard regions shouldn't be regular theme regions.

David_Rothstein’s picture

Dries: See discussions above starting at #14, also #28-#30. If it's not a theme region, I'm not sure we'd have an accessible fallback for configuring these without drag-and-drop?

Gábor: My thought on that was that weights for disabled blocks don't mean a whole lot now anyway. We'd be forcing the order of available/disabled blocks to be the same on the dashboard page as on the main block configuration page, but if a block is really cool and useful for the dashboard, it's also likely really cool and useful for other places too, right? If not, then something like @SeanBannister's idea of a separate "dashboard disabled" region whose blocks appear first in the list would be the natural extension, but only if we really feel like it's needed.

seutje’s picture

attiks’s picture

I'm with Dries (and others) on this one, please make sure we can re-use blocks on the dashboard, I like the proposal of Seutje, but does this mean multiblock should go into core?

catch’s picture

Allowing blocks to appear in multiple regions is the target of #257032: Split block $ops into separate functions and is notably somewhat enabled by #430886: Make all blocks fieldable entities which introduces a {block_instance} table. Let's fix that problem properly in one or the other of those issues (or via multiblock) rather than adding cruft here.

Dries’s picture

Ok, let's proceed with this patch, and worry about the blocks system refactoring later in #257032: Split block $ops into separate functions.

Dries’s picture

Reading up on the issue again, it sounds like none of the issues raised by David in #120 are blocking. I think we all agree that we need to look into them, but the general consensus seems to be that they add cruft to the issue at this stage.

bensnyder’s picture

subscribe.

Gábor Hojtsy’s picture

FileSize
25.48 KB
Failed: Invalid PHP syntax in modules/dashboard/dashboard.css. View
77.91 KB

Two things were broken in the previous patch due to latest changes in how regions are themed:

- region theming; the dashed lines appeared two times around the regions (there was an intermediate region wrapper)
- saving any dashboard changes; again, due to that intermediate region wrapper, the id we placed on our region parent was not found, so the right region names were not passed on

I worked to fix these and worked on two issues with missing information on the dashboard:

- blocks with missing titles (such as the powered by Drupal block); I've added code to find these and add a @todo title there; as discussed above, we are not sure yet what kind of title we should display there; we could obviously gather the admin block descriptions from the block info hook, if we have no better idea

- missing blocks due to missing content (such as recent comments block on a fresh site); I've added code to print "Content not available" in these blocks and again given them a @todo title. For the title, we can display the description again (see above). For the content, we might not actually need that, but in that case, we'd need some kind of alternate title theming for empty blocks - suggestions welcome;

This is how it looks ATM with the "titleless" and "contentless" blocks added:

Also note here that we cannot effectively/easily place our placeholder equivalents for missing blocks into the order where they are supposed to be placed due to how weights are recalculated for blocks in block rendering. We could alternatively support rendering empty blocks via some other switch in block module, but I am at loss of idea on how could we make it do that without knowing about dashboard, which would then be a cross-dependency.

David_Rothstein’s picture

As per discussion above, we certainly need to deal with point 2 of #120.

Since it's not totally clear that we'll wind up having block instances, it seems most flexible to make the standard be that modules are encouraged to create new blocks rather than trying to add lots of complicated configuration options to existing blocks to make them more dashboard-friendly. I'd suggest we go with that.

I'm adding a similar comment to #569190: D7UX: Dashboard contents so that core can hopefully start setting a good example here.

catch’s picture

Fully agreed with #132. I'm always surprised when I see actual configuration options for a block, and usually wish the configuration form was the views UI when I do.

Gábor Hojtsy’s picture

FileSize
26.12 KB
Failed: Failed to apply patch. View
73.54 KB

Updated patch attached:

- uses a local $block_info[] cache to cache hook_block_info calls per module
- this is then used to fill in titles for blocks which lack a title normally and which are not even displayed normally
- the no-content block display was made more compact (now precedes title with "(x)" and has no displayed content, but a div to let themers put in some kind of special styling there)
- in practice it turns out that sinking down empty blocks to the bottom works in that they go out of your way and let you concentrate on the more useful stuff, while still knowing this was there but had nothing to display

Still looking for feedback obviously.

seutje’s picture

yay, block_info awesomeness!

I don't know about the sinking to the bottom, this could potentially cause some really odd things

if a user drops a block in a certain position, I think he assumes it'll appear at this position, even when it's empty
what about the more dynamic blocks, who can be empty at one point, and then ajax in some new content as it is getting produced

not sure if that last example would ever occur in the wild, and if it would be a big inconvenience or not, but I just think ur making a big assumption here (not saying it's a bad assumption per sé, I'm just a bit iffy about assumptions in general)

Gábor Hojtsy’s picture

@seutje: such blocks should not exist, since Drupal would not normally render any of their wrapper/content markup anyway, so they'd have no place to inject Ajax :) We need to do some special hoops here to get something displayed of those blocks even :)

Gábor Hojtsy’s picture

FileSize
26.11 KB
Failed: Failed to apply patch. View

Jacob Singh tested the patch and found a bug with disabling blocks. Attached patch fixes that.

JacobSingh’s picture

Status: Needs review » Needs work

Seems that when I add one block, it works, when I add the second one, all of the content in all the blocks disappears and I get a jquery error:

"Node cannot be inserted at the specified point in the hierarchy" code: "3"

I think I also figured out why it is happening. If I drag a block in very slowly and wait for it to show me where it will be dropped, it will always work, if I drag it in really quick and just drop it, it will work sometimes.

Also, as a UX note, it takes awhile to get it to show where it will drop it.

Hope that helps debugging it, I don't know where the problem is exactly.

Sexy interface :)

Block Creation issue:
When I click the "add a custom block" link and fill it out, when I submit, I get this:

The block has been created.
Warning message
The block Blah was assigned to the invalid region -1 and has been disabled.
I'm guessing this has something to do with admin_theme / non-admin_theme?

Also, I end up on the admin/structure/blocks page, when it would make more sense to end up back at the dashboard with my new block available to me.

Gábor Hojtsy’s picture

Jacob: agreed on the block creation redirection, working on that. However, your block creation warning comes from a different patch that was committed, so I propagated your feedback there: http://drupal.org/node/503782#comment-2127414

Gábor Hojtsy’s picture

FileSize
115.69 KB
26.7 KB
Failed: Failed to apply patch. View

Jacob: worked on the new block adding workflow:

- renamed the Ajax callback to be admin/dashboard/drawer and made this naming standard in the JS (which was already a mismash of drawer and customize :) - now the mode is called "customize" mode and the disabled blocks palette is called the "drawer"
- so this freed up admin/dashboard/customize to point to the same dashboard but enable the customization by default (vs. admin/dashboard)
- then added a destination to the link we have to the blocks page, so you get back to the instant-on-customize version of the dashboard, when adding a dashboard block via this interaction
- you also get feedback of your block here on this screen as a result of how redirection works

Thanks for the tip. I believe this interaction is much better for adding dashboard blocks now.

Leaving needs work for the drag and drop issue, for which I'm currently at a loss of ideas unfortunately.

JacobSingh’s picture

Status: Needs work » Needs review
FileSize
25.7 KB
Failed: Failed to install HEAD. View

Okay, this was a brutal debugging session, and I didn't quite find the problem, nonetheless, I think this solves the problem.

This should at least gag the error when you try to drag too fast. It seems that this only happens when you drag to an incorrect area with a block that contains no content.

I've thrown in a conditional to abort regenerating the content if that is the case. We may want to get to the root of the issue.

Also, there was an error where you could drag the blocks to any .region, but really we only want them to drag to #dashboard .region. I fixed this as well.

Apologies if the patch is a little screwed up, I got thrown a few times while re-rolling for #572618: All theme functions should take a single argument to make preprocess sane and meaningful.

paul.lovvik’s picture

Status: Needs review » Needs work

Found a problem.

Click on the "Customize" link, and within the dashboard editor if you click the "add a custom block" link, and add the block you are returned to the url 'admin/dashboard/customize', which is necessary to return to the same place, but results in the "Done" button not exiting the editor because the done button simply causes a reload.

paul.lovvik’s picture

FileSize
27.21 KB
Failed: Failed to install HEAD. View

The patch looks good other than the issue I raised earlier. I have created a fix for that and fixed a minor spelling mistake as well.

webchick’s picture

Status: Needs work » Needs review

Taking this for a spin...

Also escalating to needs review so that testing bot can have a crack at it.

webchick’s picture

Here's my initial review, UI-only, not code. Note that I have tried to remain as ignorant as possible as to what's been going on in this issue, so that I can give it a totally fresh set of eyes. Apologies if any of this was already mentioned above; I'll read the issue once I'm done here.

First of all, after enabling the module on an existing install, I get this, which is not at all user-friendly:

Welcome to NOTHING.

It initially looked like an error until I noticed the tiny link within the sea of white. It looks like the install profile adds a couple of blocks here, so this page isn't glaringly empty, but that doesn't help anyone upgrading from Drupal 6 who is installing this for the first time.

I know the UX team in general is against horribly verbose help text, but if we had some logic like:

<?php
if ($there_are_no_blocks) {
  return
t('This page provides a customized dashboard of blocks with various displays of your site's status. You currently have no blocks enabled. Click <a href="@url">customize</a> to continue.');
}
?>

...that would've helped me out quite a bit.

The next thing I tried to do was a test of how this feature would work when a typical site with 30+ contributed modules was used. I added the following to a hook_block_info():

<?php
 
for ($i = 0; $i < 50; $i++) {
   
$blocks[$i]['info'] = "Dummy block $i";
  }
  return
$blocks;
?>

This results in the following:

I think this is reasonable. It would probably ideally be better if the available blocks were categorized somehow, but then you get into Yet Another Way For Contrib To Make A God-Awful Mess Of Your Site With Its Own Hap-Hazardly Made-Up Categories. The div scrolls, so it looks like it can handle the 50-100 blocks it's going to need to on a typical site.

However, the fact is that block blocks and dashboard blocks are in the vast majority of cases not the same thing. At all. I defy someone to think of a reason why "Syndicate" ever belongs in the admin dashboard. Not to mention my dummy blocks. :P

IMO, a block in hook_block_info() should have to explicitly opt-in in order to be seen here, and core should provide as few of these as possible, and only when they make sense, in order to establish a good pattern for contrib. Contrib will obviously add more dashboard blocks to choose from, and there is always hook_block_info_alter() for switching on the Syndicate block if you really want it for some reason. :P We'll need to do this opt-in switch in a generic way that does not assume the presence of Dashboard module. Some sort of flag like 'admin task' => TRUE or something, maybe? This could then perhaps be used in additional contexts apart from merely the dashboard, although I'm not quite thinking of any off-hand.

Also, there really ought to be some kind of ordering here. Why is Recent comments before Administration shortcuts?

Moving on...

Blank

Dragging/dropping these blocks doesn't seem to actually do anything, and furthermore there are no outlines or anything to tell me where I'm allowed to put them. This is leading me to believe either the patch is currently broken, or else my environment is, although I've cleared my browser cache and the Drupal cache to no effect. Hrm.

So I'll obviously need to give this another go once I figure that out. :P

Hmmm. I notice though that I can drag "Dummy 1" in front of "Dummy 0" in the list. However, once I click "Done" it does not retain my settings. Sad panda.

"Add a custom block" shoots me over to Garland. WHAT HAPPENED TO MY WORLD?!!??! :P However, this is something I happen to know is being handled in another issue, to remove the "preview blocks page in the current theme" setting (or I think so anyway). This would be good, since this time-warp behaviour is incredibly jarring. Also, we just got done teaching a theming workshop where this came up again as something that confuses the living hell out of people. But anyway, that's not for this issue. ;)

That's about all I can test at the moment, unfortunately. A natural question to come up would be "How far does this have to go until it's considered commit-worthy?" My gut feeling at the moment is:

  • I'd like to see the couple minor issues pointed out above (weighting, lack of 'welcome' text) fixed. Should take 0.03 seconds a piece. If it takes any longer than that, kick to "Polish" phase.
  • Obviously, I need to be able to drag and drop blocks. :D There will probably be more bullets in this list once I get to that point. I'll try a fresh install after this and see if I have better luck.
  • I'd really feel a lot better about this patch if the opt-in mechaism for blocks was part of it. The page is unruly atm, and a bit of a UX nightmare with so many choices that make absolutely no sense. However, this has serious bike-shed potential, and we don't have the time. I'd love to spend the weekend brainstorming about this, and if it's not resolved by Monday, then I guess we can kick it to the "polish" phase.
  • A rich library of useful widgets can come after 10/15, and in fact the "polish" phase is for exactly this kind of work. But that said, I would love for this patch to set the initial direction on what kind of blocks are and are not appropriate here, with a couple of examples from the existing set (for example, "Recent comments", "Who's new", etc.).
webchick’s picture

Ok. From a fresh install, this looks a heck of a lot better. :P~ It'd be nice to figure out why it fails so badly when you enable the module from an existing site, and stop it from doing that. :D

This looks like a bug (and a scope creep feature request while I'm thinking about it ;)):

Management menu

Apart from that, this seems to work quite well! Tested in both Firefox and Safari.

One other thing I noticed is that lots of these have no content. It'd be nice to label them as such as so it doesn't look like a bug:

empty blocks

One last thing to consider I guess is that this "Customize" link paradigm is "yet another way to edit stuff on a page." Assuming we get #473268: D7UX: Put edit links on everything in, it'd be nice for everything to go through the same standard mechanism, methinks.

webchick’s picture

(Sorry, just posting stuff as I find it)

Also, I appear to lose the ability to drag in a block to the dashboard if it's already assigned to a region in the current theme. I put "Who's online" in the content region and it no longer appeared in the list.

I guess this patch doesn't solve the issue of multiple block instances.

EDIT: but this one does! #430886: Make all blocks fieldable entities

webchick’s picture

This is what I'm getting when I try and test this with Garland as my admin theme:

Garland

Same behaviour as my initial experience having not gone through default.profile.

Futzing more, I discovered that if I go into admin/structure/blocks and drag in a block to the dashboard thin region (or whatever it was called), NOW suddenly it appears and I can put stuff in it.

The fact that these regions vanish when there isn't any 'starter' content in them seems like a bug to me. I think it would lock people out of this feature if they removed all blocks to "start over", with no obvious way to un-break it.

JacobSingh’s picture

Okay, so @webchick and I talked on IRC about all of these. Here is the list (AFAICT of outstanding issues):

Stuff we have to fix before committing

1. We need to make sure that there is something in empty dashboard regions so that they can be dragged into.

2. Bug Dragging the "Management" block up to the drawrer. You have to take it way up to the top left, debug and fix this.

3. Upgrade experience: New proposal - In the case of an empty dashboard, show some help text (see above) and open customize by default. So we don't make assumptions with default data on upgrade, and we provide a clean way to educate users how to start.

4. Show (no content) in the body of empty blocks instead of the (x) in the title.

Stuff we absolutely must fix before release

1. Garland is broken in terms of JS and CSS.

Stuff which would be good to do

1. An opt-in setting for blocks, we know this has been discussed above ad naseum - but the block weight alone will not suffice when you start introducing a ton of contrib modules to the mix.

2. Actually fix the real problem of #257032: Split block $ops into separate functions

-- This post has been approved by the webchick and is sponsored by Lavazza Coffee, an introverted attitude, The Day Saturday, and Issac Hayes - You damn right - can you dig it?

webchick’s picture

LOL @ Jacob. The only thing I'd adjust from that is "would be good to do" is really "we really need to do, but not in this patch."

Whew! caught up on the issue now. :) What a whirlwind. ;)

Some random things that caught my eye as I was going through:

  • I understand Bojhan's concerns. Unlike CCK UI, which only a site builder is ever going to see something with a sub-optimal user experience, this admin panel is going to be /the/ jump-off point for *all* semi-privileged users of Drupal. It's our "first impression" if you will, regardless if it replaces ?q=admin or not, due to its prominence (and also its name). Because we aren't catering default.profile to any particular use case, we also can't decide on a set of default blocks that really make sense here. As a result, this is something that everyone is going to have to futz with on any new Drupal site they build, to get things looking just right. The UX here will be directly tied to all users' feeling of success/happiness with Drupal.

    Yet, at the same time, there is no way to argue against the point Dries makes about incremental improvements being the backbone of how Drupal core work gets done. For example, the only way we were able to finish the D7UX work done so far is by incremental changes (heck, the IA was moved over one. menu link. at. a. time. ;P). Even something as simple as a patch that renames a couple of functions often results in several follow-up issues to fix bugs, or pick slightly more optimized names, or what have you.

    It is a chicken/egg problem, to some extent. Ideally, we would want to design this feature with prototypes, put it in front of real users/clients, acquire some feedback on what the most frequently accessed administration tasks are, etc. Yet, until the interface is actually there in core for people to poke at, we're in "theory land" and will never reach the critical mass of people we need participating in how to smooth these rough edges, and I think we'd all do better if this responsibility did not fall entirely on the D7UX team's shoulders.

    Can I guarantee that we won't see a repeat of "yeah, yeah, we'll fix that later" and then we don't? No, unfortunately, I can't. But I would like to echo sun's statement that there is a BIG difference between coming out of code freeze into a 6-week window for developers to push in additional API changes (which is what happened 9/1) and coming out of code freeze into an /actual/ code freeze, with an entire month dedicated solely to UX/documentation/etc. polish, which is what we're planning on for 10/15.

    In summary, I'm pro-committing this sooner than later, and taking the risk. I think the potential benefits are huge, and I'm hopeful that the focus time for UX we've designed into the release schedule can help get some hands on this stuff once the API-changing parts are in.

  • I realize I am just one user, and a developer-y one at that, but I was totally confused by the (X) and had to ask Jacob what that meant. I'm looking for the block content in the block content area, not in the title. (no content) or (empty) or something in the actual content area would be preferable.
  • It's funny that weighting was seen as the solution to the issue of too many blocks; I thought it was a bug that R was coming before A. I'm not sure this paradigm works. We have a UI for weighting (drag and drop) that clearly shows a relation of first/second/third... among a group of items. This UI bears no such relation. IMO, limiting this list of blocks is a critical issue.
  • I still think the page output at /admin is useful, but as more like an admin/index or admin/sitemap or something rather than a "Welcome to Drupal! Here is a GIGANTIC RAT'S NEST OF LINKS." But at any rate, this is not to be decided in this issue.

Here are the critical bugs, UX-wise, at least from my view. I agree with Dries though that these can happen in follow-up patches, if required, though my preference would be to get at least a general rough plan of attack for solving them before this gets committed. I'll be back in here on Sunday night, if not earlier.

  • EDIT: The list of blocks needs to be limited down, IMO. Since this /will/ require some kind of API change to hook_block_info() [unless someone has better ideas], it would be best if we sorted it out in this patch, assuming we can do so without too much bikeshedding. yoroy's suggestion of a checkbox to mark a block as "show in the admin dashboard" sounds quite reasonable, but that can happen in a follow-up issue, unless it's easy.
  • Additionally, core should be leading by example, so that contrib can follow suit. We need to develop a some kind of guidelines on this. This might already be done in #569190: D7UX: Dashboard contents; I haven't made it quite that far yet.
  • The dashboard vanishes when you switch themes. This is a hold-over from the way blocks work (and in general I'm +1000 on re-using the block API here), but is terribly confusing. I saw this issue mentioned a few times, but didn't see any solutions discussed. Do we need a hook_theme_enabled() / hook_theme_disabled()? Or should this act on hook_block_save() and make the same changes to all enabled themes? Or..? If we can come up with something relatively simple, this seems like a bug we should fix in this patch.
  • You can't physically drag into block regions that contain no content. This seems like a bug we should fix in this patch, because it results in totally broken functionality for people not installing Drupal for the first time.
  • EDIT: Oh yes. And that terribly confusing behaviour about not being able to re-use a block that's used in another region. For that, we need the concept of "block instances" which is covered in #430886: Make all blocks fieldable entities.
  • EDIT: You're jetted off to the front-end theme for creating a block. Addressed in #581118: Blocks admin user interface should not do theme switching.
  • EDIT: We need to come up with a strategy for what dashboard blocks core ships with, which ones are there by default, and what the general guidelines are around recommended/not-recommended blocks, for contributed module authors. This is being hashed out in #569190: D7UX: Dashboard contents, but could use some help/direction. I'm going to make this a priority post-10/15.
seutje’s picture

@149

2. -> I think this is due to the center of the snapping point being in the center of the size of the block you are dragging, prior to dragging. I haven't been able to find a way to change the position of this snapping point in a proper jQuery UI sorta way, and simply making the block position:absolute and moved with it's center snapping point onto the cursor just prior to dragging seems extremely hackish and dirty.

Dries’s picture

A-w-e-s-o-m-e review, webchick.

David_Rothstein’s picture

Agreed, awesome review :)

  1. It's funny that weighting was seen as the solution to the issue of too many blocks; I thought it was a bug that R was coming before A.

    Although you'd have to be a mind-reader to know it, I intended to suggest weighting as a solution only when combined with a design that showed content for disabled blocks in addition to the block titles - which is what I thought was intended by the design in #108, but looking again, probably isn't :) In that case, the focus would be on browsing through the available block content, not on the alphabetical order.

    Either way, it's probably true that that is trying to overload a bit too much information onto the disabled block weights, and a sharper distinction is necessary.

  2. In that case, using hook_block_info() to distinguish the dashboard blocks definitely makes sense, but we may need to discuss the proposed UI a bit, since it might affect how/where/if that data gets stored. For example:

    yoroy's suggestion of a checkbox to mark a block as "show in the admin dashboard" sounds quite reasonable

    I'm still not sure how that would work. Doesn't that setting only have any meaning if the block is disabled? If the block is already assigned to a dashboard region, then it doesn't need a checkbox, whereas if it's already in some other region, then it isn't available for the dashboard at all (unless the block instance thing happens).

    I'm worried that this checkbox would cause confusion with the "region settings" selector that is now on the block configuration page and which is itself a gigantic usability improvement (or will be once it isn't hidden in a collapse fieldset where no one can see it...)

    So, I still think we should consider something like @SeanBannister's idea instead. In short, the dashboard module would just add a "Disabled (dashboard)" block region and leave it at that. We'd still use hook_block_info() to provide defaults, but might not need any special storage for this information -- the dashboard module could probably just collect it and use it whenever a new module is enabled, to assign the correct blocks to "Dashboard (disabled)"...

Bojhan’s picture

To adress some of webchick's concerns on the UX.

1. Limiting this list of blocks
I believe we introduced a lot of blocks just to test how the Dashboard would work, I think we can sufficiently say that there is one major issue which is the amount of blocks. To continue with these blocks is obviously not a good strategy since it sets the expectation that they will stay. So I think best thing to do is, pull a number of them out of the list already - and only leave a couple for testing purposes. Let's use #569190: D7UX: Dashboard contents for the discussion on which one to introduce, and pull most of the others out here already.

So removing :

  • All menu's
  • They are unlikely to consist links that are helpfull on the Dashboard, some of them are already in the toolbar.

    • Administration schortcuts
    • Navigation
    • User menu
    • Main menu
    • Secondary menu
  • Syndicate
  • Seems somewhat much, for just one RSS feed url?

  • Powerd by drupal
  • Highly unlikely you want this as a widget on your Dashboard

Part of this is fixing the interaction that allows blocks to show up in the Dashboard blocks pane. I strongly disagree with David_Rothstein his perception that users will understand to drag a block into Dashboard on the blocks page. The whole concept of the block page breaks down, if we add this. We should not mix the two, whereas yoroy his suggestion of adding a checkbox seems far more valid.

Adding we need to create a better interaction in the pallete, it does not scale - and I think having a larger number of dashboard blocks available will be an viable use case. However I think its best to split that part up into a followup issue.

2. Guidelines for blocks
I will work on the guidelines for blocks on the Dashboard, as webchick explained this is critical to the experience we want to offer these users. #569190: D7UX: Dashboard contents - This is best served not as a follow up.

3. Editing, removing blocks
We need to add a Configure and Remove icon/link to every single block when you are in customize mode. This will be in line with expectation, so I would like us to follow that. This can be a follow up.

4. Loading when block is dropped
When I drop a block in a region, I have a short waiting time as AJAX puts it in? I am kind of left guessing what happends in that mean time. Again can be a follow up.

I hope someone can write a patch, there are almost 10-15 small changes that have a very strong impact on UX - and only require little code. As of now, the state of this patch in terms of UX is still pretty bad.

David_Rothstein’s picture

I strongly disagree with David_Rothstein his perception that users will understand to drag a block into Dashboard on the blocks page.

When did I ever suggest that they would need to do that???

Bojhan’s picture

Sorry I understood from "In short, the dashboard module would just add a "Disabled (dashboard)" block region and leave it at that." that you suggested that interaction. Can you clarify - because the blocks page would have a new region, but that wouldn't be used? I am not sure I am following.

David_Rothstein’s picture

Sure, no problem :)

The attached screenshots show the blocks administration page and individual block configuration page with the latest patch applied (the only addition due to the patch being the two "dashboard" regions).

For the individual block configuration page, my concern is about how a "show on dashboard" checkbox would interact or conflict with the dropdown selector? If someone makes it to this page with the intention of putting a block on the dashboard, their quickest route is just to use the dropdown selector directly anyway - they can put it right on the dashboard without having to go through an intermediary step. That's true in either approach. So the checkbox doesn't add much but rather gets in the way and conflicts with what the reality might be. The approach I'm advocating would add something like "Dashboard (disabled)" to the dropdown list - which also gets a bit in the way, but much less so.

Similar thing for the block administration page - there, "Dashboard (disabled)" would appear, but you wouldn't usually want to use it directly.

Conclusion: There are problems with both approaches, because in both cases, we're adding something to the blocks UI that - by the time people find their way to the blocks administration pages - they rarely will ever want to use. So some fresh thinking might be good here :) But if we have to go with one of the two approaches, I'd prefer the one that fits in better with the way the UI currently works.

Dries’s picture

I think the approach suggested by David in #157 is Good Enough For Now. As suggested in a number of comments above, the real solution requires more work: see #257032: Split block $ops into separate functions and #430886: Make all blocks fieldable entities.

catch’s picture

I've opened #601932: Allow dashboard to limit available blocks to discuss this further, and added another possible solution for tackling this.

Bojhan’s picture

I believe that the approach of #157 will confuse the user, since we are mixing Dashboard with actual site design. Which are two completely diffrent concepts. From Dries his comment, I understand that we will change this but not now?

JacobSingh’s picture

@Bohjan: Yes and no. We may or may not change the fact that the dashboard sections are regions, but we will change notion that a block can belong to one and only one region.

This allows for UI changes to make the distinction you are talking about.

JacobSingh’s picture

Status: Needs review » Needs work

Okay, I'd like to try to keep this on the critical path to a commit. So I'm only stating the issues here which I understand from @webchick and @Dries to be commit blockers (not release blockers):

from #149 and #150

Stuff we have to fix before committing

1. We need to make sure that there is something in empty dashboard regions so that they can be dragged into.

2. Bug Dragging the "Management" block up to the drawrer. You have to take it way up to the top left, debug and fix this.
http://drupal.org/node/544360#comment-2134902 might be the cause

3. Upgrade experience: After an upgrade, there are no blocks in the dashboard.
New proposal - In the case of an empty dashboard, show some help text (see above) and open customize by default. So we don't make assumptions with default data on upgrade, and we provide a clean way to educate users how to start.

4. Show (no content) in the body of empty blocks instead of the (x) in the title.

in addition, there are some non-blockers which are important
These are outlined at the end of #150, but the main ones are:

A. The dashboard vanishes when you switch themes.

B. Limit the list of blocks. #601932: Allow dashboard to limit available blocks

C. We need to come up with a strategy for what dashboard blocks core ships with. #569190: D7UX: Dashboard contents

I suggest we just focus on 1-4 until we get this committed and iteratively improve the experience in the specified follow-ups. I'll be posting a patch today that should address 1-4.

Best,
J

JacobSingh’s picture

FileSize
26.54 KB
Failed: Failed to install HEAD. View

Okay, screens and/or video to follow.

This fixes #1, 3 and 4 AFAICT

2. Bug Dragging the "Management" block up to the drawrer.

Is still in play.

This does need some love perhaps in terms of making the (empty) messages customizable by overrides, but it is a start. Try it!

Empty out both regions and go to the page Before: Broken, cannot add blocks to regions and you don't know what is going on because you can't see them.
Now: Each region shows "This dashboard region is empty, click customize to add blocks to it." and it goes to customize mode automatically. I just realized this is retarded, when in customize mode it should say "DRAG HERE"...

Add an empty block like "Navigation"
Before: (x) in the title, looked weird.
Now: (empty) in the body.

Drag it back out
Now: The region shows the "I am empty message as I mentioned above.

JacobSingh’s picture

Okay, I found a couple problems in my approach, please lay off this one unless someone can fix #2. I'll post another patch soon.

-Shaman-’s picture

Why not simply use this module - it has everything, is customizable, doesn't take the whole page to display the stuff, and is sexy http://drupal.org/project/admin_dashboard

Gábor Hojtsy’s picture

@-Shaman-: you'll be able to use that on your own sites, but we are aiming at a less power-user centric dashboard here. Also, we already have the shortcuts implemented by that module as a separate feature in the Drupal 7 toolbar.

JacobSingh’s picture

FileSize
27.76 KB
Failed: Failed to install HEAD. View

Okay, should be a much better approach to the placeholders.

I didn't pay attention to language here. Needs recommendations. Here is a video:

http://www.vimeo.com/7023967

int’s picture

Status: Needs work » Needs review
JacobSingh’s picture

FileSize
1.46 MB

Vimeo screwed the pooch. I don't know why. Here is the .mov.

webchick’s picture

I'm headed to bed here pretty quick, but #169 looks great, and looks like it addresses all of my feedback related to those parts. I actually don't even mind "DRAG HERE" that much, and the exact wording here could be something we tweak in a follow-up.

This looks like it might be commit-worthy now, given the follow-up issues are created, but I'm up way past my bedtime so will need to look tomorrow (or most likely Wednesday since I'm actually going outside tomorrow night). Dries, if you want to do the honours first, feel free.

Status: Needs review » Needs work

The last submitted patch failed testing.

Dries’s picture

Status: Needs work » Fixed

I agree that it is ready enough for the initial commit, and that we best break this up in several follow-up issues.

Committed to CVS HEAD! Wo-hoot.

Please create new issues for follow-ups. Thank you.

Still needs a CHANGELOG.txt issue!

David_Rothstein’s picture

Status: Fixed » Needs review
FileSize
986 bytes
Failed: Failed to apply patch. View

Oops, as per the testbot, that kind of broke Drupal...

Here is the fix that gets installations working again. I have no idea if all tests still pass, of course.

Status: Needs review » Needs work

The last submitted patch failed testing.

ksenzee’s picture

Status: Needs work » Fixed

Fix patch was committed before testbot got a crack at it. Fixing status. See you folks in the followups.

Bojhan’s picture

Status: Fixed » Needs work
chx’s picture

Title: D7UX dashboard module » D7UX dashboard module is totally against all Drupal principles
Status: Needs work » Active

Did we just rush in a dashboard module that has a very useful drag-and-drop stuff and is totally unreuseable? What happened to building a reusable framework and putting a product on top of it?

agentrickard’s picture

I'm with chx on that, especially since we already spec'd a reusable Dashboard module for contrib, including a pluggable hook_dashboard() to define new instances. And that module hasn't gotten any community love since DCDC.

seutje’s picture

it's actually rather reusable as an in-page block region editor, but I take it that wasn't really what you meant

Gábor Hojtsy’s picture

@Dries' spec called for a specific implementation, while we have all of jQuery UI for the use of developers with all kinds of fun drag and drop, on top of which dashboard module is a very thin wrapper.

merlinofchaos’s picture

FYI, this patch has stolen the namespace of an existing module that it is not related to.

This was a bad idea. Very bad idea. I don't see that there was any discussion, at all, of the namespace. Please stop treating contrib like it doesn't exist. Drupal would not exist without contrib.

cweagans’s picture

In this particular instance, I think that having -a- Dashboard for the Drupal site is alright. While it kind of sucks that it's not super reusable like everything else in Drupal, I think that having only one dashboard is going to simplify things a lot. And besides, if you need another 'dashboard', why not just install Panels?

Dries’s picture

The namespace issue is unfortunate -- nobody cared to check for it, including myself. The people working on the "contributed dashboard" module didn't chime in either, which is odd given all the attention core's dashboard module has received. It's an oversight of everyone involved, including the non-core developers.

Fortunately, http://drupal.org/project/dashboard has no releases yet, and is specifically designed for drupal.org as part of the Drupal.org Redesign process. The contributed dashboard module has been under development for 12+ months too. Either way, we can work out the namespace issue -- that is not a problem.

Either way, we should expect core's dashboard module in core to evolve. Like anything else in Drupal, it is not set in stone, and like many other things in Drupal, it could take various iterations to get right. That has been true for almost every system in Drupal core. So think of it this way: we gave birth to a dashboard module in core, but it certainly will have some growing up to do. That doesn't mean it isn't already useful to a lot of people. I also expect a new 'ecosystem' of dashboard module blocks to emerge in contrib, which could be really great but it will most certainly take a while before we'll be able to get real value from the dashboard. Bootstrapping ...

agentrickard’s picture

So my question would be: Is it too late to make this implementation extensible?

webchick’s picture

IMO, what we're after with this patch is a paradigm shift for module developers to start thinking of how they can expose their modules' data in ways that are more immediately useful to site administrators. This paradigm shift will have ripple effects throughout all of contrib, and I'm quite sure that contributed modules such as Panels, Super Dashboard, etc. will put this into good use.

It's true that core's default implementation is very simple, and not nearly as flexible as something like Panels or the contributed Dashboard module, but this is true of most core features. Our core Forum module has nothing on Advanced Forum either, in terms of functionality. Yet, it works for people with modest needs, and serves as an example implementation for others to build from, and something we can work to improve upon in later releases.

CCK in core was once just the ability to add content types, which is arguably not very useful at all by itself, especially when compared to its potential. But it provided the baseline we needed to expand this out to the concept of things like fieldable entities, making several core concepts such as Taxonomy into fields, etc.

agentrickard’s picture

@webchick

So, then, your proposal is to rename the contrib module and develop it separately as a 'better' version?

Otherwise, here's a quick list of the features that we would need to merge the two approaches:

1. Separate dashboard widgets from the block system
2. Abstract hook_dashboard() for the following:
  a. path definition
  b. region definition(s)
  c. access to view permission
  d. access to configure permission
  e. CRUD permissions
  f.  Available widgets
  g. Available layouts/regions
3. Create widget registry system
4. Create layout registry system
5. Make the 'add widget' element more usable:
   a. Configure by dashboard type
   b. Search for widgets
   c. Allow icons for widgets
6. Data abstraction and storage in {dashboard} tables.

[Note: on current HEAD, I am unable to add blocks to the dashboard at all, OS X FF 3]

webchick’s picture

Making widgets a separate concept from blocks was already discussed earlier in the issue and the approach was turned down. Instead, we have a follow-up issue for #601932: Allow dashboard to limit available blocks. Most of the other items in your list are rendered moot because we re-use the existing access/visibility controls given to us already by the blocks system.

A pluggable layout system would've been absolutely nifty, but unfortunately wasn't completed by anyone. I think that'd be a great example of a way to expand on this in Drupal 8, though.

Gábor Hojtsy’s picture

@merlinofchaos, @Dries: I've discussed the dashboard namespace conflict with the maintainer of the contributed dashboard module, Niel Drumm in Paris and he had no problems whatsoever. The fact that this was not documented on the issue above does not mean it did not happen.

David_Rothstein’s picture

First, this:

/**
 * Return an array of dashboard region descriptions, keyed by region name.
 */
function dashboard_region_descriptions() {
  $default_regions = array(
    'dashboard_main' =>  'Dashboard main',
    'dashboard_sidebar' => 'Dashboard sidebar',
  );
  return variable_get('dashboard_region_descriptions', $default_regions);
}

It was always intended to become something like hook_dashboard_regions() rather than a variable - not sure why it didn't :).... Making that a hook would allow modules to define their own dashboard regions (and the patch already has a facility for automatically finding theme functions for those regions), so the dashboard itself can be made to look however you want it. That should be pretty simple to change.

Also, this:

/**
 * Implement hook_page_alter().
 *
 * Display dashboard blocks in the main content region.
 */
function dashboard_page_alter(&$page) {
...
}

Seems like it should become hook_page_build(), which would further allow modules to change things via hook_page_alter(). Also easy to change.

Now obviously, this implementation of the dashboard relies heavily on blocks, so it does not support displaying or dragging arbitrary objects on the page. Given that blocks are core's way of managing page regions and implemented by tons of modules, it doesn't seem outlandish to limit it to that - and that's the direction the issue has been going in for a couple months now. Whether it could be made more flexible via some last minute work (assuming there are people willing to do that) seems hard to say, but the module is pretty small and really only has a couple places where things happen:

  • dashboard_admin(): This at a minimum should be returning an array rather than an HTML string containing divs in it :) In that way, the help text and JS are at least easily swappable.
  • dashboard_show_disabled() and dashboard_update(): Seems like it would require some thought, but they could invoke hooks as well.
  • dashboard_show_block_content(): That seems like it might be much harder.

There's a couple other things in the code that look like they need some cleanup, but that can wait until later.

agentrickard’s picture

hook_dashboard() is hardly moot. If it's out of scope, fine, we'll (try to) solve it in contrib.

The problem with using the block system is as follows.

If you have an extensible system that allows, say, a configurable dashboard element for every user, how do you store that in the blocks system without overwhelming both the block and the dashboard UI?

Let's take d.o. as an example. Let's say we want a dashboard widget to track recent posts by user. (There are what, 250,000+ users?) How does the block system handle that? Pass a hidden argument to the block render?

The problem is that the sheer number of widgets (one per RSS feed, one per term, one per user) can quickly overwhelm the Block UI. So I am arguing that you _must_ use a separate storage engine. Otherwise, this module in core will not be extensible in any useful way.

[Update: block placement is working for me now, I think I had a brain fart.]

Gábor Hojtsy’s picture

@agentrickard: again, this issue is not everything for all; the goal here was not to have per-user dashboards, so that was not how it is implemented. Of course if we'd have per user dashboards, why wouldn't we have "per-page dashboards" (AKA Panels)? You see, we need to draw a line to get something reasonable implemented, and it was not drawn at the place you'd have expected because the goals were different. The extensibility goals of this dashboard is not to be a generic front end dashboard to scale to hundreds of thousands of users but to be extensible and extended with useful **site monitoring and administration** tools. We could have set all kinds of different goals up to getting Panels into core, but we did not.

David_Rothstein’s picture

I wonder if it would help to rename this from dashboard.module to admin_dashboard.module?

Like Gábor said, that is all this was ever intended to be. A generic user dashboard is great but (as can be seen from the discussion above) quite complicated, and not necessarily something that makes sense for Drupal core.

***
EDIT: Of course, if I had the read the comments above more carefully, I would have realized that http://drupal.org/project/admin_dashboard already exists also :)

agentrickard’s picture

@gabor

Right, I get that. But I am opposed to single-use modules in core. Core should be extensible. As implemented, this will never be.

I think the whole concept is better left to contrib.

@David_Rothstein

All the good names are taken. So I have no better options for you. Though the namespace is used in CVS, so a rename might be better. Maybe 'Admin Panel', which is available?

@webchick

In general, I'm just frustrated by the lack of time I personally have to pay attention to these things. This is an issue I have already architected _twice_, and simply haven't had time to get written for D6. To see a feature crippled version in D7 just makes me sad. But I'll get over it ;-p.

Gábor Hojtsy’s picture

@David: not sure, the toolbar is not named admin_toolbar.module either.

@agentrickard: I think @sun nicely summarized on other d7ux issues that we should build on what core has instead of reinventing our own ways of doing stuff. Core could have two parallel concepts of block-like things which can be placed in region-like things, but instead of making up our own ways, we went with blocks, given that their limitations fit the model. Another good point @sun makes is that (in core), instead of building up parallel systems, one would extend and fix what is there and this is happening in issues cross-linked above. Issues like permissions, visibility, translations, fieldable blocks, block instances to reuse a block in multiple regions on possibly multiple pages, etc. are all solved or being actively worked on for Drupal 7. We could build up a parallel system and then need to solve the same problems or build on what we have (especially since it fit our model very well) and let contrib use the existing and rich extension mechanisms. Yes, it is not infinitely extensible, and many aspects of its extensibility might not be solved in this issue.

Crell’s picture

The problem with simple, single-use, not-reusable modules in core is that: 1) They make doing a properly extensible version in contrib harder a lot of the time, due to namespace conflicts in code, conceptual overlap that confuses people, etc. 2) They encourage more single-use, not-reusable modules on the grounds that "well core does it, so it's OK!". No, it's not OK, it's a bad model to encourage and to follow. Always design for extensibility. To do otherwise, especially in a highly dynamic environment like Drupal and web development, is to waste time in the long run because you have to hack stuff to pieces to extend it or just start over.

webchick’s picture

Title: D7UX dashboard module is totally against all Drupal principles » D7UX dashboard module
Status: Active » Needs work

#189 looks like some decent implementation clean-ups that could probably be done relatively quickly. Would one of you folks have some space to work on this over the next couple of days?

Also, restoring title and status.

David_Rothstein’s picture

FileSize
6.99 KB
Passed: 13454 passes, 0 fails, 0 exceptions View

Here's a patch that gets started implementing the basic cleanups from #189, but it isn't working right now... the JS customization of the dashboard no longer works correctly, and I'm not sure why - no time to debug further at the moment.

***

It's strange, in general I completely agree with the idea that Drupal should be an extensible framework (and that some of the D7UX stuff isn't appropriate for core for that reason) - but here, I totally disagree. Complaining about things like the toolbar or overlay or shortcuts being in core I would certainly get, but this? I don't think so.

Like @webchick said, it's pretty simple. We want contrib modules to define administrative widgets for Drupal and to do so in a consistent way. They aren't going to do that if those widgets don't actually get displayed anywhere. So, the solution is to put a dashboard in core.

And just because it's in core doesn't mean it has to be a hyper-extensible thing. I really don't think we want some kind of "Dashboard API" module in core - that wouldn't make sense. A dashboard is a user interface, and user interfaces aren't supposed to be frameworks, they're supposed to use them. Drupal core already has a framework for managing the content of page regions, and we're using that in this patch. If you're saying that that framework needs improvement or replacement so that it is more extensible, no one would disagree, but that's way out of scope for this issue. Someday, if the core blocks system ever manages to support per-user blocks (for example), then right behind that, this dashboard module will easily support per-user dashboards also, but not before then. It was absolutely the right way to build it.

seutje’s picture

FileSize
8.92 KB
Passed: 13455 passes, 0 fails, 0 exceptions View

Looks like we somehow lost the inner-wrapper which has the margins on it and which was being checked for content by the following:

    if ($('#dashboard .region .block').length == 0) {
      Drupal.settings.dashboard.launchCustomize = true;
    }

this caused the dashboard to always think it was empty, and thus always triggered the launchCustomize

so I added an inner wrapper with classes "region" and "clearfix" to the theme function, which makes it look rather silly:

function theme_dashboard_region($variables) {
  extract($variables);
  $output = '
'; $output .= '
'; $output .= $element['#children']; // Closing div.region $output .= '
'; // Closing div.dashboard-region $output .= '
'; return $output; }

the way this theme function was originally, didn't make any sense to me, as it only added a .region div when there were no elements, yet it tried to add them anyway...

main reason it wasn't working anymore was because it was looking for .region, which only existed in the #disabled-blocks div, as the other .dashboard-regions had lost their inner .region wrapper (which we might want to rename to "inner-dashboard-region" or something, just to avoid clashes with certain themes)

Gábor Hojtsy’s picture

Looked through the patch and the only thing that did not make sense for me is why we duplicate access checking in the menu item and the dashboard_admin() build callback.

On @seutje's concern about regions, I'd say that reusing the region classes would let people theme this admin page similarly to other admin pages, so that does not sound like a bad thing. Also, it lets us not reinvent markup on top of regions and blocks, but reuse the existing core pattern instead.

seutje’s picture

FileSize
10.28 KB
Passed: 13438 passes, 0 fails, 0 exceptions View

changed

      for (i = 0; i < blocks.length; i++) {
        order.push(region + '[]=' + blocks[i]);
      }

to

      $.each(blocks, function() {
        order.push(region + '[]=' + this);
      });

and added some comments to the js, and moved one comment around as a bit of unrelated code got in between this comment and it's related code

and it seems like my geany cleaned up some whitespace

prolly won't be working on this for the next few hours

int’s picture

Status: Needs work » Needs review
int’s picture

duplicated

rickvug’s picture

I found two dashboard bugs in testing today. Thought that I'd paste links here as there is not yet a dashboard.module component.:

#607324: Empty dashboard blocks unexpectedly sink to the bottom without a notice
#607474: Dashboard - block area spacing is off when moving item to bottom

seutje’s picture

Priority: Normal » Critical
Status: Fixed » Needs review

#607474: Dashboard - block area spacing is off when moving item to bottom -> fixed in #198 -> .region wrapper was missing, so there was nothing applying a clearfix

#607324: Empty dashboard blocks unexpectedly sink to the bottom without a notice -> was introduced in #134 and was intentional, but considering this is surprising users already, maybe we should add a notification about it, although I can't think of a way that wouldn't annoy me :P

Dries’s picture

Priority: Critical » Normal
Status: Needs review » Fixed

Committed the clean-ups to CVS HEAD. Thanks!

seutje’s picture

Priority: Critical » Normal
Status: Needs review » Fixed

marked #607474: Dashboard - block area spacing is off when moving item to bottom as fixed and corrected my previous post as I switched around both issues

Gábor Hojtsy’s picture

Component: other » dashboard.module

Added dashboard.module component.

Status: Fixed » Closed (fixed)
Issue tags: -Favorite-of-Dries, -Usability, -dashboard, -D7UX, -Exception code freeze

Automatically closed -- issue fixed for 2 weeks with no activity.