I have been going through and reviewing modules and themes that start with numbers (as a result of http://groups.drupal.org/node/24465). This theme starts with the number '1' both in the project title and the actual download name. This is a problem for two reasons:
1. It is viewed as a blatant attempt to game the module/theme listing which sorts alphabetically by default.
2. Because PHP functions cannot start with numbers, this theme cannot use template preprocess functions. Even if you don't currently implement them, if someone wanted to extend your theme and add preprocess functions, they would be unable to do so.

You will need to create a new folder in the CVS contributions directory. After moving your code to the correct folder, you need to rename your theme's title to match. I can assist with this process as well.

If no action is taken to address this issue within a reasonable amount of time, I will move this issue to the webmaster's queue and unpublish your project. If you have any questions, please follow-up in this issue.

Dave Reid
Drupal.org webmaster

Comments

nickbits’s picture

nickbits CreditAttribution: nickbits commented
Assigned: nickbits » Unassigned

Dave,

I can assure you point 1 is totally irrelevant in this case. If you look at the original authors theme it is simply using the same name. I am amazed that this has not been raised before now as it has been online for some time.

Nick

nickbits’s picture

nickbits CreditAttribution: nickbits commented
Assigned: Unassigned » nickbits
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Assigned: Unassigned » nickbits

Yes I apologize I should have phrased it as "could be viewed as an attempt". I didn't mean to blame you for intentially trying to game the system. There have been other themes where that was the case however.

Once you've created the new project, let me know in this issue and I can mark this project as abandoned and point users to the new project location.

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Dave,

No problem. I should have noticed the pos. problems with php myself, not sure why I did not. Anyway, I have created a new CVS directory ( Andreas1024px ). However using SmartCVS I cannot figure out how to MOVE files from the old folder to the new one.

Is it acceptable to simply upload a new copy of the code, with appropriate changes to the info file and others where required, and make changes to the project settings to point to the new directory?

Nick

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

Just jumping in here with an FYI... Changing directories around in CVS is not a simple thing. All us mere mortals can do is create a new directory and move files and leave the old one there but empty, which probably isn't good for the top level directory. Unless you are really set on a perfect match from directory name to theme name, I suggest just leaving the directory as is and only change the name of the theme.

Michelle

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Michelle

To be honest, I was planning on just moving the files and leaving the old one empty. But my CVS (SmartCVS) program cannot do that, at least I cannot figure it out.

I have no problem which I do, upload new/fresh files to a new directory and update the project page, or just rename the project page.

Dave, can you advise please? Or am I, as comment 3 suggest, creating a new project page as well?

Nick

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

You can't move files in CVS... At least not with the perms non admins have. You have to do a cvs remove and then a cvs add at the new location.

Michelle

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Dave,

I have now made changes to the files as required, created a new folder - Andreas1024px - and uploaded the files. Can you let me know, as I am a little unsure (both suggested above) if I need to (a) create a new project or (b) just update the current project page to point to the new CVS (and obviously update the theme name.

Nick

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

So it appears that I can change the project shortname, but that's going to leave broken links as it also changes the url alias as well. Let's just create a new project page and point from the old to the new.

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Dave,

New project has een created and can be found at - http://drupal.org/project/Andreas1024px - so the old one can now be removed/redirected.

Nick

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

Problem with this idea... If we unpublish 1024px, your 482 users are going to get alarming warnings from update status and come to find the page gone. We can put a note on the page, but then it's still in the listing and we have a duplicate theme. I'm asking the CVS admins for advice. Will report back when I have something.

Michelle

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented
Status: Active » Fixed

Ok, dww pointed out I was missing the obvious. I unpublished the releases not the project page and added a note pointing to the new project.

Michelle

nickbits’s picture

nickbits CreditAttribution: nickbits commented
Status: Fixed » Closed (fixed)

Thanks for the help on sorting this out.

Regards,
Nick

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Project: » Andreas 1024px
Version: 6.x-1.2 » 6.x-1.3
Issue summary: View changes