This is kind of a bunch of small admin UI cleanups that are kind of mixed together.

I was really annoyed that you could submit the form without selecting a module or operation. This makes those values required but for the red * to appear I had to move the title down from the fieldset, and at that point the fieldset wasn't really doing anything so I dropped it.

One other change was to load the proper names for the types so that a user role's name is used rather than the role id.

CommentFileSizeAuthor
activity_admin_ui_fixes.patch8.72 KBdrewish

Comments

drewish’s picture

Oh, $form_state should really be passed by reference. I was doing more with it earlier but pulled that out since it obscured the other changes.

sirkitree’s picture

Status: Needs review » Fixed

All looks good, thank you! Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.