Closed (fixed)
Project:
XML sitemap
Version:
6.x-2.x-dev
Component:
xmlsitemap_custom.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jul 2009 at 09:39 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dave reidAdding as a beta blocker.
Comment #2
dave reidDoesn't make sense to allow custom inclusion/exclusion for custom links, you can just delete them to exclude. Committed to CVS.
Comment #3
scottrigbyI thought the issue was about setting priority on custom links? AFAIK there's no option for this currently?
Comment #4
dave reidIsn't this what you're referring to? There are priority options for individual custom links.
Comment #5
avpadernoIt is possible to set the custom links priority, as Dave reported. About being able to enable/disable the custom links, I think it doesn't make sense to have it for the fact that to create a custom link it's enough to insert the relative URL; differently, if the data requested to create a custom links would be more than now, then I would agree that to have the possibility to disable/enable a custom link would be desirable.
Comment #6
scottrigby@Dave Reid: maybe this is another result of my using the Aug-17th build :) Attaching a screenshot of what I've got. The shot you attached looks like exactly what's missing in mine. I assume with latest code I'll be set - thanks :)
@KiamLaLuno: this makes sense to me - I mean, it's nice that core menu items can be disabled (for example) but I definitely don't think that should be mandatory here. I was mainly concerned about setting priority on custom links, which appears to be solved
Comment #7
avpadernoTruly, the menu settings page present in Drupal allows to enable/disable the menus that have been defined from third-party modules; in that case, it makes sense to allow to enable/disable them because the data doesn't come from a user.
That is not the case of the custom links handled by XML sitemap.
Comment #8
scottrigby@Dave Reid: Yup - latest has the priority option. Thx :)
@KiamLaLuno: ...but users can also create custom menu items, and there is still the ability to disable these custom items too. I see what you mean, however there may be reasons why site users might want to keep a library of disabled items (for periodic or seasonal use, because the site is shared by multiple people and someone may want to propose a change without making it fatal, etc). Not that this is a crucial point... just feedback :)
Comment #9
avpadernoIn that case, you can use XML sitemap menu, which uses links from a menu. Create a menu that you will use to add links in the sitemap; in that way you will be able to disable them, and they will not be included in the sitemap.
Comment #10
scottrigby@KiamLaLuno: we're not able to set XML sitemap menu item priority are we? Just checking.
I guess if anyone cared, enabling/disabling custom xml sitemap links would be a new issue anyway - though I'm personally not concerned about that - just was interested in the idea you mentioned :)
I *would* however be interested in the ability to set 'Change frequency' for custom xml links - which seems doable... (and 'Last updated' woudl be lovely, though I have no idea how we would get the update time).
Comment #12
dave reidKnew this issue was here somewhere, just had to dig it up again.
@scottrigby: Just added 'Change frequency' options to custom links as well with http://drupal.org/cvs?commit=304328. Thank you for the suggestion and I apologize that it got lost for a while. :/