The function css_style_to_array in mimemail_compress.inc assumes there will be no colons in the attribute value, but there can be such in the case of a background-image attribute, for example: background-image:url('http://mysite.com/images/bg_750.gif');
As a result the module currently mangles that attribute.
The code that does this:
list($key,$value) = explode(':',$def);
Could be replaced with:
preg_match("/([^:]+):(.+)/", $def, $matches);
$key = $matches[1];
$value = $matches[2];
Or am I wrong?
Thanks,
Ralph Dosser
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | mimemail.517306_02.patch | 947 bytes | sgabe |
| #2 | mimemail.517306_01.patch | 996 bytes | sgabe |
Comments
Comment #1
tobiberlinAs I think this post relates on what I am facing currently I want to add my subscription to this issue: When I send an email with css-definitions which include background-images with an absolute URL the URL is cut after "http" in the email....
Comment #2
sgabe commentedI can confirm this issue. The pattern looks good, but I would leave the list construct, it is much elegant. :-)
Comment #3
sgabe commentedPlease, ignore the previous patch.
Comment #4
sgabe commentedCommitted to HEAD.