Filter feeds by category uses wrong tables

View:

Hi. I had the task to create a View, that shows feeds from a specific category, but from different sources. However it turned out that views uses wrong tables during the join. As an result at least one feed source was missing.

I made some changes to the views modules, and it seams to work find for me, so far. So here are my changes. Hopefully these changed will made their way to the code, that we may update without the hase of changing code every time.

Here is an export of my View (after the change).

$view = new view;
$view->name = 'news_view';
$view->description = 'News View';
$view->tag = '';
$view->view_php = '';
$view->base_table = 'aggregator_item';
$view->is_cacheable = FALSE;
$view->api_version = 2;
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */
$handler = $view->new_display('default', 'Standards', 'default');
$handler->override_option('fields', array(
  'title' => array(
    'label' => '',
    'alter' => array(
      'alter_text' => 1,
      'text' => '<h1>[title]</h1>',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'help' => '',
      'trim' => 0,
      'max_length' => '',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'strip_tags' => 0,
      'html' => 0,
    ),
    'display_as_link' => 1,
    'exclude' => 0,
    'id' => 'title',
    'table' => 'aggregator_item',
    'field' => 'title',
    'relationship' => 'none',
  ),
  'author' => array(
    'label' => 'Autor',
    'alter' => array(
      'alter_text' => 0,
      'text' => '',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'help' => '',
      'trim' => 0,
      'max_length' => '',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'strip_tags' => 0,
      'html' => 0,
    ),
    'exclude' => 0,
    'id' => 'author',
    'table' => 'aggregator_item',
    'field' => 'author',
    'relationship' => 'none',
  ),
  'timestamp' => array(
    'label' => 'Zeitstempel',
    'alter' => array(
      'alter_text' => 0,
      'text' => '',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'help' => '',
      'trim' => 0,
      'max_length' => '',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'strip_tags' => 0,
      'html' => 0,
    ),
    'date_format' => 'small',
    'custom_date_format' => '',
    'exclude' => 0,
    'id' => 'timestamp',
    'table' => 'aggregator_item',
    'field' => 'timestamp',
    'relationship' => 'none',
  ),
  'link' => array(
    'label' => '',
    'alter' => array(
      'alter_text' => 0,
      'text' => '',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'help' => '',
      'trim' => 0,
      'max_length' => '',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'strip_tags' => 0,
      'html' => 0,
    ),
    'display_as_link' => 1,
    'exclude' => 1,
    'id' => 'link',
    'table' => 'aggregator_item',
    'field' => 'link',
    'relationship' => 'none',
  ),
  'description' => array(
    'label' => '',
    'alter' => array(
      'alter_text' => 0,
      'text' => '',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'help' => '',
      'trim' => 1,
      'max_length' => '200',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'strip_tags' => 0,
      'html' => 1,
    ),
    'exclude' => 0,
    'id' => 'description',
    'table' => 'aggregator_item',
    'field' => 'description',
    'relationship' => 'none',
  ),
));
$handler->override_option('sorts', array(
  'timestamp' => array(
    'order' => 'DESC',
    'granularity' => 'second',
    'id' => 'timestamp',
    'table' => 'aggregator_item',
    'field' => 'timestamp',
    'relationship' => 'none',
  ),
));
$handler->override_option('filters', array(
  'cid' => array(
    'operator' => 'in',
    'value' => array(
      '1' => '1',
    ),
    'group' => '0',
    'exposed' => FALSE,
    'expose' => array(
      'operator' => FALSE,
      'label' => '',
    ),
    'id' => 'cid',
    'table' => 'aggregator_category',
    'field' => 'cid',
    'relationship' => 'none',
  ),
));
$handler->override_option('access', array(
  'type' => 'none',
));
$handler->override_option('cache', array(
  'type' => 'none',
));
$handler->override_option('items_per_page', 100);
$handler->override_option('distinct', 0);
$handler = $view->new_display('page', 'Seite', 'page_1');
$handler->override_option('path', 'news');
$handler->override_option('menu', array(
  'type' => 'none',
  'title' => '',
  'description' => '',
  'weight' => 0,
  'name' => 'navigation',
));
$handler->override_option('tab_options', array(
  'type' => 'none',
  'title' => '',
  'description' => '',
  'weight' => 0,
));

This is the query created by the views module before the changes.

SELECT aggregator_item.iid AS iid, aggregator_item.title AS aggregator_item_title, aggregator_item.link AS aggregator_item_link, aggregator_item.author AS aggregator_item_author, aggregator_item.timestamp AS aggregator_item_timestamp, aggregator_item.description AS aggregator_item_description FROM aggregator_item aggregator_item  LEFT JOIN aggregator_category_feed aggregator_category_feed ON aggregator_item.fid = aggregator_category_feed.fid LEFT JOIN aggregator_category aggregator_category ON aggregator_category_feed.cid = aggregator_category.cid WHERE aggregator_category.cid in ('1') ORDER BY aggregator_item_timestamp DESC

This is a svn diff containing my source code changes. I hope this fixes the problem, while introducing litte or no side effects.

--- htdocs/sites/all/modules/third_party/views/modules/aggregator.views.inc    (Revision 106)
+++ htdocs/sites/all/modules/third_party/views/modules/aggregator.views.inc    (Arbeitskopie)
@@ -272,13 +272,23 @@
   );

   // ----------------------------------------------------------------------
+  // Aggregator category item table
+
+  $data['aggregator_category_item']['table']['join'] = array(
+    'aggregator_item' => array(
+      'left_field' => 'iid',
+      'field' => 'iid',
+    ),
+  );
+
+  // ----------------------------------------------------------------------
   // Aggregator category table

   $data['aggregator_category']['table']['group'] = t('Aggregator category');

   $data['aggregator_category']['table']['join'] = array(
     'aggregator_item' => array(
-      'left_table' => 'aggregator_category_feed',
+      'left_table' => 'aggregator_category_item',
       'left_field' => 'cid',
       'field' => 'cid',
     ),

This is the query created by the views module after the changes.

SELECT aggregator_item.iid AS iid, aggregator_item.title AS aggregator_item_title, aggregator_item.link AS aggregator_item_link, aggregator_item.author AS aggregator_item_author, aggregator_item.timestamp AS aggregator_item_timestamp, aggregator_item.description AS aggregator_item_description FROM aggregator_item aggregator_item  LEFT JOIN aggregator_category_item aggregator_category_item ON aggregator_item.iid = aggregator_category_item.iid LEFT JOIN aggregator_category aggregator_category ON aggregator_category_item.cid = aggregator_category.cid WHERE aggregator_category.cid in ('1') ORDER BY aggregator_item_timestamp DESC