account_reminder.module doesn't limit the number of reminder-emails sent per cron run.
This could lead to serious problems when first activating the module on existing large sites with a large number of registered but never-loggedin users (since then the module tries to send thounsands of email in a single cron run).
Attached patch (against 6.x-1.1) solves this problem by introducing a simple admin-configurable limit.

have fun testing (and committing ;),

daniel

CommentFileSizeAuthor
#2 account_reminder__account_reminder.module.CronLimit.patch3.04 KBdanielnolde
account_reminder__account_reminder.module.CronLimit.patch1.78 KBdanielnolde

Comments

danielnolde’s picture

danielnolde commented

oh bummer, i just realized that limiting just the one sql select in account_reminder_cron fails to almost *ever* handle more than [limit] reminders... since the different account-reminders are not sent from different selects.

HM, any suggestions?

danielnolde’s picture

danielnolde commented
StatusFileSize
new account_reminder__account_reminder.module.CronLimit.patch3.04 KB

i found a better solution to limit only the number of actually sent mails for one cron run, see patched attached.
Also fixes a bcc-not-sent bug.

jaydub’s picture

jaydub commented
Status: Needs review » Fixed

I've added this to the module in a slightly different form. It's been committed along with a number of other changes in the development tree. Please take some time to test out a snapshot if you are able to and let me know if the changes work for you.

jaydub’s picture

jaydub commented

http://drupal.org/cvs?commit=229576

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.