Closed (fixed)
Project:
Version Control API
Version:
6.x-1.0-rc1
Component:
Commit Log
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2009 at 16:23 UTC
Updated:
21 Jun 2009 at 21:50 UTC
I suppose there is a problem on admin/project/versioncontrol-accounts page.
The generated link is:
http://commitlog%3fusername%3dmarco%2520antonio%2520villegas%2520vega%25...
I see 3b3e83ead0aca3edf441746767c129b7561c7386 is the first bad commit(woo git bisect!), but I can not understand the real problem.
Is there a problem?
Comments
Comment #1
jpetso commented3b3e83ead0aca3edf441746767c129b7561c7386.Could you please check if the error is still present on current HEAD?
Comment #2
marvil07 commentedMaybe we are talking about different repos, I see the mentioned comit on you repo.
To reproduce it:
- add a vcs repo
- add an vcs account in that repo
- go to
admin/project/versioncontrol-accounts- see/click user filter link
Comment #3
jpetso commentedYou're right, and I must have done something wrong with grepping the "git log" output. The bug was caused by commitlog_account_url() returning a relative URL instead of an absolute one (which causes l() to generate incorrect links), and that's now fixed too. Thanks for the report!