Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I have a slideshow that shows videos. It will cycle through the videos just fine. However, when a user clicks on the video, and it starts playing, the slideshow will cycle on to the next item, despite the fact that the video is playing. How can this be fixed?
Comment | File | Size | Author |
---|---|---|---|
#12 | thumbnailhover_pause-1.patch | 888 bytes | redndahead |
#8 | 479018-pause_on_click-2.patch | 12.65 KB | redndahead |
#6 | 479018-pause_on_click-1.patch | 6.3 KB | redndahead |
Comments
Comment #1
Matt BSame issue on v6.x-1,0-beta2
Comment #2
redndahead CreditAttribution: redndahead commentedBumping to 2.x this will need to get looked at. Maybe we can pause the slide show when the slide gets clicked.
Comment #3
codycraven CreditAttribution: codycraven commentedI can confirm this for 6.x-2.x.
Pausing the slide show when slide is clicked on sounds like a good option.
Please note that this bug causes the slideshow to be unusable with videos.
Comment #4
redndahead CreditAttribution: redndahead commentedMoving to critical as it's imperative to fix this before release.
Comment #5
redndahead CreditAttribution: redndahead commentedHere is some jquery for me to look at when I get back to this. If someone wants to test this jquery in firebug to see if it works for you then that would be great. You'll need to match the ID's to your slideshow.
Comment #6
redndahead CreditAttribution: redndahead commentedThis patch should take care of it. Would love to hear feedback. It required me to completely override the pause on hover functionality in jquery cycle. The problem was if you had pause on hover enabled and you paused the slideshow on click then move your mouse off of the slideshow it would restart the slideshow because you left the hover. So testing is really important on this one.
Comment #7
redndahead CreditAttribution: redndahead commentedBy the way this adds an option to the settings form to pause on click.
Comment #8
redndahead CreditAttribution: redndahead commentedThis patch was committed.
Comment #10
reflectiondigital CreditAttribution: reflectiondigital commentedThis still isn't working for me. In Firebug I get 'viewsSlideshowPause(settings) not defined' when I click a slide with Pause on Click turned on. Pause on Hover does work.
Comment #11
redndahead CreditAttribution: redndahead commentedWell crap...Simple fix just pissed that it's there.
Comment #12
redndahead CreditAttribution: redndahead commentedHere is the patch. Please post if it worked for you.
Comment #13
redndahead CreditAttribution: redndahead commentedThis has been committed.
Comment #15
reflectiondigital CreditAttribution: reflectiondigital commentedStill got the 'viewsSlideshowPause(settings) not defined' in Firebug until I changed the file contrib/views_slideshow_singleframe/views_slideshow.js on line 109
should be
Comment #16
reflectiondigital CreditAttribution: reflectiondigital commentedAlso, this fix does not work when using Embedded Media Thumbnail when the video view format is set to "Thumbnail -> Preview/Full size video inline replacement"
I think it may be because when the thumbnail is replaced by the embedded video, it's as if a new slide is loaded so pause on click behavior no longer applies and the next slide loads as the video is playing.
Comment #17
redndahead CreditAttribution: redndahead commentedok committed the fix to pause issue. Not sure why it would start up again even if it reloads the slide. It seems there would have to be a call to restart the slideshow somewhere. Can you open a new issue on the Embedded Media Thumbnail issue and post if you have a site that I can look at.
Thank you