Remove search engine authentication/verification code

I just created the first official release of site_verify.

In response to #1, I'd say that if search engines change their URLs, we can always make sure we update the module. Easy as that. :) Yeah, and users can decide when they want to disable/remove the search engine verification module.

Here's the patch to remove all the verification code from xmlsitemap_engines for review.

The only code to change in the module should be the part that shows a static list of 4 entries, and remove the limitation of 4 search engines.

Kiam, you did see that the site_verify has the 'custom' engine to add verifications for any other engines right? And that the custom engine can be added over and over again?

I think it's worth removing since we already have Site verification module.

I would suggest removing all the verification stuff from hook_menu() and the interface, but don't delete the variables (but still delete them on uninstall however). I'm writing an "import" path in site_verify to import any of the variables if xmlsitemap_engines.module hasn't been uninstalled:

function site_verify_import_xmlsitemap(&$ret = array()) {
  if (!db_result(db_query("SELECT 1 FROM {site_verify} WHERE engine = 'google'"))) {
    if ($google_file = db_escape_string(variable_get('xmlsitemap_engines_google_verify', ''))) {
      $ret[] = update_sql("INSERT INTO {site_verify} (engine, file) VALUES ('google', '$google_file')");
    }
    variable_del('xmlsitemap_engines_google_verify');
  }
  if (!db_result(db_query("SELECT 1 FROM {site_verify} WHERE engine = 'bing'"))) {
    if ($bing_file = db_escape_string(variable_get('xmlsitemap_engines_bing_verify', ''))) {
      $bing_content = db_escape_string(variable_get('xmlsitemap_engines_bing_verify_string', ''));
      $ret[] = update_sql("INSERT INTO {site_verify} (engine, file, file_contents) VALUES ('bing', '$bing_file', '$bing_content')");
    }
    variable_del('xmlsitemap_engines_bing_verify');
    variable_del('xmlsitemap_engines_bing_verify_string');
  }
  if (!db_result(db_query("SELECT 1 FROM {site_verify} WHERE engine = 'yahoo'"))) {
    if ($yahoo_file = db_escape_string(variable_get('xmlsitemap_engines_yahoo_verify', ''))) {
      $yahoo_content = db_escape_string(variable_get('xmlsitemap_engines_yahoo_verify_string', ''));
      $ret[] = update_sql("INSERT INTO {site_verify} (engine, file, file_contents) VALUES ('yahoo', '$yahoo_file', '$yahoo_content')");
    }
    variable_del('xmlsitemap_engines_yahoo_verify');
    variable_del('xmlsitemap_engines_yahoo_verify_string');
  }
}

I'd also add this update to xmlsitemap_engines.module:

function xmlsitemap_engines_update_nextnumber() {
  $ret = array();
  if (function_exists('site_verify_import_xmlsitemap')) {
    site_verify_import_xmlsitemap($ret);
  }
  return $ret;
}

Search engine verification settings have been removed in 6.x-1.x CVS (http://drupal.org/cvs?commit=259918). Upgrade path is provided:

/**
 * Deprecate verification functionality in favor of the site_verify.module.
 */
function xmlsitemap_engines_update_6111() {
  $ret = array();
  if (function_exists('site_verify_import_xmlsitemap')) {
    site_verify_import_xmlsitemap($ret);
    if ($ret) {
      // Only show the success message if there were any settings migrated.
      drupal_set_message('XML sitemap search engine verification settings were successfully migrated to the Site Verification module.');
    }
  }
  else {
    drupal_set_message('The search engine verification settings in XML sitemap have been deprecated in favor of the <a href="http://drupal.org/project/site_verify">Site verification module</a>. Your settings will be migrated when you install and enable the Site verification module.', 'warning');
  }
  // Set the menu rebuild flag to remove the XML sitemap engine paths.
  variable_set('menu_rebuild_needed', TRUE);
  return $ret;
}