Now that we have a hook for removing an item from the cart (hook_cart_item() $op = 'remove') it would be nice if this was fired when the cart is expired due to timeout when hook_cron is called in uc_cart module.

CommentFileSizeAuthor
#3 ubercart_cart_expire_2.patch1.4 KBmikey_p
ubercart_cart_expire.patch1.36 KBmikey_p
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented

Or maybe we could make the old 'fast way' an option as well be checking a variable.

Wouldn't have to be in the interface anywhere, could just be something that another module or a site builder could set.

willvincent’s picture

willvincent CreditAttribution: willvincent commented

Big +1 on this, this should definitely be rolled into core.

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
FileSize
ubercart_cart_expire_2.patch1.4 KB

Here's an update from Ryan, no need to run more than once per cart_id ;)

Island Usurper’s picture

Island Usurper CreditAttribution: Island Usurper commented
Status: Needs review » Fixed

OK, finally got around to looking at this patch. Looks like it does the job, so it's committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.