The imagecache_create_url() function calls url() setting $query to FALSE rather than to NULL, this is causing url() to add a trailing '?' in URLs when $bypass_browser_cache = FALSE (default).

Attached patch corrects this.

Note: patch taken from imagecache.module file, since I did this change in SVN of one of my projects in a rush.


riccardoR’s picture

I can confirm that the patch works as described.
I did the same change before finding this issue.

recidive’s picture

Status:Needs review» Reviewed & tested by the community

@riccardoR: thanks.

Setting this to RTBC.

recidive’s picture

Can we get this one liner commited?

drewish’s picture

Version:5.x-2.4» 6.x-2.x-dev
Priority:Normal» Minor
new866 bytes
new871 bytes

realized it was a problem in 6 as well and just back ported the patch i'd rolled for that to 5.

drewish’s picture

Status:Reviewed & tested by the community» Fixed

committed to HEAD and DRUPAL-5--2

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.