Grid doesn't output correct TD's

+1...

definitely should be fixed...

not sure how to do it yet but i'll look now

Here is an initial patch, but it works only for horizontal grids currently.

nice work dereine..works perfectly...i looked at it quickly and couldn't figure it out at first..

thanks

But this does not fix the vertical display of the grid style.

Here is a patch for both vertical and horizontal,

Including the dereine's one :)

looks good...nice work too

But this does not fix the vertical display of the grid style.

damn, there was something in my browser cache since this afternoon.

+++ theme/theme.inc	3 Sep 2009 18:07:11 -0000
@@ -425,6 +432,10 @@ function template_preprocess_views_view_
     }
+    for ($i = 0; $i < count($rows[1]); $i++) {

Why $rows[1] and not $rows[0].

+++ theme/theme.inc	3 Sep 2009 18:07:11 -0000
@@ -425,6 +432,10 @@ function template_preprocess_views_view_
+      $rows[count($rows) - 1][$i] .= '';

I would use only "=" here

I'm on crack. Are you, too?

Sorry for this, you were right :)

+++ theme/theme.inc	3 Sep 2009 20:38:24 -0000
@@ -425,6 +432,12 @@ function template_preprocess_views_view_
+      if (empty($rows[count($rows) - 1][$i])) {

If the item is "0" this will return TRUE and replaced with ''.

This review is powered by Dreditor.

needs work :)

Lol !

here it's fixed !

sorry for useless iterations

Patch seems not to apply, don't know why ...

Here is a patched version ! :p

I would think thats its rtbc, if its not by design ;)

I think tables has to be completed, so fixing this would be good.

.

Committed.

Note ++ is a unary operator and therefore shouldn't have had a space.

Everything works great with this patch besides one thing...

If there is only one row in the grid output, the patch now causes it to add additional empty td's. This is only necessary if there is more than one row.

Better make it active. 'needs work' can be kind of a wasteland if no one is specificly working on it.

I don't like empty cells unless they have an empty class or something to make them disappear from CSS

Is it possible that this could be causing empty cells to show up on grid views? (see attached -- notice the last two cells) Just happened when I updated to the latest views version.

Any fixes to get rid of this? I just want blank space.

Thanks!

yes It does!

I fixed similar issue making a custom views template to not display empty cells.

views-view-grid.tpl.php

<?php
// $Id: views-view-grid.tpl.php,v 1.3 2008/06/14 17:42:43 merlinofchaos Exp $
/**
 * @file views-view-grid.tpl.php
 * Default simple view template to display a rows in a grid.
 *
 * - $rows contains a nested array of rows. Each row contains an array of
 *   columns.
 *
 * @ingroup views_templates
 */
?>
<?php if (!empty($title)) : ?>
  <h3><?php print $title; ?></h3>
<?php endif; ?>
<table class="views-view-grid">
  <tbody>
    <?php foreach ($rows as $row_number => $columns): ?>
      <?php
        $row_class = 'row-' . ($row_number + 1);
        if ($row_number == 0) {
          $row_class .= ' row-first';
        }
        elseif (count($rows) == ($row_number + 1)) {
          $row_class .= ' row-last';
        }
      ?>
      <tr class="<?php print $row_class; ?>">
        <?php foreach ($columns as $column_number => $item): ?>
          <?php if ($item):?>
	   <td class="<?php print 'col-'. ($column_number + 1); ?>">
            <?php print $item; ?>
          </td>
          <?php endif ?>
        <?php endforeach; ?>
      </tr>
    <?php endforeach; ?>
  </tbody>
</table>

IMHO: No displaying empty cells is ok. Firefox don't know how to display these kind of tables, is a firefox bug. But you can fix the borders with some css.

IE and Safari display these tables well.

subscribing

Maybe the best way is to add an option to enable/disable displaying empty cells in the grid style config of the view.

It will be useful to have the both options. Without forgetting to add some kind of "empty-cell" css class to empty cells.

but that's a feature request..

Here is a patch which fixes this

Fix committed to all branches. Thanks dereine!