I just upgraded to 4.5 version of this module and now I see the following bug:
The printer-friendly page link appears twice. One time in <div class="help"> div and one time in <div class="links"> div.
On the Settings page, in "Printer-friendly page link:" section there are only "Links area" selected. (and not "Content corner")
If I switch off "Links area" then no more printer-friendly links appears.
Tested on clean drupal-5.16 install with garland theme.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 435128_extra_help_link.patch | 618 bytes | deviantintegral |
| #1 | add_help_area_selection.patch | 1.51 KB | hapydoyzer |
Comments
Comment #1
hapydoyzer commentedNow I see that it is because
print_helpfunction.It displays additional Printer-friendly link if any of "Links area" or "Content corner" are selected. But why this is needed?
Anyway, here are trivial path that adds ability to switch on/off this link.
Comment #2
hapydoyzer commentedComment #3
jcnventuraThe help area is not intended to show up for normal nodes... If there's anything to fix is why it is activating on normal nodes. I will try to take a look at it, and see if I can fix it.
João
Comment #4
jcnventuraThis was caused by a lack of proper testing of the backport of the fix for #404052: Links on node signup list pages.. The node/% path is Drupal 6 specific and nobody had noticed it in the D5 dev since it was committed in March 27.
The proper fix is to replace the
($path !== 'node/%')with
(preg_match('!^node/\d+$!', $path) == 0)I will try to commit this to CVS soon..
João
Comment #5
hapydoyzer commentedThe error in this line of code:
if (($path !== 'node/%').....Or maybe this is something I don`t know about strings comparsion in PHP?
Comment #6
hapydoyzer commentedSorry, you answered too rapidly:)
Comment #7
toch commentedhello there,
i had the exact same problem and could solve it by replacing ($path !== 'node/%') in print.module. thanks for the quick responses :o)
toch
Comment #8
deviantintegral commentedHere is a patch of the suggestion in #4. Works as expected for me.
Comment #9
jcnventuraThe fix has just been committed to CVS, unfortunately, it will be a few hours before that is generated..
João
Comment #10
Uppa commentedI have made the changes suggested but the link "send by e-mail" still appears both above and below, so I've had to turn it off, which bothers me a bit.
Thanks
Claudia
Comment #11
WeRockYourWeb.com commentedClaudia,
It works, but the patch may not have committed to the -dev version yet. Simply open up your print.module file, and, looking at the patch file from post #8, replace the line beginning with "-" with the line beginning with "+".
Cheers,
Alex
Comment #12
jcnventuraActually, it's because the changes to print.module only fix the problem of the 'Printer-friendly version'. You need to make the exact same changes to print_mail.module and print_pdf.module to get rid of all of them..
Of course, the simplest way is to just download the 5.x-4.x-dev until I release version 5.x-4.6.
João
Comment #13
ggoogi commentedfixed? how is it fixed?
Comment #14
deviantintegral commentedThe issue has been fixed in CVS; that's how issue statuses work. See http://drupal.org/node/156119.
As suggested in #12, if you need this fixed on your own site right away either apply the fixes manually or download the -dev version.
Comment #16
ggoogi commentedIt's never 'fixed' in my case, and I ended up disabling the module. Here's what I want to say: When you don't know what you're doing, please, and please, do find something else to do instead of wasting someone else's life.
Comment #17
hapydoyzer commented