Missing drupal_goto() after saving settings [#43491]

During the forms API conversion, the call to drupal_goto($_GET['q']) in system_settings_save() (which became system_settings_form_submit()) got lost. This call is necessary to allow the user to refresh after submitting, and to make sure all modified variables immediately take effect on the result page.

I don't have time to check if this breaks any forms (though it shouldn't, because it used to work like this before).

Comment	File	Size	Author
	goto.patch	445 bytes	Steven

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 5 January 2006 at 22:55

Status:

Needs review

» Reviewed & tested by the community

Good thing, totally adheres to the form API workflow, one small complaint: patch was missing the -F^f part (or -p). I usually do not complain for this (what's more, I usually reroll patches which are not formal) but...