I'm running Advanced Poll 6.x-1.x-dev with Voting API 6.x-2.0-rc2.

Using a binary poll, with two default choices, the following pattern happens reliably:

From the "latest poll" block - click "Other", write in a vote. Submit. Vote is recorded properly. (screenshot 51)

Click "Cancel Your Vote"

This cancels your vote and takes you to the poll node page.

From here, or if you return to the "latest poll" block, if you submit another write-in vote, it counts double, and the math is off as well (200%!) . (screenshots 52 & 53)

CommentFileSizeAuthor
#7 advpoll-double-count-writein-fix2.patch8.81 KBelstudio
#6 advpoll-double-count-writein-fix2.patch8.81 KBelstudio
#5 advpoll-double-count-writein-fix.patch1.73 KBelstudio
screenshot.53.jpg23.78 KBsrjosh
screenshot.52.jpg27.06 KBsrjosh
screenshot.51.jpg18.97 KBsrjosh

Comments

ChrisKennedy’s picture

ChrisKennedy commented

Hmm, is that on the most recent -dev tar.gz file?

srjosh’s picture

srjosh
he/him
commented

Advanced Poll 6.x-1.x-dev (2009-Apr-11)

asak’s picture

asak commented

Same here...

Advanced Poll 6.x-1.x-dev
// $Id: advpoll.module,v 1.21.2.88.2.23 2009/05/30 17:16:40 heyrocker Exp $

Votng API 6.x-2.3
// $Id: votingapi.module,v 1.46.2.24 2009/07/08 16:09:45 eaton Exp $

julesjs’s picture

julesjs commented

Same here...was anyone able to solve this issue?

advpoll-6.x-1.x-dev
// $Id: advpoll.module,v 1.21.2.88.2.23 2009/05/30 17:16:40 heyrocker Exp $

votingapi-6.x-2.3
// $Id: votingapi.module,v 1.46.2.24 2009/07/08 16:09:45 eaton Exp $

elstudio’s picture

elstudio commented
Status: Active » Needs review
StatusFileSize
new advpoll-double-count-writein-fix.patch1.73 KB

For me, write-in votes were being double counted, whether or not they were canceled first.

I've attached a patch that I believe fixes both issues.

Please test, and let me know if it works for you.

elstudio’s picture

elstudio commented
StatusFileSize
new advpoll-double-count-writein-fix2.patch8.81 KB

Let's try this again. Fixing the double-counting of write-ins required a few more changes.

* I limited _advpoll_writeins_voting_form_submit() to only retrieving the proper tag/cid for a write in. Votes are created back in the appropriate calling function.

Works well for binary polls. Please test for ranking polls.

elstudio’s picture

elstudio commented
StatusFileSize
new advpoll-double-count-writein-fix2.patch8.81 KB

Well that last patch wasn't sufficient. This one works.

* I've limited _advpoll_writeins_voting_form_submit() to creating the proper tag/cid for write-ins -- not creating a vote for them. That fixes the double creation of writing votes.

Works well for binary votes.

Please test for ranked votes.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

D6 is EOL hence this issue won't be fixed (or) attended. So closing it.