The links to redisplay the Analyze page with all/ignore-only/unignored-only are a little confusing - implementing them as tabs may be clearer.

CommentFileSizeAuthor
#4 tw_add_menu_tabs.patch1.34 KBfrankcarey
#3 tw_add_menu_tabs_plus_analysis.patch2.87 KBfrankcarey
#2 tw_add_menu_tabs.patch2.44 KBfrankcarey

Comments

moshe weitzman’s picture

moshe weitzman commented

I'll add that Relationships is invisible if you don't have the navigation block visible. I would expect that to be a tab on admin/content/tw as well. Probably just a matter of chaning that item to MENU_LOCAL_TASK and adding a default local task at admin/content/tw/tables

frankcarey’s picture

frankcarey commented
StatusFileSize
new tw_add_menu_tabs.patch2.44 KB

here is the patch for just the Tables and Relationships as tabs. Need to look into subtabs for the rest of them

frankcarey’s picture

frankcarey commented
Status: Active » Needs review
StatusFileSize
new tw_add_menu_tabs_plus_analysis.patch2.87 KB

No, I guess they should just be regular tabs. This makes all the filters into tabs (plus tables and relationships)

frankcarey’s picture

frankcarey commented
StatusFileSize
new tw_add_menu_tabs.patch1.34 KB

The just table/ relationships tabs patch from #2 was bad, here is a clean version (just in case we don't like #3)

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

Nice, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.