If pages section at admin/build/securepages contains an empty line (what usually happens if someone hits ENTER after the last record) the front page toggles between HTTP and HTTPS each time you reload. The reason for this is that the empty line gets transformed into an empty or condition for the regular expression that matches urls and the empty or condition matches the front page.

I attached a simple patch that eliminates empty lines at the end of the list of pages when validating the admin form.

CommentFileSizeAuthor
#13 420712.patch814 bytesgrendzy
securepages.admin_.inc_.prevent-front-page-toggle.patch502 bytesmkalkbrenner

Comments

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented

See #286333: Blank line in securepages_secure textarea causes Homepage redirection for additional information.

Patch seems reasonable, didn't test it yet.

gordon’s picture

gordon commented
Status: Needs review » Needs work

This looks ok, but you need to add an update which will do fix up the current variables when the update.php is run.

adamo’s picture

adamo commented

Thanks for figuring this out! :)

chaloalvarezj’s picture

chaloalvarezj commented

Thank you! you saved my day

Nathan.Ray-1’s picture

Nathan.Ray-1 commented

Legend! Thanks a bunch!

criznach’s picture

criznach commented

I believe this was causing a redirect loop in firefox on one of my sites. I removed the trailing newline and it started working immediately.

jleinenbach’s picture

jleinenbach commented

Patch works. But remove the trailing newline before applying this patch.

LiveWire’s picture

LiveWire commented

MUCHOS GRACIAS! Thank you a ton.

budda’s picture

budda
Primary language English
Location Cheshire
commented

can you not just re-save the settings form to have your values trimmed?
obviously the redirection would need to be disabled on the settings form in order to get in to the site :-)

heikwan’s picture

heikwan commented

My front page still alternates between http and https even after the patch.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Did you save your settings again after the patch?

adr_p’s picture

adr_p commented
Status: Needs work » Needs review

Please see http://drupal.org/node/587000#comment-4519010.

grendzy’s picture

grendzy commented
Assigned: mkalkbrenner » grendzy
StatusFileSize
new 420712.patch814 bytes

It seems the front page matching is broken anyway. Here's a new patch:

BMorse’s picture

BMorse commented

I applied this patch on version 6.x-1.9 and it seems to have worked fine. Thanks so much!

grendzy’s picture

grendzy commented

I believe this is fixed in the 6.x-2.x branch. Please test and report back if you can.

grendzy’s picture

grendzy commented
Status: Needs review » Fixed

There have been no further reports of this problem in the 6.x-2.x branch, and we have tests now too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.