Icons are no more visible since correction of #385736: markItUp: Wrong editor library location that changes the path to the markItUp editor.
To correct the problem, path to image files shall be changed in markitup-1.css, see attached patch.

CommentFileSizeAuthor
#6 markitup_icon.patch581 byteskswan
markitup.patch1.7 KBStephaneC

Comments

sun’s picture

Status: Active » Fixed

Awesome!

Thanks, committed to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kswan’s picture

Status: Closed (fixed) » Active

I am having this problem with both the current -dev release and the 6.x-2.0. I am using markitup version 1.1.5.

I looked for the file modified by the patch above, but it isn't installed. Also, the buttons "a" tag has an inline style with a background image <a title="Bold [Ctrl+B]" accesskey="B" href="" style="background-image: url(/sites/all/libraries/markitup/markitup/sets/default/images/0.png);">Bold</a>, but the image file doesn't exist. There are images in the /sites/all/libraries/markitup/markitup/sets/default/images/ directory, but they are named: bold.png, clean.png, italic.png...

I could rename the .png files, but then it will break when there is an update to markitup. I can roll a patch if I could find the place to fix this.

Thank you.

sun’s picture

Status: Active » Postponed (maintainer needs more info)

Please ensure that you cleared your browser's cache, so the new JavaScript for markItUp is loaded.

kswan’s picture

Status: Postponed (maintainer needs more info) » Active

I did clear the browser cache and still have the problem.

kswan’s picture

Status: Active » Needs review
StatusFileSize
new581 bytes

I found the error and fixed it. Please see the attached patch.

twod’s picture

Status: Needs review » Fixed

markItUp doesn't seem to mind using named keys instead of array indices there, and it's a simple patch, so this is now committed to HEAD and the D5 branch.
Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.