One thing that seems missing is the facility to either automatically re-check a node after editing using the "Operations Edit node link", or to force re-check of the node using a button associated with the broken links entry. This would allow the user on fixing a link, to remove it from the broken links list, thus providing a method of control to the workflow.

At present you have to remember which was the last one you fixed.

Comments

hass’s picture

hass commented
Title: Recheck link on edit save » Broken link does not immediately disappear in broken links list after link have been fixed in content

No, the broken link is listed in broken links, but there is no longer a reference link shown to the node/comment/block. Keep your cleanup time frame lower if you don't like this. You have set it to 4 weeks - this lists the link for about 4 weeks. I would use a lower value like 1 week or one day.

I'm aware about this usability issue, but I'm also not yet sure how to fix the range_query SQL statement to solve this. Please provide a patch if you know how to solve...

hass’s picture

hass commented
Title: Broken link does not immediately disappear in broken links list after link have been fixed in content » Broken link does not immediately disappear in broken links list after link has been fixed in content
Anonymous’s picture

Anonymous (not verified) commented

Hi Alexander

Thanks for the clarification. I had noticed that in some cases the reference link had disappeard after editing. Though if I remember correctly not always, i.e. when there were two links to the same destination on the node ?

I had not realsied that "Cleanup interval for unused links: " was refering to those that had been " Repaired", Does it also include links that still report an issues ?

If the Cleanup only refers to those "Repaired", a better description might be :-

"Cleanup interval for repaired links:"

with a corresponding description of :-

"This interval setting defines how often cron will clean up repaired links, (those with no link source shown)."

I used "link source", as heading of "Operations" for the column in the Broken Links report is not very descriptive, and may better be replaced with Link Source"

hass’s picture

hass commented

This are "unused links"... no longer used in content. If you have two links pointing to the same destination in one node and only repair one link - the link to the node with the broken links is kept until fixed. The cleanup stuff will hopefully go away in near future, but was kept in days where I thought the module can work without SQL subselects... as more as I'm working on it - this becomes impossible for speed reasons.

hass’s picture

hass commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.