(Tested also in 6.x-2.x-dev)

Original values of this module are Punctuation->"Hyphen-to be replace by separator"
When clicked "Reset to Defaults", settings are changed to "Hyphen-Remove"

So when you go to save the settings this message is displayed:

You have configured the Hyphen - to be the separator and to be removed when encountered in strings. This can cause problems with your patterns and especially with the catpath and termpath patterns. You should probably set the action for Hyphen - to be "replace by separator".

CommentFileSizeAuthor
#4 374396-punctuation-defaults-D6.patch1.13 KBdave reid
#3 374396-punctuation-defaults-D6.patch1.13 KBdave reid
#2 374396-sane_defaults_for_punctuation-2-d6.patch1.45 KBFreso

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Reset to Defaults doesn't reset to the original values. » Reset to Defaults doesn't reset to the original values for the Hyphen punctuation character
Priority: Minor » Normal
Freso’s picture

Freso commented
Version: 6.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new 374396-sane_defaults_for_punctuation-2-d6.patch1.45 KB

The attached patch checks what is currently being used as a separator, and defaults that to PATHAUTO_PUNCTUATION_REPLACE. This might lead to some quirks where you're resetting the settings, and then changing the separator - or having had a different separator before resetting. It's also completely untested. Please provide feedback. :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 374396-punctuation-defaults-D6.patch1.13 KB

Patch against 6.x-1.x as well.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 374396-punctuation-defaults-D6.patch1.13 KB

Without janky spacing this time.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested on both 6.x-2.x and 6.x-1.x. I don't think this is necessary with 7.x-1.x since there is no more 'Reset to defaults' with system_settings_form().
http://drupal.org/cvs?commit=331352
http://drupal.org/cvs?commit=331354

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.