A pretty minor coding standards issue.. theme functions are, in their nature, going to be called from outside of the module, and therefore should not call private functions.

Members fund testing for the Drupal project. Drupal Association Learn more


dopry’s picture

Status: Active » Postponed (maintainer needs more info)

just what are you talking about? how about write a patch...

quicksketch’s picture

Status: Postponed (maintainer needs more info) » Active

Looks like _filefield_icon_url($file) is culprit in filefield.theme.inc.

function theme_filefield_icon($file) {
  if ($icon_url = _filefield_icon_url($file)) {
    $icon = '<img class="field-icon-'. $dashed_mime .'"  alt="'. $mime .' icon" src="'. $icon_url .'" />';
  return '<div class="filefield-icon field-icon-'. $dashed_mime .'">'. $icon .'</div>';
quicksketch’s picture

Status: Active » Fixed
2.43 KB

I moved this function to the public namespace, unfortunately this means that sites that have overridden this function are now going to break when they upgrade to the next version. But best to get it over with now and get out a stable version as soon as possible.

quicksketch’s picture

Oh, turns out there already was a public function for "filefield_icon_url()". Here's an update patch which renames these functions back to private, but just changes the function call in the theme function.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.