Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
A pretty minor coding standards issue.. theme functions are, in their nature, going to be called from outside of the module, and therefore should not call private functions.
Comment | File | Size | Author |
---|---|---|---|
#4 | filefield_theme_functions2.patch | 1.07 KB | quicksketch |
#3 | filefield_theme_functions.patch | 2.43 KB | quicksketch |
Comments
Comment #1
dopry CreditAttribution: dopry commentedjust what are you talking about? how about write a patch...
Comment #2
quicksketchLooks like _filefield_icon_url($file) is culprit in filefield.theme.inc.
Comment #3
quicksketchI moved this function to the public namespace, unfortunately this means that sites that have overridden this function are now going to break when they upgrade to the next version. But best to get it over with now and get out a stable version as soon as possible.
Comment #4
quicksketchOh, turns out there already was a public function for "filefield_icon_url()". Here's an update patch which renames these functions back to private, but just changes the function call in the theme function.