In core we have locale.module and translation.module. Contrib has i18n, i10_server and others. I think it makes sense to collate the administrative items for these modules under a single "internationalisation" menu item - this would include the languages settings in site configuration as well (adding a language to a site isn't really a 'setting' IMO).

This would have the advantage of moving interface translation out of site building (it's not really site building), and making these features easily accessible in one place.

I'm also going to open an issue for a development menu item - for simpletest (core), but also devel and schema modules to add themselves to. Again, for much the same reasons.

CommentFileSizeAuthor
#22 368064-followup-1.patch1.49 KBc960657
#17 international_1.patch58.16 KBBerdir
#12 international.patch40.2 KBcatch
#10 international.patch44.14 KBcatch
#10 international.png34.62 KBcatch
#8 internationalization..patch0 bytescatch
#6 internationalization.patch35.28 KBcatch
#3 Screenshot-Administer | d7.7 - Mozilla Firefox-1.png53.88 KBcatch
#2 internationalization.patch4.76 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Agreed. These admin items can very well be grouped into their own top level admin section:
- The items in core are already a bit misplaced because it is indeed not really site building
- There's quite a family of internationalisation contrib modules available that will be much easier to find with this dedicated admin section.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review
FileSize
internationalization.patch4.76 KB

Here's a patch, turns out that translation module doesn't actually define an admin menu item anywhere - just form_alters the content type admin forms. However locale module has two top level items, and the translation settings could arguably not be hidden in workflow settings so maybe move here too.

Need to verify that if two modules define the same router item it'll just overwrite/ignore the second entry rather than break - going to do that with the development item now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work
Issue tags: +Screenshot, +Usability
FileSize
Screenshot-Administer | d7.7 - Mozilla Firefox-1.png53.88 KB

screenshot.

Also, tests not updated yet.

Noyz’s picture

Noyz CreditAttribution: Noyz commented

+1

Ultimately I think more work needs to be done. Seems like users should be able to enable multi-language support, and tweak the settings of it's output via the modules settings. I think this is getting closer: http://skitch.com/yoroy/brmpw/localization-client

None-the-less, this is better than what's there today.

Bevan’s picture

Bevan CreditAttribution: Bevan commented

I agree this is an improvement

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: Provide a top level 'internationalisation' menu item. » Provide a top level 'internationalization' menu item.
Status: Needs work » Needs review
FileSize
internationalization.patch35.28 KB

All tests should pass with this one.

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: Provide a top level 'internationalization' menu item. » Provide a top level 'internationalisation' menu item.
Status: Needs work » Needs review
FileSize
internationalization..patch0 bytes

The test I wrote came back to bite me. Updated that one too.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Let's try some simpler wording. What is this setting-group's name in your favourite OS? e.g. in OS X it's called 'International'. How about:

International
Languages and translation

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
international.png34.62 KB
international.patch44.14 KB

In Ubuntu I have 'Language settings' and a separate section for date/time. Internationalization makes for a long path, and international sounds better to me.

New, non-empty patch and screenshot.

screenshot

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
international.patch40.2 KB

Re-rolled for the new locale test, minor whitespace fixes crept into the patch, sorry.

Status: Needs review » Needs work

The last submitted patch failed testing.

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented

I would not create a top level menu item for 2 links..
The i18n and l10n_client modules do not add any new links to that group. The l10n_server module is used on 50 sites and all will be replaced by one translation server on d.o, so that is a bad example..

I would consider the possibility moving the "interface translations" inside "languages" because I many times searched for that inside the Language settings.
Or redesign the whole menu structure for language related menu links, because I am not convinced with the reasoning, this change isn't an improvement yet..

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Yes, all language locale and translation related menu items should move into this section. Contrib modules should update to move their links into this section as well.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Sounds like a solid improvement, failed to apply patch - can someone review why?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
FileSize
international_1.patch58.16 KB

Re-rolled.

No idea why the patch failed, it were just text (url) replacements, some worked, some not.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs review » Reviewed & tested by the community

Marking this rtbc, I don't see any objections to this patch other then "other things should be under this as well".

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs documentation

Awesome! Committed to HEAD.

This should be reflected in the ugprade docs for other modules that might want to add settings under here.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Fixed

documented :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

c960657’s picture

c960657 CreditAttribution: c960657 commented
Status: Closed (fixed) » Needs review
FileSize
368064-followup-1.patch1.49 KB

This broke the edit and delete links in the table on admin/international/translate/translate.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

We probably need some tests then...

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Reviewed & tested by the community

I tested this patch, and it fixes the bug (just a typo with leading slashes). Really this is not something likely to regress and we generally don't test our clickcable links everywhere in the UI with simpletest.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Screenshot, -Usability, -Needs documentation

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Screenshot, +Usability, +Needs documentation

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.