The test bed checks any file that starts with <? for correct php syntax, also XML files. Tests on patches like #364467: Remove-items followed by update items does not work fail therefore.

#365889: php -l interprets XML files fixes this problem and needs to be rolled out to the test bed.

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Project: Drupal.org infrastructure » Project Issue File Review
Version: » 6.x-2.x-dev
Component: Other » Code
Status: Active » Closed (duplicate)

Fixed in PIFR #365889: php -l interprets XML files.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Closed (duplicate) » Active

Yes, but it still needs to be deployed. :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Ah, I wasn't sure if we needed to create issues for each PIFR improvement that needed to be deployed to the testbots. Thought it was pretty much "hey new release", "ok we gots it!" :) I'm probably wrong.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Active » Closed (fixed)

That is the general idea...I will try and get it done later today.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Closed (fixed) » Postponed (maintainer needs more info)

Did this get done? Testing bot is still choking on http://drupal.org/node/364777#comment-1228580, which has 0 PHP code.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Oops. That one was actually #366952: "Invalid PHP Syntax" when testing binary files that don't exist.

But I'm still curious if this got deployed.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Assigned: Unassigned » boombatower
Status: Postponed (maintainer needs more info) » Fixed

Deployed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.