Select default custom menu [#364363]

Sometimes different menu entries are used for a single path. In these cases, Menu Breadcrumb select one of these. This patch adds a dropdown box to select the default menu that will be used for breadcrumb. Navigation menu items are excluded by this method to preserve breadcrumb on administration pages. A screenshot is attached.

Note: "Use menu the page belongs to..." should be enabled.

Comment	File	Size	Author
#8	menu.png	30.09 KB	pshahmumbai
#7	menu.png	30.09 KB	pshahmumbai
	menu_breadcrumb_custom_menu.patch	2.02 KB	chirale
	default_custom_menu.jpg	22.37 KB	chirale

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mrfelton CreditAttribution: mrfelton commented 3 February 2009 at 16:32

Status:

Needs review

» Reviewed & tested by the community

+5 for this patch for me - in my opinion, this module is unusable without this patch applied. Please can somebody commit this.

Comment #2

Elijah Lynn

Portland, Oregon

CreditAttribution: Elijah Lynn commented 8 May 2009 at 20:43

Comment #3

balabushka CreditAttribution: balabushka commented 13 May 2009 at 14:03

ty so much, just wanted to code that myself

Comment #4

dboulet CreditAttribution: dboulet commented 24 June 2009 at 22:22

Status:

Reviewed & tested by the community

» Needs work

This feature would be very useful, especially for multilingual sites with separate menus for each language. Patch needs work...

Comment #5

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

CreditAttribution: xurizaemon commented 16 August 2009 at 02:38

dboulet, can you please clarify what needs work about the above patch? Seems you mean it doesn't handle per-language menus appropriately - can you describe the issue you see in that case?

Comment #6

dboulet CreditAttribution: dboulet commented 15 September 2009 at 21:31

Sorry xurizaemon, I should have described the work that was needed in more detail--now, over 2 months later, I don't even recall exactly what the issue was.

I'm pretty sure that the problem wasn't with using multi-lingual variables, I think that it was a problem with the logic that decides when to use the default menu. Using the last patch, the default menu will always be chosen--whether the current menu item belongs to that menu or not. Seems to me that the default should only be used as a fallback when a conflict is detected, when there exists more than one menu item that points to the current path. Does that make sense, or have I misunderstood the logic behind the patch?

Comment #7

pshahmumbai CreditAttribution: pshahmumbai commented 2 October 2009 at 18:43

File	Size
menu.png	30.09 KB

The CVS version already does this :)

Comment #8

pshahmumbai CreditAttribution: pshahmumbai commented 2 October 2009 at 18:44

File	Size
menu.png	30.09 KB

Comment #9

dboulet CreditAttribution: dboulet commented 2 October 2009 at 19:24

A black list/white list option, though a nice feature, is not exactly what we are after. I was thinking about this some more, and what we really need to to give each menu a weight so that they can be given an order of preference, as suggested by jweowu in #556552: Menu weights, black/white list, and memory of menu selection.