Problem/Motivation

All pipelines (both MR and scheduled) are failing again with PHPStan complaining about new deprecations. Both 2.1.x and 2.0.x branches of address.

#3623506: Port to upstream addressing v2.3 API tried to fix it, but was changing way too much, and doing so in potentially disruptive ways.

I think we need to keep tweaking our .gitlab-ci.yml and phpstan config so that we ignore deprecations on the 2.0.x branch, and most pipelines in the 2.1.x branch. We already have a separate, manual "with-deprecations" job we can run if we want to see what's coming. But we don't want to "fix" pipelines that fail anywhere else due to new deprecations.

Steps to reproduce

Proposed resolution

  • Ensure we only see new deprecations on the phpunit-d11_next-all_deprecations job. Suppress them on other phpunit jobs.
  • Keep tweaking phpstan config if needed to ignore new deprecations on stable branches.
  • ...

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3634183-4.pipeline.jpg194.37 KBdww

Issue fork address-3634183

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww’s picture

dww
we/he/they
commented
Title: PHPStan job failing pipelines (2.1.x and 2.0.x) » New deprecations causing failing pipelines (2.1.x and 2.0.x)
Issue summary: View changes

(this isn't just about phpstan)

dww opened merge request !111

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 3634183-4.pipeline.jpg194.37 KB

https://git.drupalcode.org/project/address/-/pipelines/1023291 looks exactly how we want.

This commit cherry-picks cleanly to 2.0.x, so no need for a 2nd branch and MR (yet).

With other recent commits, phpstan is actually passing everywhere again.

So maybe this is all we need to be happy (for now)?

  • dww committed 0630f10f on 2.1.x 
    ci: #3634183 Ignore deprecations in most phpunit jobs

By: dww

  • dww committed c559a241 on 2.0.x 
    ci: #3634183 Ignore deprecations in most phpunit jobs

By: dww

(cherry...
dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Pushed to 2.1.x, cherry-picked and pushed to 2.0.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dww’s picture

dww
we/he/they
commented
Status: Fixed » Needs work

It's working, but I didn't notice the big scary warning:

https://git.drupalcode.org/project/address/-/jobs/13229735#L488

WARNING: _PHPUNIT_EXTRA ('--verbose --suppress-deprecations') is set, but _PHPUNIT_CONCURRENT is '1' (run-tests.sh) and _RUNTESTS_EXTRA is blank. _PHPUNIT_EXTRA is intended for the 'phpunit' binary only (_PHPUNIT_CONCURRENT: 0).
...

I'm going to fix this up.

dww opened merge request !113

  • dww committed 86f869bc on 2.1.x 
    ci: #3634183 Use _RUNTESTS_EXTRA not _PHPUNIT_EXTRA to suppress...

  • dww committed d94d6ad6 on 2.0.x 
    ci: #3634183 Use _RUNTESTS_EXTRA not _PHPUNIT_EXTRA to suppress...
dww’s picture

dww
we/he/they
commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.