Problem/Motivation

Pipelines are failing
https://git.drupalcode.org/project/address/-/pipelines/961834

Issue fork address-3623506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tbkot created an issue. See original summary.

tbkot’s picture

Status: Active » Needs review
shahul hameed’s picture

Status: Needs review » Active

I tested MR !106 locally on Drupal 11.4.6 with PHP 8.5.7.

Testing performed:

* Address module installs and is enabled successfully.
* Cache rebuild completes successfully.
* The `country` and `administrative_area` Views plugins are discovered successfully.
* Both Views plugin classes instantiate successfully.
* The modified `Address.php`, `ZoneTerritory.php`, `AdministrativeArea.php`, and `CountryAwareInOperatorBase.php` files pass PHP syntax checks.
* Verified that `getSubdivisionDataFields()` and `getSubdivisionDepth()` are available in the installed CommerceGuys Addressing 2.3.1 library.
* Compared subdivision depth/data-field counts for US, CA, GB, and IN; both approaches return the same value (`1`) for these address formats.
* Reviewed all 7 changed files in the MR.

I could not run the PHPUnit tests locally because PHPUnit is not installed in the current Drupal site dependency setup. The current MR pipeline is passing its automated PHPUnit, PHPStan, PHPCS, ESLint, Stylelint, and related CI jobs.

Based on the above testing, I did not find any issues with the changes.

dww’s picture

Status: Active » Needs work

Thanks for working on this.

Most of the changes in the MR here are out of scope to the task of getting the default phpstan job passing again, and could move to an MR for #3414148: Use DI not \Drupal in src/Plugin/views/filter/AdministrativeArea.php.

We also don't want to suppress deprecation warnings on the phpunit-d11_next-all_deprecations job, that's its reason to exist. 😂

Cheers,
-Derek