In some of the phpstan test failures:

  Line   metatag_routes/src/Hook/MetatagHooks.php                      
 ------ -------------------------------------------------------------- 
  19     Readonly properties are supported only on PHP 8.1 and later.  
         🪪  property.readOnlyNotSupported (non-ignorable)             
  26     Readonly properties are supported only on PHP 8.1 and later.  
         🪪  property.readOnlyNotSupported (non-ignorable)

IMHO it doesn't make sense that this is logged as an error because Drupal 10+ require PHP 8.1, so why is it logging errors about PHP 8.1?

Issue fork metatag-3633337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

shubhamgoel made their first commit to this issue’s fork.

shubhamgoel opened merge request !299

shubhamgoel’s picture

shubhamgoel commented
Status: Active » Needs review

Hi Team,

The fix has been applied. Please review and merge the MR https://git.drupalcode.org/project/metatag/-/merge_requests/299/diffs.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It would likely also work to remove the PHP minimum so that it falls-back to core's minimum.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna

It would likely also work to remove the PHP minimum so that it falls-back to core's minimum.

That's what I'm thinking too.

damienmckenna opened merge request !305

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3633976: Plan for Metatag 2.2.4

  • damienmckenna committed 4ad64a61 on 2.2.x 
    Issue #3633337 by shubhamgoel, DamienMcKenna, liam morland: Remove PHP...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.