Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 12.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 wp_admin.1.0.x-dev.rector.patch1.03 KBproject update bot

Issue fork wp_admin-3632921

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

project update bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new wp_admin.1.0.x-dev.rector.patch1.03 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.1.3, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-1013401

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha3
  2. mglaman/phpstan-drupal: 2.2.1
  3. palantirnet/drupal-rector: 1.1.3

project update bot opened merge request !1

tbcs made their first commit to this issue’s fork.

tbcs opened merge request !2

tbcs’s picture

tbcs commented
Issue summary: View changes

The bot's patch replaces one of three theme_get_setting() calls. Upgrade Status still reports the project as incompatible because of two things Rector cannot fix: Drupal 12 drops theme-settings.php and removes Claro from core.

Branch 3632921-automated-drupal-12 has two commits on top of 1.0.x:

  1. Move the theme's hooks into classes. Drupal 12 no longer reads theme-settings.php (deprecated in 11.5, #3587273), so the "Columns field" setting disappeared from the theme settings form. Drupal 11.5 also deprecates .theme files for removal in 13 (#3581222). Every hook from wp_admin.theme and theme-settings.php is now a method on Drupal\wp_admin\Hook\WpAdminHooks or Drupal\wp_admin\Hook\ParagraphsHooks. Drupal 11.4 already supports these. The setting is read through ThemeSettingsProvider, which covers all three theme_get_setting() calls, the bot's one included.
  2. Allow Drupal 12. core_version_requirement: ^11.4 || ^12 on the theme and both sub-modules, and drupal/core: ^11.4 || ^12 in composer.json. Claro, the base theme, is contrib Claro 3.x on Drupal 12. Claro 3.x requires core ^11.5 || ^12, so composer.json cannot require it while 11.4 is supported. It is listed under suggest instead, and the README tells Drupal 12 sites to run composer require drupal/claro:^3.

Testing

  • Drupal 12.0.0-beta2 with contrib Claro 3.0.0, and Drupal 11.4.11: the theme and both modules install, all nine hooks register, the settings form shows "Columns field" with its saved value, and the login screen has its links. Closed paragraphs draw their child boxes in 2 columns and in a 2:1 ratio, each with its summary ("Embedded media" included), and the column radios draw as layouts. On Drupal 12, the base theme resolves to themes/contrib/claro.
  • Upgrade Status 5.0.0-alpha3 on Drupal 12: no Drupal 12 issues. It only reports the version constraints as not being Drupal 13-ready, plus the optional gin/* and paragraphs_ee libraries when those modules are absent.
  • phpstan with mglaman/phpstan-drupal and deprecation rules against 12.0.0-beta2: no errors. PHPCS (Drupal, DrupalPractice): clean.

Paragraphs 1.23 does not declare Drupal 12 compatibility yet. It was enabled in the test site with a patched info file only, to exercise the preview code.

The bot's MR !1 can be closed in favour of this branch.

  • tbcs committed babfaeff on d12-compat 
    Issue #3632921 by tbcs: Drupal 12 compatibility.

- move every hook from...
tbcs’s picture

tbcs commented

MR: https://git.drupalcode.org/project/wp_admin/-/merge_requests/3 is !2 squashed into one commit, so !2 can be closed.

This comment was drafted by an LLM before it was reviewed by me.

  • tbcs committed babfaeff on 1.0.x 
    Issue #3632921 by tbcs: Drupal 12 compatibility.

- move every hook from...