Problem/Motivation

Initially handled in #3517033: Add a Style API.

As the goal is to split the issue into smaller with reduced scope, I create this issue.

Regarding MR https://git.drupalcode.org/project/drupal/-/merge_requests/13379

This issue's scope is about:

  • core/assets/schemas/v1/style.schema.json
  • core/lib/Drupal/Core/Render/Element/Styles.php
  • core/lib/Drupal/Core/Theme/Style
    • core/lib/Drupal/Core/Theme/Style/StyleDefinition.php: some parts
  • core/modules/system/system.styles.yml
  • related tests

Improving the plugin discovery by splitting into two files:
- *.utilities.yml
- *.themes.yml

Instead of *.styles.yml. Let the type property be automatically set by the detected name.

CommentFileSizeAuthor
#9 3631482-nr-bot_egp_qlto.txt3.08 KBneeds-review-queue-bot
#6 3631482-nr-bot_vhizb9z5.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3631482

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

grimreaper opened merge request !17483

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +TX (Themer Experience), +11.5.0 release priority
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
pdureau’s picture

pdureau commented
Title: Style utility: style manager, style definition, styles form element » Style API: plugin manager and definition, form element
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3631482-nr-bot_vhizb9z5.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » larowlan

Hi @larowlan,

This is the new place for the review of #3517033: Add a style utility API

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3631482-nr-bot_egp_qlto.txt3.08 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.