Problem/Motivation
Once #3616205: Restore group-scoped administer og menu permission and the beta1 work tracked in #3623047: [meta] 2.0.0-beta1 release roadmap are complete, OG Menu 2.x should cover its main use case: allowing group administrators to manage their group's menus without requiring site-wide permissions.
Before a stable release, it would be good to confirm the supported core versions are in good shape, bring the documentation up to date for 2.x, and review the remaining API questions.
There are also several useful Drupal 7 parity features and opportunities for more fine-grained permissions. Those can continue separately and do not necessarily need to hold up a stable 2.0.0 release.
Proposed resolution
Work toward a 2.0.0 release after the items below have been reviewed and addressed.
Deprecated code introduced during the alpha and beta cycle can be removed as part of the stable release. The additional Drupal 7 parity and per-instance permission work can be collected into a follow-up meta and considered for later 2.x releases or a future major version as appropriate.
Remaining tasks
Prerequisite
- Release 2.0.0-beta1 per #3623047: [meta] 2.0.0-beta1 release roadmap
Review before 2.0.0
- #2992044: Add a list builder for OG Menu instances and replace the custom OverviewMenuInstances form — review whether an
ogmenu_instancelist builder is still useful, or whetherOverviewMenuInstancesalready covers the intended use case - Remove
OgMenuInstanceController::addLinkAccess(), deprecated in 2.0.0-alpha5
Follow-up work
These are useful Drupal 7 parity or more fine-grained permission improvements, but do not need to block 2.0.0. Track them in a follow-up meta so they remain visible after the stable release.
- #3128002: group/node/< nid >/admin/menus path does not exist
- #2907590: Setting a og-menu instance as a menu_name in a *.links.menu.yml file results in a fatal error when trying to edit said menu item
- #2885625: Add support for menu_ui node form widget
- #3017938: Add multilingual support for OgMenuInstance
- #2849427: Use the menu name as a cache tag instead of a generic catch-all name
- #2902575: Provide a pager on the OG Menu overview page
- Per OG Menu bundle group permissions, as noted in the
@todoinOgMenuEventSubscriber::provideDefaultOgPermissions()
API changes
OgMenuInstanceController::addLinkAccess() is removed. Use the add-link entity access operation instead.
Comments
Comment #2
joelpittetComment #3
joelpittetComment #4
joelpittet