Problem/Motivation

Part of deprecating Olivero.

There are a few tests that were not done in the other issues.

$ git grep -i olivero | grep -v core/assets | grep -v core/themes/olivero | grep -v phpstan-baseline | grep -i test | grep -vE "\s*(//|#|\*|{\s*#)" | awk -F: '{print $1}'  | sort -u
core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php
core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php
core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroRemoveBlockConsoleTest.js
core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroSearchFormTest.js
core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php
core/modules/system/tests/src/Functional/Entity/EntityComputedFieldTest.php
core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php
core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php

Steps to reproduce

Proposed resolution

  1. core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php
  2. core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
  3. core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php
  4. core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php
  5. core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php
  6. core/modules/system/tests/src/Functional/Entity/EntityComputedFieldTest.php

Some of these are changed to using Claro. And yes, that will need to be changed but this is to deprecate Olivero, not Claro.

No Change

These will be removed when Search is removed

  1. core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroRemoveBlockConsoleTest.js
  2. core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroSearchFormTest.js
  3. core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3622600-nr-bot_p6pw2ujv.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3622600

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !17100

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs work
quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review
nitinkumar_7’s picture

nitinkumar_7 commented

Olivero dependencies have been removed from the affected tests while preserving their original test coverage. The dedicated locale_test_config_langcode theme is a good approach for testing config language rewriting without depending on Olivero, and the updated MenuRouter assertions correctly use the new default theme.

nitinkumar_7’s picture

nitinkumar_7 commented

updated assertions in CommentDisplayConfigurableTest, MenuRouterTest, and StandardInstallerTest are appropriate and no longer depend on Olivero-specific assets.

The affected tests pass as expected.

+1 RTBC.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3622600-nr-bot_p6pw2ujv.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Status: Needs work » Needs review
godotislate’s picture

godotislate
he/him
commented

@nitinkumar_7 Thanks for reviewing the MR.

Note for future: if you're confident that an MR looks good, please feel free to move the issue directly to RTBC instead of a "+1 RTBC" comment. If you do have minor reservations/caveats about something, but think it should be RTBC'd regardless, "+1 RTBC" works, along with a description of what the concern is. Thanks again!

daffie’s picture

daffie commented
Status: Needs review » Needs work

Just a single question. For the rest it is RTBC for me.

quietone’s picture

quietone commented
Status: Needs work » Needs review

@daffie, thanks for spotting that. The default and admin theme should not be the same.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

All changes look good to me.
Fro me it is RTBC.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

Some comments on the MR. Even if Stark does not provide CSS, I think we can be clear about how we're testing theme CSS with Stark being active by making sure there are no theme CSS files at all.

quietone’s picture

quietone commented
Status: Needs work » Needs review

@godotislate, thanks, those assertions are much better.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

lgtm

quietone’s picture

quietone commented
Issue tags: +11.5.0 release priority

gábor hojtsy made their first commit to this issue’s fork.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

The 2 more mentions I found are minor, so RTBC remains I think :)

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev

Committed/pushed to main, thanks!

Moving to 11.x for backport.

  • catch committed 3cf128d0 on main 
    task: #3622600 Remove remaining uses of Olivero in tests

By: quietone...

quietone opened merge request !17164

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review

Made an 11.x MR. That include adding the IgnoreDeprecations attribute to a few Migrate Kernel tests. I think it is best to keep those testing using olivero instead of trying to change it to something else.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

All changes look good to me.

  • larowlan committed cadfbb39 on 11.x 
    task: #3622600 Remove remaining uses of Olivero in tests

By: quietone...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed cadfbb390fc to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.