Problem/Motivation

HTML tags in captions got fixed in #3574103: Allow limited HTML in captions through domPurify, move caption README in main module and fix tests using the DOMPurify library and it works well.

But there was a detail, which puzzled me: I enabled "Allow HTML captions" without the script file in place, and visited the Status report page immediately after, where missing PhotoSwipe libraries are usually reported, but saw no error about missing DOMPurify file, and thought there was no check ...

So today I was about to create an issue, but read the MR, and realised there is actually a check, nice! But it is only shown on the Settings page, /admin/config/media/photoswipe_dynamic_caption.

Steps to reproduce

Proposed resolution

Perhaps the warning about missing DOMPurify library file error can be also shown on the Status report page, alongside the other Photoswipe missing library errors?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3620978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ressa created an issue. See original summary.

ressa opened merge request !158

ressa’s picture

ressa
he/him
commented
Assigned: ressa » Unassigned
Status: Active » Needs review
ressa’s picture

ressa
he/him
commented
Issue summary: View changes

Let's keep the warning on the settings page, per feedback in #3574103-25: Allow limited HTML in captions through domPurify, move caption README in main module and fix tests :)

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @ressa - I made a little text alignment and think this is ready to be merged :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: Would you maybe like to finish #3620906: Fix code style issues so we have everything green again, @ressa? Just if you'd like to...

ressa’s picture

ressa
he/him
commented

Thank you @anybody! And nice with the improvements. I took a stab at fixing some of the coding standards errors.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thank YOU ressa! :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.