Move toolbar support from Workspaces to Toolbar

Looks good to me now :)

I was wondering the same by @catch above in #4 but I think its fine this way too.

This also removes workspaces support from toolbar. It would be theoretically possible to move all that logic across but really think people can move to navigation if they want all bells and whistles.

I also looked at the scoping there was in #3618746: Toolbar uses in Announcement, User, Contextual originally, where this was broken out of. That was about moving the CSS along with the builders. This removes both so I think this is fine too. It would have been a problem if the CSS is removed but the builders were kept.

What if someone is using this functionality in 11.4 and upgrades to 11.5? Many users who started on 11.0 or earlier will still be using Toolbar and not Navigation, as it was experimental until 11.4. Can we only land this in main where toolbar will be removed?

Yeah I'm with @longwave on this, I was expecting to see the code from workspaces_ui moved into toolbar

Ok changed it to move code instead of remove code which is a 30 net line code addition apparently. 11 files +55 −22

I think we could simplify by registering the lazy builder service always, and then it only gets used if Workspaces is installed, there is no harm in an unused service so conditionally enabling it is just an extra complication.

I went by how the existing NavigationServiceProvider uses the conditional pattern for navigation.workspaces_lazy_builders already, that is how it was done there :) But it does look like other core modules use a nullable argument yeah, so modified to that now.

Agreed that this approach is much more update friendly :)

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

11.x MR available

Compared 11.x MR diff to main commit diff, and they look essentially the same, other than adding autowire to the service definition.