Problem/Motivation
A couple of service injections need to be updated to typehint on the core class, not the one UI Patterns implements that extends the core class. Without this, its not possible for other downstream projects (such as mine), to further decorate core's class, because when UI Suite is used, it will crash because my class extends cores, not myclass -> uisuite -> core.
Steps to reproduce
- Create a new class that decorates SDC service plugin.manager.sdc.
- Extend core class.
- Visit relevant UI Patterns/suite routes.
- WSOD
Proposed resolution
Change the imported class to the root-most core class.
Usually in Drupalland we'd use an interface, and thats probably lead to this oversight.
Remaining tasks
Nil.
User interface changes
Nil.
API changes
Nil.
Data model changes
Nil.
Comments
Comment #3
dpiNote, there are other service imports which are already using the core class typehint. These are just the stragglers/oversights.
Comment #4
just_like_good_vibesHello, thank you for reporting. This is funny because we talked about that with @pdureau last friday just before the weekend, and on Monday the issue is here :)
Comment #5
dpiSure thing, This'll help accelerate experimentation integrating Pinto with Display Builder, as we'll be synthesizing SDC's [just like UI Suite does?].
Comment #6
just_like_good_vibesi am continuing your work and i will make a proposition
Comment #10
just_like_good_vibesHello, and one more time thank you for taking the time to report and propose code.
After some discussions with other maintainers, some tests and some tries,
we are proposing a bigger evolution of ui_patterns to cope with other modules (like pinto or canvas) which are decorating or replacing the sdc plugin manager.
would you have time to try the work done in #3625036: Read component definitions from our own service, not from plugin.manager.sdc please ? please make the comments directly in the other issue?
thank you very much
Comment #11
just_like_good_vibesComment #12
just_like_good_vibesHello, we have merged #3625036: Read component definitions from our own service, not from plugin.manager.sdc. Can you check that it fixes the current issue please, thank you
Comment #13
just_like_good_vibes