Describe your bug or feature request.

EditForm's catch dispatches PaymentEvents::PAYMENT_FAILURE with the original exception (#3405381: Add an event for payment failures during checkout); AddForm's catch only logs + re-throws generic → integrators can't react to AVS/CVV declines at method creation.

Add the same dispatch to AddForm for parity.

Issue fork commerce-3618777

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented

Maybe error is somewhere else - /modules/payment/src/PluginForm/PaymentMethodAddForm.php rethrows decline exception with generic error message and feeds it with previous exception as context rather than current one.

zaporylie opened merge request !733

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Category: Feature request » Task
Status: Active » Needs review

  • zaporylie committed a69592a3 on 3.x 
    feat: #3618777 PaymentMethodAddForm does not dispatch FailedPaymentEvent...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.