Problem/Motivation

Discovered some change record links that are issue links because 'issue' was in the URL.

$ git grep -l @trigger_error.*issue
core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
core/lib/Drupal/Core/Extension/ModuleInstaller.php
core/lib/Drupal/Core/Menu/LocalActionManager.php
core/lib/Drupal/Core/Menu/LocalTaskManager.php
core/lib/Drupal/Core/Menu/MenuLinkManager.php
core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php
core/lib/Drupal/Core/Routing/YamlRouteDiscovery.php
core/lib/Drupal/Core/Theme/ThemeAccessCheck.php
core/modules/big_pipe/src/Render/BigPipeResponseAttachmentsProcessor.php

Steps to reproduce

Proposed resolution

Change the links with "issue" in the URL to direct to the change record.
Exclude links for issues #2538970: Improve the speed of \Drupal\Core\Theme\ThemeAccessCheck and #3593485: Use YamlCacheCollectorDiscovery for links, tasks, and actions

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3616720

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16708

quietone’s picture

quietone commented
Issue summary: View changes

The remaining 4 instances are for 2 issues, neither of which have a change record.

$ git grep  @trigger_error.*issue
core/lib/Drupal/Core/Menu/LocalActionManager.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $yamlCacheCollector argument is deprecated in drupal:11.5.0 and it will be required in drupal:12.0.0. See https://www.drupal.org/project/drupal/issues/3593485', E_USER_DEPRECATED);
core/lib/Drupal/Core/Menu/LocalTaskManager.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $yamlCacheCollector argument is deprecated in drupal:11.5.0 and it will be required in drupal:12.0.0. See https://www.drupal.org/project/drupal/issues/3593485', E_USER_DEPRECATED);
core/lib/Drupal/Core/Menu/MenuLinkManager.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $yamlCacheCollector argument is deprecated in drupal:11.5.0 and it will be required in drupal:12.0.0. See https://www.drupal.org/project/drupal/issues/3593485', E_USER_DEPRECATED);
core/lib/Drupal/Core/Theme/ThemeAccessCheck.php:      @trigger_error('Passing ThemeHandlerInterface to ' . __METHOD__ . '() is deprecated in drupal::11.4.0 and is removed from drupal:12.0.0. Pass theme info from the "container.themes" container parameter instead. See https://www.drupal.org/project/drupal/issues/2538970');
quietone’s picture

quietone commented
Issue summary: View changes

In committer Slack, catch thinks the two remaining issues can link to the issue because:
#2538970: Improve the speed of \Drupal\Core\Theme\ThemeAccessCheck - ThemeAccessCheck is @internal (tagged service) so it shouldn't be used
#3593485: Use YamlCacheCollectorDiscovery for links, tasks, and actions - only only constructor deprecations

That works for me.

quietone’s picture

quietone commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I pulled a list of all trigger_error() URLs:

https://www.drupal.org/node/2939099
https://www.drupal.org/node/3015925
https://www.drupal.org/node/3035289
https://www.drupal.org/node/3035368
https://www.drupal.org/node/3037033
https://www.drupal.org/node/3037162
https://www.drupal.org/node/3040111
https://www.drupal.org/node/3068104
https://www.drupal.org/node/3261271
https://www.drupal.org/node/3291487
https://www.drupal.org/node/3324749
https://www.drupal.org/node/3324751
https://www.drupal.org/node/3324758
https://www.drupal.org/node/3336219
https://www.drupal.org/node/3348180
https://www.drupal.org/node/3382344
https://www.drupal.org/node/3395575
https://www.drupal.org/node/3395582
https://www.drupal.org/node/3494023
https://www.drupal.org/node/3519187
https://www.drupal.org/node/3520028
https://www.drupal.org/node/3522240
https://www.drupal.org/node/3524461
https://www.drupal.org/node/3525389
https://www.drupal.org/node/3529500
https://www.drupal.org/node/3531945
https://www.drupal.org/node/3532412
https://www.drupal.org/node/3533301
https://www.drupal.org/node/3533315
https://www.drupal.org/node/3533560
https://www.drupal.org/node/3534610
https://www.drupal.org/node/3534849
https://www.drupal.org/node/3536432
https://www.drupal.org/node/3536715
https://www.drupal.org/node/3538666
https://www.drupal.org/node/3538678
https://www.drupal.org/node/3540264
https://www.drupal.org/node/3542527
https://www.drupal.org/node/3547352
https://www.drupal.org/node/3548961
https://www.drupal.org/node/3554127
https://www.drupal.org/node/3555936
https://www.drupal.org/node/3560399
https://www.drupal.org/node/3562304
https://www.drupal.org/node/3564958
https://www.drupal.org/node/3566774
https://www.drupal.org/node/3566783
https://www.drupal.org/node/3566814
https://www.drupal.org/node/3566911
https://www.drupal.org/node/3566982
https://www.drupal.org/node/3567484
https://www.drupal.org/node/3567619
https://www.drupal.org/node/3568146
https://www.drupal.org/node/3568389
https://www.drupal.org/node/3569330
https://www.drupal.org/node/3570919
https://www.drupal.org/node/3571594
https://www.drupal.org/node/3572185
https://www.drupal.org/node/3572345
https://www.drupal.org/node/3572594
https://www.drupal.org/node/3573884
https://www.drupal.org/node/3574112
https://www.drupal.org/node/3574738
https://www.drupal.org/node/3575062
https://www.drupal.org/node/3576311
https://www.drupal.org/node/3576336
https://www.drupal.org/node/3576855
https://www.drupal.org/node/3577675
https://www.drupal.org/node/3578055
https://www.drupal.org/node/3579527
https://www.drupal.org/node/3581062
https://www.drupal.org/node/3581109
https://www.drupal.org/node/3581222
https://www.drupal.org/node/3581570
https://www.drupal.org/node/3582107
https://www.drupal.org/node/3584928
https://www.drupal.org/node/3585318
https://www.drupal.org/node/3585574
https://www.drupal.org/node/3586362
https://www.drupal.org/node/3586484
https://www.drupal.org/node/3588040
https://www.drupal.org/node/3588109
https://www.drupal.org/node/3589636
https://www.drupal.org/node/3589759
https://www.drupal.org/node/3590230
https://www.drupal.org/node/3590298
https://www.drupal.org/node/3591660
https://www.drupal.org/node/3591939
https://www.drupal.org/node/3593451
https://www.drupal.org/node/3594014
https://www.drupal.org/node/3595086
https://www.drupal.org/node/3595653
https://www.drupal.org/node/3606616
https://www.drupal.org/node/3611848
https://www.drupal.org/node/3614321
https://www.drupal.org/project/drupal/issues/2538970
https://www.drupal.org/project/drupal/issues/3593485

https://www.drupal.org/node/3520028 and https://www.drupal.org/node/3581109 are issue URLs. But 3581109 is another issue that had no CR. #3520028: Remove support for selecting install profiles via the UI installer does have a CR. The issue is also marked as having a patch to be ported. So we might want to prevent this problem from being backported. Anyway, I suggest that we fix that URL too.

quietone’s picture

quietone commented
Status: Needs work » Needs review

#3520028: Remove support for selecting install profiles via the UI installer has been waiting for 2 months and since longwave left a question there, let's just fix these here.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Ok, looks good. That's all the feedback that I have. I validated all of the changes by making sure that the new URL points to a CR associated with the issue URL that's being replaced. They're all good.

  • longwave committed 1ef5fe73 on main 
    docs: #3616720 Fix change record links

By: quietone
By: dcam
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to main, doesn't backport cleanly to 11.x, but I think we should do the same fixes there - they are arguably even more important.

jeffreysmattson made their first commit to this issue’s fork.

jeffreysmattson opened merge request !16761

quietone’s picture

quietone commented

The changes to the entity counts in the migration tests are out of scope. We need to find out why they are failing on 11.x HEAD.

quietone’s picture

quietone commented

The failures on 11.x HEAD are being fixed over at #2672340: user_user_role_insert should not exist

The out of scope changes here need to be removed.

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Reviewed & tested by the community

This was a good backport

core/tests/Drupal/FunctionalTests/Installer/InstallerTestBase.php is the one file not included but checked on 11.x and it's not been deprecated there. #3520028: Remove support for selecting install profiles via the UI installer isn't backported yet.

  • larowlan committed cd5b3b09 on 11.x 
    fix: #3616720 Fix change record links

By: quietone
By: dcam
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed cd5b3b09390 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.