On installing this module and taking a look at the admin, I *thought* I had understood the model:

- create one or more "shares". Each share is responsible for providing a pop-up on certain nodes. The pop-up can include several tabs. The tabs are provided by sub-modules, such as link codes, share this, etc

However, I seem to get two different classes of share -- one for link codes, one for share this. They don't combine, and if I set both to say display within the node, I only get one and not both.

Is this the way it's meant to work? I'm rather baffled by it.
How can I combine link codes AND share this in one popup?
LinkCode shares have a widget at the bottom that says 'tab' -- if this isn't meant to take more tabs for the share, what does it do?

Comments

joachim’s picture

joachim commented
Category: support » bug

Ok, having installed the forward module, it seems to me that there's actually a bug here -- forward module provides a new tab in shares. ShareThis does not -- so I asusme ShareThis *ought to* appear as another tab, but s incorrectly implementing hooks for share or something like that.

Changing to bug report & will investigate.

joachim’s picture

joachim commented

Further delving... it looks like the share_sharethis module and the other supplied modules (links, service_links patch, and also forward module) use a largely different set of hooks.
I'm not sure what the idea is here -- are Share (plus modules that supply tabs) and ShareThis meant to be mutually exclusive?

greenskin’s picture

greenskin commented
Version: 5.x-2.0-alpha9 » 5.x-2.x-dev
Status: Active » Closed (fixed)

The Share module for Drupal 5 allows the creation of two different ways of sharing node content. One one is to use the ever popular ShareThis or use the method that Share module provides. Other modules can create tabs that are usable in the Share popup, these tabs though are not used in the ShareThis popup.

The Share module provides admins the ability to add different methods of sharing nodes for users. Share provides two sets of API's one is meant for the creation of tabs for the share type popup, the other is to create a different type of popup such as ShareThis. Contrib modules that create their own type of popup can use the tabs functionality, but the ShareThis popup type does not as the service has it's own tab type functionality.

The naming conventions are a bit confusing and should probably be thought out more.

greenskin’s picture

greenskin commented

I should also note that the API available for other modules to create a different popup type is provided so that it is possible to utilize and render the popup data (including tab data) in their own way, similar to how Views 2 works.

joachim’s picture

joachim commented
Status: Closed (fixed) » Active

Ah... yeah this could do with some explanation at least in code comments, such as doxygen comments for hooks.
Some user documentation on the project page or in the handbooks to explain this two-pronged approach would be a big help too.

There still is a bug here though isn't there -- if I add a regular Share and also a ShareThis, only one appears. Either both should, or the UI should warn me there is a problem.

greenskin’s picture

greenskin commented

They both should show. Which version of the Share module are you using? The dev version has a fix that was preventing popups that had specific node types selected from loading correctly.

greenskin’s picture

greenskin commented
Status: Active » Closed (duplicate)

Marking as duplicate.
#357532: documentation needed.