After updating to drupal/core 11.4.0 the pagedesigner infinitely loads when trying to open any page. The root cause seems to be, that the file pagedesigner.module uses $theme->subpath. It seems that ->subpath has been removed. I couldnt find any notes on that for the update but replacing subpath with $theme->getPath() fixed the issue for me.
Issue fork pagedesigner-3608571
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
guillaumepacilly commentedComment #4
akshay kashyap commentedComment #5
guillaumepacilly commentedComment #6
akshay kashyap commentedI tested the MR locally and the proposed change fixes the issue for me on Drupal 11.4. Replacing the removed subpath property with getPath() restores the editor, and I didn't notice any regressions while opening and editing pages.
I only have one suggestion before RTBC. Since this is a compatibility fix for a core API change, it would be nice to add some automated test coverage if the project's test suite allows it. A simple test verifying that the generated theme_namespaces values are still built correctly would help prevent similar regressions in the future.
It would also be useful to confirm that this has been tested with both core and contributed themes, although I would expect getPath() to behave consistently in all supported cases.
Other than that, the change looks straightforward and aligns with the current Drupal API.
Comment #7
guillaumepacilly commentedComment #9
guillaumepacilly commentedComment #11
guillaumepacilly commented