After updating to drupal/core 11.4.0 the pagedesigner infinitely loads when trying to open any page. The root cause seems to be, that the file pagedesigner.module uses $theme->subpath. It seems that ->subpath has been removed. I couldnt find any notes on that for the update but replacing subpath with $theme->getPath() fixed the issue for me.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

johannes.heinzerling created an issue. See original summary.

guillaumepacilly’s picture

Status: Active » Needs review
akshay kashyap’s picture

Assigned: Unassigned » akshay kashyap
guillaumepacilly’s picture

akshay kashyap’s picture

I tested the MR locally and the proposed change fixes the issue for me on Drupal 11.4. Replacing the removed subpath property with getPath() restores the editor, and I didn't notice any regressions while opening and editing pages.

I only have one suggestion before RTBC. Since this is a compatibility fix for a core API change, it would be nice to add some automated test coverage if the project's test suite allows it. A simple test verifying that the generated theme_namespaces values are still built correctly would help prevent similar regressions in the future.

It would also be useful to confirm that this has been tested with both core and contributed themes, although I would expect getPath() to behave consistently in all supported cases.

Other than that, the change looks straightforward and aligns with the current Drupal API.

guillaumepacilly’s picture

Status: Needs review » Reviewed & tested by the community

guillaumepacilly’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

guillaumepacilly’s picture

Status: Fixed » Closed (fixed)