Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 12.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#6 xray_audit.3.x-dev.rector.patch5.96 KBproject update bot
#6 interdiff-last-bot.7191663.txt80.46 KBproject update bot
#5 xray_audit.3.x-dev.upgrade_status.post_rector.txt10.61 KBproject update bot
#5 xray_audit.3.x-dev.rector.patch107.82 KBproject update bot
#5 interdiff-last-bot.7168466.txt49.38 KBproject update bot
#4 xray_audit.3.x-dev.upgrade_status.post_rector.txt7.02 KBproject update bot
#4 xray_audit.3.x-dev.rector.patch58.29 KBproject update bot
#4 interdiff-last-bot.7153270.txt1.83 KBproject update bot
#2 xray_audit.3.x-dev.upgrade_status.post_rector.txt7.02 KBproject update bot
#2 xray_audit.3.x-dev.rector.patch57.54 KBproject update bot

Issue fork xray_audit-3607546

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

project update bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new xray_audit.3.x-dev.rector.patch57.54 KB
new xray_audit.3.x-dev.upgrade_status.post_rector.txt7.02 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.0.0-beta7, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-864040

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha2
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: 1.0.0-beta7

project update bot opened merge request !87

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.7153270.txt1.83 KB
new xray_audit.3.x-dev.rector.patch58.29 KB
new xray_audit.3.x-dev.upgrade_status.post_rector.txt7.02 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.1.1, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-884047

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha3
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: 1.1.1
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.7168466.txt49.38 KB
new xray_audit.3.x-dev.rector.patch107.82 KB
new xray_audit.3.x-dev.upgrade_status.post_rector.txt10.61 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.1.3, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-978641

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha3
  2. mglaman/phpstan-drupal: 2.2.1
  3. palantirnet/drupal-rector: 1.1.3
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.7191663.txt80.46 KB
new xray_audit.3.x-dev.rector.patch5.96 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.1.3, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-1013401

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha3
  2. mglaman/phpstan-drupal: 2.2.1
  3. palantirnet/drupal-rector: 1.1.3

lpeidro made their first commit to this issue’s fork.

lpeidro’s picture

lpeidro commented
Issue summary: View changes

Drupal 12 compatibility and insight fixes:

  • Declare `^11.3 || ^12` compatibility and enable the next major CI job (dev dependencies allowed via `_LENIENT_ALLOW_LIST`).
  • Insights: use `RequirementSeverity` enums (severities were being dropped on 11.3+), fix the database table size insight never warning, and move `hook_requirements()` to an OOP `runtime_requirements` hook.
  • Convert all task, group and insight plugins to PHP attributes (annotations still supported for BC).
  • Tests: PHPUnit attributes, `#[RunTestsInSeparateProcesses]`, remove `setAccessible()`, add coverage for insight severities and the requirements hook.
  • Minor fixes: undefined variable in block layout conditions, wrong placeholders and texts, unused config schema keys.

Note: Webform tests are expected to fail on the next major job until Webform releases a Drupal 12 compatible version.

  • lpeidro committed 5f329de7 on 3.x 
    Issue #3607546: Do not type FieldUsage against an 11.5-only interface

  • lpeidro committed 6c0886e6 on 3.x 
    Issue #3607546: Inject the update and options services

  • lpeidro committed 905b3064 on 3.x 
    Issue #3607546: Add void return types to kernel test base overrides

  • lpeidro committed 16ea2c8a on 3.x 
    Issue #3607546: Use the Drupal 11.5 update and options services

  • lpeidro committed 04d2a091 on 3.x 
    Issue #3607546: Allow dev dependencies on the next major CI job

  • lpeidro committed aae52af7 on 3.x 
    Issue #3607546: Use PHPUnit attributes in tests

  • lpeidro committed a4edf5e7 on 3.x 
    Issue #3607546: Fix CSpell unrecognized word in test marker

  • lpeidro committed 8559acae on 3.x 
    Issue #3607546: Remove renderPlain() usage from...

  • lpeidro committed 269d9d59 on 3.x 
    Issue #3607546: Use attributes for task and group plugins

  • lpeidro committed 60344d98 on 3.x 
    Issue #3607546: Fix undefined condition summary and wrong docblock type

  • lpeidro committed a93aaae3 on 3.x 
    Issue #3607546: Fix insight severities and update xray_audit_insight for...

  • lpeidro committed 23fa979e on 3.x 
    Issue #3607546: Declare Drupal 12 compatibility