The handler extracts the sheet ID from #gid=123, but Google Sheets URLs can also include ?gid=123. Those currently validate but silently fall back to sheet ID 0.
Use a URL like: https://docs.google.com/spreadsheets/d/SPREADSHEET_ID/edit?gid=123
Expected: sheet ID 123 is stored.
Actual: sheet ID defaults to 0.
Parse the URL with parse_url() and support both fragment and query gid values.
Supports #gid=123.
Supports ?gid=123.
Supports URLs with both query params and fragment.
Adds test coverage.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
elamanComment #4
nitinkumar_7 commentedRan through the test matrix and its solid - fragment-only, query-only, both together, noisy URLs with extra params (usp=sharing, range=A1), no-gid fallback to 0, bare URL, plus 4 invalid-URL cases. That's good coverage, I dont have obvious gaps to add.
One case I'd manually try that isn't in the provider: a URL with gid=0 explicitly in the query string, just to confirm it's distinguished correctly from "no gid found" - even though they resolve to the same value, I want to make sure thats by design and not a coincidence of the default.
Comment #5
elaman