Replace "photoswipe.drush.inc" with a native Drupal 11 "DrushCommands" class

Starting to work on this, assigning it to myself

Marking this for review. Please let me know if anything seems out of scope or needs some rectification.

Hi @sapnil_biswas very nice, thank you! Did you also test this manually already?

PS: Is it maybe possible to add a test if this works? (Unsure if that's possible in GitLab CI because it would request external ressources)...

Hello @anybody, I tested this manually in my local environment and verified that it works correctly. However, I haven't conducted thorough testing of all possible use cases yet as I am in the midst of my university exams and GSoC. I will be able to add the tests if required in this current issue after 2 weeks or so, If anyone wants to take it from here, they are much appreciated to take this on

I thought about placing a constant for the Photoswipe download URL into the main module, but it's already in the .libraries.yml and in composer, so I think it won't help much.

Thanks @sapnil_biswas let's keep it like this, should be a good enough replacement. Only tests left and I left some final comments.

@anybody I am done with adding the tests I tried running them without dt_mock.inc, but the CI pipeline failed with a Call to undefined function dt() fatal error because KernelTests don't automatically load Drush. So, the mock is strictly necessary for the tests to run. This is my first time with such tests so let me know if this require any kind of refactor

Hey @grevil, thanks for the change of tack! I pushed a few fixes to get the pipeline back to green. Reverted cross-partition directory move to Symfony's Filesystem::rename (Drupal's move fails for cross-partition directories in CI). Small bug fix in mock ZIP structure of the test. Let me know if there is anything more to be addressed

@sapnil_biswas did you test this manually?

Yes, I have manually tested photoswipe:install-plugin command locally on a clean Drupal 11 environment

Test fail now with the stricter handling, I think we should keep the code and check the deeper reason.

So I dug deeper into this Drupal's FileSystem::move() fails because it falls back to PHP's copy() when moving across partitions (e.g. from /tmp to DRUPAL_ROOT in CI). PHP's copy() crashes as it only works on files and not directories. Cross-partition directories are mirrored recursively by Symfony’s Filesystem::rename(). In Drupal core we have this limitation, so what do you think about reverting back to Symfony's Filesystem only for this move operation?