Problem/Motivation

Fix broken CI Pipeline, currently it's failing, which for example prevents auto-merge from working.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3578585

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

sapnil_biswas made their first commit to this issue’s fork.

sapnil_biswas’s picture

sapnil_biswas commented
Assigned: Unassigned » sapnil_biswas

sapnil_biswas opened merge request !144

sapnil_biswas’s picture

sapnil_biswas commented
Status: Active » Needs review

@anybody
Marking this as needs review please let me if there is any scope of improvement

schillerm changed the visibility of the branch 5.x to hidden.

schillerm changed the visibility of the branch 5.x to active.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: sapnil_biswas » grevil

@grevil: Could you do me the favor?

Let's also raise the gitlab ci level to fail if one of phpcs etc. fail

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

phpstan also needs to be fixed and we need to align the .gitlab-ci.yml

grevil made their first commit to this issue’s fork.

grevil closed merge request !144

grevil opened merge request !149

grevil’s picture

grevil commented

Thanks! Moved the fixes to the dedicated issue branch. Working on the default branch is not recommended.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, just phpcs left plus the gitlab-ci changes to make cspell etc. fail entirely instead of a warning.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Reviewed & tested by the community

Alright, that's it! The rest of the phpstan related changes will be done in a follow up drush command issue!

  • grevil committed 95859515 on 5.x 
    fix: #3578585 Fix tests and code style (phpcs. phpstan, styleint, cspell...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Great work @sapnil_biswas!

Merged. :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3605632: Replace "photoswipe.drush.inc" with a native Drupal 11 "DrushCommands" class

@sapnil_biswas maybe you'd like to also pick up the follow-up?
#3605632: Replace "photoswipe.drush.inc" with a native Drupal 11 "DrushCommands" class

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.