Problem/Motivation

The recurrence fields don't currently validate whether the pattern you've entered makes sense.

Proposed resolution

Add a constraint validator that checks the recurrence pattern to confirm that it actually yields at least one instance before allowing the series to be saved.

User interface changes

Attempting to create a series with a nonsensical pattern will now result in a form error on the event series and prevent it from being saved until corrected. Enabling this new constraint should be optional in the event series settings.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

muriqui created an issue. See original summary.

muriqui’s picture

Status: Active » Needs review
muriqui’s picture

Status: Needs review » Needs work

Should probably make this optional.

muriqui’s picture

Issue summary: View changes
muriqui’s picture

Issue summary: View changes
muriqui’s picture

Status: Needs work » Needs review
eric.napier’s picture

Status: Needs review » Reviewed & tested by the community

Tested in Tugboat live preview and an integration environment with Recurring Events enabled. Fix works as expected and automated tests added to cover scenarios affected by the code change. All code and tests reviewed for standards / best practice.

  • muriqui committed 6d65befe on 3.0.x
    feat: #3605486 Add constraint validator to prevent invalid recurrence...
muriqui’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.