Problem/Motivation

PHP 8.5 deprecates curl_close(). Since PHP 8.0 a cURL handle is a CurlHandle object that is freed automatically when it goes out of scope, so curl_close() has been a no-op and is now formally deprecated (PHP 8.5 deprecations).

HAL calls it in a functional test, which emits a deprecation notice on PHP 8.5:

FILE: tests/src/Functional/page_cache/PageCacheTest.php
132 | WARNING | Function curl_close() is deprecated since PHP 8.5

Steps to reproduce

Run PHPCompatibility against the module on PHP 8.5, or run the test suite under PHP 8.5 and observe the deprecation from PageCacheTest::getHeaders().

Proposed resolution

Remove the curl_close($ch); call at tests/src/Functional/page_cache/PageCacheTest.php line 132. No replacement is needed — the handle is released automatically.

Issue fork hal-3601383

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pfrenssen created an issue. See original summary.

pfrenssen opened merge request !17

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Thanks, I'll look at merging the D12 updates this weekend and cutting a release

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.