This small patch should solve the issue that comment_mover does not jump back to the right comment.

Next, we are going to make comment_moderation work together with the comment_mover module: http://drupal.org/node/359066

Yesterday, we made the hidden module work with the comment_moderation module: http://drupal.org/node/359074

IMC linksunten

CommentFileSizeAuthor
#1 comment_mover.module.diff2.1 KBlinksunten
Tag1 supports Drupal development!Tag1 logo

Comments

linksunten’s picture

linksunten CreditAttribution: linksunten commented
FileSize
comment_mover.module.diff2.1 KB

Sorry, the first patch only corrects the return URL when pruning. This one should correct the grafting, too. And comment_moderation now works together with comment_mover...

Flying Drupalist’s picture

Flying Drupalist CreditAttribution: Flying Drupalist commented

Can this be committed?

Kripsy’s picture

Kripsy CreditAttribution: Kripsy commented
Status: Needs review » Reviewed & tested by the community

I can confirm this patch works.

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I understand what this patch is doing but I am unclear of the problem it is suppose to be fixing. What exactly is the use case for this?

linksunten’s picture

linksunten CreditAttribution: linksunten commented

When you move a comment, you do get redirected to the page where you moved the comment to - but not to the comment itself (on that page). So you have to scroll down all the time...

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented

Ok, I can see the use case there for graft.

This patch is also redirecting back to the comment on prune as well though, which seems counter intuitive to me. After pruning a comment I would want to then navigate to where the new comment is going to be and to do that you would need to use the site navigation which is at the top of the site somewhere in 99% of sites. If you redirect back to the comment you would then have to scroll back to the top to continue.

Is there a use case for redirecting to the comment on prune? Currently, it seems this patch is fixing one issue and creating another.

linksunten’s picture

linksunten CreditAttribution: linksunten commented

I do not agree. For me it is counter intuitive to be redirected at all. When I click on prune I just want to stay where I am. Normally I only want to move comments around in the same article. A redirect forces me to reorientate myself which costs time and nerves. The best I could think of (next to an AJAX solution which does not change the setting at all) is a redirect to the pruned comment.

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

This is another example of different user needs that is currently making lots of decisions in developing this module hard to balance. The only time moving comments around on the same thread is useful is when you are displaying threaded because with flat it will always appear at the bottom no matter where you click graft, in fact in the flat case it is best to click graft on the node.

So for those displaying flat, which I think are most the current users, going to the top is the most useful. While those that are displaying threaded, which I definitely want to support, it is not necessarily useful.

All of this will be meaningless with the new 2.x interface though. So instead of spending any more time on this small usability detail that doesn't have a clear answer, I think I am just going to leave it as is and spend the time incorporating the user opinions in this issue thread into making 2.x better.