Closed (fixed)
Project:
Ubercart
Version:
6.x-2.0-beta2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Jan 2009 at 13:43 UTC
Updated:
17 Feb 2009 at 16:10 UTC
Jump to comment: Most recent file
this is popping up all over the place. Postgres (at least as far as 8.3) does not have unsigned types. In http://drupal.org/node/109060, it appears that the Drupal core puts in some new domains for unsigned integers, but not for floating-point types. So we need to add this domain:
CREATE DOMAIN real_unsigned
AS real
CONSTRAINT real_unsigned_check CHECK ((VALUE >= 0));
ALTER DOMAIN real_unsigned OWNER TO drupal;
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 20090203_unsigned.txt | 1.73 KB | VinceW |
| #2 | float_change.patch | 7.15 KB | cha0s |
Comments
Comment #1
cha0s commentedCould you provide steps to reproduce?
EDIT: nevermind, I just got my server fully set up for pgsql, merely enabling the modules threw a bunch of those errors. =) Thanks...
Comment #2
cha0s commentedWe talked and decided it was better to implement the proper validation where necessary and change our floats to signed. Here's a patch reflecting that...
Comment #3
Island Usurper commentedExcellent. Committed.
Comment #4
VinceW commentedLS,
I'm having this problem a few weeks now. After reading this thread i even tried a fresh install with:
Postgres 8.3.1 (client_encoding = 'UTF8')
Drupal 6.9
Ubercart 6.x-2.0-beta3 (uc_order.install,v 1.9.2.7 2009/01/19 20:31:26)
Did not work (for me). Guess i may be doing something wrong.
Ubercart CA did install correctly, but when installing uc_orders i got a bunch of pg_ warnings.
Hope someone can point me a direction to solve this.
Regards,
VinceW
Comment #5
rszrama commentedAhh, yeah, this fix isn't in the beta3. It's in the latest development code available from our Bazaar repository for D6. On a clean beta3 you should be able to apply the patch from #2, tho.
Comment #6
VinceW commentedLS,
Patch applied. Ubercart core-modules installed on Postgresql 8.3.1 without any errors.
When applying the patch, i noticed in: uc_taxes/uc_taxes.install another 'unsigned' (on line 16).
Perhaps not relevant, or forgotten. Thought i let you know.
tnx for pointing out.
VinceW
Comment #7
Island Usurper commentedThat's for the serial column, and Drupal tells Postgres how to handle that. This patch is only to remove the unsigned flag from float or real columns.